[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 Hi @yfeldblum, thanks for taking a look into this for us, appreciate your help. A new PR would be great that way it gives the ASF the needed audit trail of the origination of the pull request code contribution coming from Facebook to the ASF. ---
[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 We can not directly accept this PR as it contains code that originated in fbthrift. We need someone from Facebook to contribute the code or files back to Apache Thrift for use by the ASF. @djwatson if you have some free time would you mind contributing back the recent updates to fbthrift in the cpp lib around the Application and Transport Exception headers to help resolve this issue? Appreciate your time and help as always. - https://github.com/facebook/fbthrift/blob/master/thrift/lib/cpp/TApplicationException.h - https://github.com/facebook/fbthrift/blob/master/thrift/lib/cpp/transport/TTransportException.h ---
[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 @jeking3 `Do we really need to ask for permission to add three additional error codes from fbthrift?` - yes, if there is something in Facebook fbthrift that someone wants to add to Apache Thrift it has to come as a contribution from Facebook. @Jens-G I cant recall a ticket for it either, but agree with having the common portion built into the generator to reduce updating many touch points in the code ---
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1410 @dkochmanski Travis support responded saying that no one from TurtleWarePL has logged into https://travis-ci.org/ ever and this is the reason this PR is not getting run within travis. From Travis support: > do you think one of their members could try to log into Travis CI at least once at https://travis-ci.org/ and try closing and reopen one of the rejected Pull Requests? ---
[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support
Github user jfarrell commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149655532 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti Computing --- End diff -- That would be great. is it possible fetch his work as a third party downloadable dependency or was it used as the basis for work you did on top of it? ---
[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support
Github user jfarrell commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149508723 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti Computing --- End diff -- @dkochmanski thank you for working on this and contributing it back the the Apache Thrift. The Apache license header on this should not contain a copyright to Rigetti Computing, details available at https://www.apache.org/legal/src-headers.html#headers part 2 ---
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1410 Travis requests show an error with "Abuse detected". I've emailed Travis support asking them to look into the issue ---
[GitHub] thrift pull request #1327: make thrift error:class ‘apache::thrift::transp...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1327 ---
[GitHub] thrift pull request #1323: THRIFT-3775: 0.10.0 release
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1323 ---
[GitHub] thrift pull request #1288: THRIFT-3775: 0.10.0 release
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1187: Review for pull up of RUST extended namespace sup...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #723: dub.sdl for integration into Dlang package registry
Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/723
Any objections to switching this to dub.json as follows ?
```
{
"name": "apache-thrift",
"description": "Apache Thrift D library",
"authors": [
"Apache Thrift Developers "
],
"homepage": "http://thrift.apache.org";,
"license": "Apache-2.0",
"dependencies": {
"libevent": {
"version": "*",
"optional": "true"
},
"openssl": {
"version": "*",
"optional": "true"
}
},
"targetType": "library",
"sourcePaths": [
"src"
],
"importPaths": [
"src"
],
"excludedSourceFiles": [
"src/thrift/index.d"
]
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1064: THRIFT-3897
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #617: fix PHP TCompactProtocol Int64 trans error when nu...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/617 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #467: Work around [THRIFT-3118] MemoryError when using a...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #560: THRIFT-3263: PHP Compiler always casts scalar type...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #549: Fix path to generated dirs for python examples in ...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #557: Thrift 3251 Add http transport for server to Go li...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #639: Implements ssl sockets on c_glib
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #194: THRIFT-2668 TestSuite: detailed result on passed t...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #226: THRIFT-2721: reduce complexity of generated erlang...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #278: THRIFT-2796: Added testcase for THRIFT-2793. Needs...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #354: THRIFT-2940: Package json
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #328: THRIFT-2899: Prefix enum values with the Cocoa nam...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #356: THRIFT-2941
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #386: THRIFT-2983: replaces deprecated -[NSData getBytes...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #475: THRIFT-3121 Librt does not exist on OSX
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #432: [THRIFT-3088] TThreadPoolServer with Sasl auth may...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #500: THRIFT-3112: Typed AsyncMethodCallback with return...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #529: [THRIFT-3204] SimpleServer processRequests method ...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #501: THRIFT-3154: tornado tutorial fail to work
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #577: THRIFT-3288 c glib build unit tests with all warni...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #651: THRIFT-3380 nodejs Fix broken transport and protoc...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #688: THRIFT-3385 warning: format ‘%lu’ expects ‘l...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #991: dependency version constraints for haskell
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1082: THRIFT-3828 In cmake avoid use of both quoted pat...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #733: THRIFT-3474 Docker: thrift-compiler
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/672 @zertosh if you can submit a patch to update the version of ws in use we can look at turning around a 0.11.0 to help out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1113: Updated Stop by comment from Patrick Benett
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/672 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #325: THRIFT-2561: Typedef enums using NS_ENUM.
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #327: THRIFT-2898: Generated classes implement the NSCop...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #311: THRIFT-2882 Lua Generator: using string.len funtio...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 sure, or modify the ticket description to 'disable compiler plug-ins by default for all builds' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 We have had issues with plugin support being on by default in a couple build instances now, and this does not fix when we pull out autoconf that it wont reappear with cmake. I'd like to see us change the defaults here and make --with-plugin the optional to enable and having WITH_PLUGIN=no so it is disabled by default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1098: THRIFT-3775: 0.10.0 release
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1098 @tylertreat-wf just pushed the [0.10.0 tag](https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=tag;h=ae93ff0b4bdbd6749f75c23ad23311b512230894), once the mirror picks it up github will have it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1098: THRIFT-3775: 0.10.0 release
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1098 had left it open while still publishing the packages, can close it out and continue that in the background now that the source release is out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1098: THRIFT-3775: 0.10.0 release
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1098 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1137: Implement CONST support
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1139: THRIFT-3999 Fix debian package set up scripts.
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1139: THRIFT-3999 Fix debian package set up scripts.
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1139 Thanks for the patch, commit 0c27352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1139: THRIFT-3999 Fix debian package set up scripts.
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1139 would leave in build-essential, otherwise loks good and +1, @matyapiro31 mind adding build-essential back in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1130: fix typo in package name.
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1138: Add union example to ThriftTest
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1138 could use a stub with a successful return and a TODO comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1138: Add union example to ThriftTest
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1138 I just rebased the release candidate against master and fixed the broken haskel tests so if parts of this are committed all ready then they will be apart of the release candidate. I would advocate for committing as portions become available and not hiding in a branch or personal fork and try and structure the commits as logical groups which do not break anything as they go in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1111: THRIFT-3546: Remove global namespace objects from nodejs...
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/ at quick run through patch looks ok to me, @Jens-G @RandyAbernethy can either of you please review also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1101: THRIFT-3937: if the compiler is too old (gcc before 4.8)...
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1101 License on this autoconf macro is GPLWithACException, we can not include it with Apache Thrift. see http://www.apache.org/legal/resolved.html#category-x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1098: THRIFT-3775: 0.10.0 release
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1098 @RandyAbernethy @Jens-G @jeking3 any of you aware of the appveyor openssl issue this build just triggered? ``` appveyor DownloadFile https://slproweb.com/download/Win64OpenSSL-%OPENSSL_VERSION%.exe Error downloading remote file: One or more errors occurred. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1098: THRIFT-3775: 0.10.0 release
GitHub user jfarrell opened a pull request: https://github.com/apache/thrift/pull/1098 THRIFT-3775: 0.10.0 release Initial versioning switch for the 0.10.0 release candidate Please do not merge this to master, I will commit this patch when it is passing all tests to the release branch and start the vote thread You can merge this pull request into a Git repository by running: $ git pull https://github.com/jfarrell/thrift rel/0.10.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1098.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1098 commit d679b3d42202ff87ed2891cc316075d8f9268a6c Author: jfarrell Date: 2016-04-04T18:25:03Z THRIFT-3775: 0.10.0 release Client: build Patch: jfarrell 0.10.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1096: fix snprintf error in TServerSocket.cpp under vs2...
Github user jfarrell commented on a diff in the pull request: https://github.com/apache/thrift/pull/1096#discussion_r80729988 --- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp --- @@ -16,7 +16,9 @@ * specific language governing permissions and limitations * under the License. */ - +#if defined(_MSC_VER) && (_MSC_VER < 1900) +#define snprintf _snprintf --- End diff -- One of our goals early on was to maintain latest version and not try and support everything available as it would become too difficult to maintain. What is the minimum set here that is in LTS, I would say we try and cover latest and possible one or two back (if that) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1091: THRIFT-1108: Adding SSL support for ruby
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1091 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1091: THRIFT-1108: Adding SSL support for ruby
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1091 Thanks for the patch,Committed, 04e6f62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1092: THRIFT-948: Adding SSL support for php
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1092: THRIFT-948: Adding SSL support for php
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1092 commit 311c984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1061: THRIFT-3893 Command injection in format_go_output
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1061 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1061: THRIFT-3893 Command injection in format_go_output
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1061 committed in 2007783e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1086 ping @RandyAbernethy for thoughts on this patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1024: THRIFT-3850: All apache builds are failing when i...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1024 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1024: THRIFT-3850: All apache builds are failing when i...
GitHub user jfarrell opened a pull request: https://github.com/apache/thrift/pull/1024 THRIFT-3850: All apache builds are failing when initiated from a github THRIFT-3850: All apache builds are failing when initiated from a github pull request to Jenkins Disabled jenkins jobs, added blank line to .travis.yml and triggering builds to get baseline for fixing travis. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jfarrell/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1024.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1024 commit 3591b1effb5b4691c723499af7d2d802ef15715c Author: jfarrell Date: 2016-06-12T01:27:06Z THRIFT-3850: All apache builds are failing when initiated from a github pull request to Jenkins Disabled jenkins jobs, added blank line to .travis.yml and triggering builds to get baseline for fixing travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2998: Set Content-Type for HTTP reques...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/378#issuecomment-187493321 @RandyAbernethy agree with your suggested approach of committing this and creating a backlog story to tackle the larger IANA registered media type as a follow up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/733#issuecomment-169193943 @nsuke correct, gofmt is called in the compiler --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: dub.sdl for integration into Dlang package re...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/723#issuecomment-161174779 hey @nrTQgc, what is can you please outline what is required to register the package or link to documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-153717368 @marshalium I cut 0.9.3 off master, so everything in master or on the 0.9.3 branch should work for your testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3290: Making from as a reserved langua...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2936: fix crash in memory handling in ...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/619 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Add UNIX Domain Socket support
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/516#issuecomment-140739419 Thanks, I like that you have submitted euds upstream, would be nice to not have that as a dependency and just use it natively. Is there any traction on that pull request to OTP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Add UNIX Domain Socket support
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/516#issuecomment-140596216 hey @saleyn, thanks for the patch. We try to keep our dependencies to a minimum to make it easier for the client libraries to be integrated into a wide variety of projects. One quick thing i see with this patch is that euds does not have a license, which makes it a little harder for us to even look at integrating with Apache Thrift. Can the same result be achieved using native support without too much additional lifting? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Trying out the Travis CI beta setup
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/548#issuecomment-140595373 This is now publicly available, closing test pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Trying out the Travis CI beta setup
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: c_glib: Compiler: Omit processing-function de...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: c_glib: Compiler: Omit processing-function de...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/575#issuecomment-140595297 Committed as part of THRIFT-3284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: make generated js file strict mode for nodejs
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/480#issuecomment-140595062 @taojoe thanks for the patch, appreciate the help. Would you mind creating a ticket for this in our jira http://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3324 - Update `go get` command to incl...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: 0.9.2
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: 0.9.2
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/588#issuecomment-140538797 hi @akash3456, not sure what the problem is here, would you mind opening a ticket for your issue or emailing our dev@thrift.apache.org mailing list with the issue you are seeing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Create thrift
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/600#issuecomment-140537455 Closing blank pull request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Create thrift
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: there is no 'What' in InvalidOperation, maybe...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/213#issuecomment-137140629 sorry, had missed the question on this. like the idea of pairing it as TType.UTF8 and TBinaryProtocol.writeUtf8() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Making from as a reserved language keyword
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/579#issuecomment-127995660 Hi @prathik, Thanks for the patch. would you mind adding an issue for this on our jira so we can better track it. Details on our process are available here http://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-123525168 hey @marshalium, i'm working on cutting the 0.9.3 rc right now and using the docker containers in build/docker/ to do so. Travis is working to enable docker support and we are in the beta for this, once 0.9.3 is cut i'll be working to switch us over to that, which should help make the CI runs more consistent across environments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Add http transport for server in Golang
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/556#issuecomment-123153319 Hi @hhkbp2, thanks for the patch. Can you please follow our how to contribute guide for submitting a patch back to Apache Thrift, thanks and appreciate the help. http://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Trying out the Travis CI beta setup
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/548#issuecomment-121285896 I have not tried this out yet, this has been one of the longer lagging issues I would love to address, but travis not supporting docker has been a blocker until now. I am preparing for a release candidate now and will plan on investing some time into fully testing this out in one of my branches. appreciate your help and also making docker support a direct possibility in travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Trying out the Travis CI beta setup
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/548#issuecomment-121234119 hey @joshk, i'm testing the docker build now with the following. We are looking to simplify this process with our next release, but currently the main tests can be run with ``` docker build -t thrift build/docker/ubuntu docker run -it --rm -v $(pwd):/thrift thrift /bin/bash -c "cd /thrift && ./bootstrap.sh && ./configure && make check" ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Trying out the Travis CI beta setup
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/548#issuecomment-120985354 yes, if we can get into the beta that would be great. our dockerfile that .travis.yaml mirrors from is build/docker/ubuntu/Dockerfile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Trying out the Travis CI beta setup
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/548#issuecomment-120975801 Hey @joshk, would love to get to a dockerized build in travis for testing so we can mirror our test env anywhere (currently having to duplicate setup in .travis.yaml and in dockerfiles is not ideal). What are the new beta setup capabilities? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-119044633 we need to transition our jenkins build over to using the docker containers so we have more control over them and then can run whatever we like inside that. on my list for pre 1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/213#issuecomment-114706805 @c4urself working on the next RC now, if we can get all the changes in this patch and the comments from @jeroenvlek into one patch updated against trunk and passing tests then happy to get it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3155 move contrib/mingw32-toolchain.cm...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/495#issuecomment-102416239 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: fix bug for: BadYieldError: yielded unknown o...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/375#issuecomment-93617743 Thanks for your patch @largetalk, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
