[GitHub] thrift issue #1521: THRIFT-4531 (#1)

2018-03-27 Thread margars 
Github user margars commented on the issue:

https://github.com/apache/thrift/pull/1521
  
Build failed with Gradle POM parsing error which has nothing to do with the 
commit.


---

[GitHub] thrift pull request #1521: THRIFT-4531 (#1)

2018-03-27 Thread margars 
GitHub user margars opened a pull request:

https://github.com/apache/thrift/pull/1521

THRIFT-4531 (#1)

THRIFT-4531: Fix generated Python read() method for immutable structs with 
optional members.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/margars/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1521


commit 969047b3c09af133dd3d24591baedc8ed3c52318
Author: Margar Simonyan 
Date:   2018-03-27T12:30:14Z

THRIFT-4531 (#1)

THRIFT-4531: Fix generated Python read() method for immutable structs with 
optional members.




---

[GitHub] thrift issue #1520: THRIFT-4531

2018-03-27 Thread margars 
Github user margars commented on the issue:

https://github.com/apache/thrift/pull/1520
  
I am behind corporate firewall and don't know how to squash from the web 
interface, will try from scratch. 


---

[GitHub] thrift pull request #1520: THRIFT-4531

2018-03-27 Thread margars 
Github user margars closed the pull request at:

https://github.com/apache/thrift/pull/1520


---

[GitHub] thrift issue #1520: THRIFT-4531

2018-03-27 Thread margars 
Github user margars commented on the issue:

https://github.com/apache/thrift/pull/1520
  
Sorry, I am not familiar with all this setup and rules.


---

[GitHub] thrift pull request #1520: THRIFT-4531

2018-03-27 Thread margars 
GitHub user margars opened a pull request:

https://github.com/apache/thrift/pull/1520

THRIFT-4531

I am not familiar with your rules for contributions. This issue is 
described in JIRA THRIFT-4531. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/margars/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1520


commit d682b13e5e7672702e53f1e696263ef5293d8d37
Author: Margar Simonyan 
Date:   2018-03-27T11:22:10Z

Update t_py_generator.cc

Fix the generated read() method for immutable structures with optional 
members.

commit 14a4c46c480ae041bb51397cefc9be575f17f79a
Author: Margar Simonyan 
Date:   2018-03-27T11:26:51Z

Merge pull request #1 from margars/THRIFT-4531

Update t_py_generator.cc

commit 29289f4d8c88fee636b779a94aeae48bf81671b0
Author: Margar Simonyan 
Date:   2018-03-27T11:28:11Z

Revert "Update t_py_generator.cc"

commit 56dc4f04c20a9601063deec75630ff4212937a46
Author: Margar Simonyan 
Date:   2018-03-27T11:28:35Z

Merge pull request #2 from margars/revert-1-THRIFT-4531

Revert "Update t_py_generator.cc"




---