[GitHub] thrift pull request #1306: Fix Nodejs generation to auto deal with args clas...

2017-10-23 Thread wenshin
Github user wenshin closed the pull request at:

https://github.com/apache/thrift/pull/1306


---


[GitHub] thrift issue #1306: Fix Nodejs generation to auto deal with args class insta...

2017-10-23 Thread wenshin
Github user wenshin commented on the issue:

https://github.com/apache/thrift/pull/1306
  
@jeking3 Thanks for your nice reply, it's duplicate of #1034, I'll close 
this one.


---


[GitHub] thrift pull request #1306: Fix Nodejs generation to auto deal with args clas...

2017-07-11 Thread wenshin
GitHub user wenshin opened a pull request:

https://github.com/apache/thrift/pull/1306

Fix Nodejs generation to auto deal with args class instantiation

I found there is a logic for auto dealing with method args class 
instantiation, but not using

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wenshin/thrift fix/node-generation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1306


commit 9cf458bcb158c5f0f23dd0d89d53349bfaf88b44
Author: yuanwen <wenshin2...@gmail.com>
Date:   2017-07-11T14:19:54Z

Fix Nodejs generation to auto deal with args class instantiation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---