[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.

2017-03-06 Thread gadLinux
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1208
  
I added also some documentation and missing include functions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.

2017-03-07 Thread gadLinux
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1208
  
@jeking3 This was closed but not merged? Why?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.

2017-03-07 Thread jeking3
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1208
  
It was merged.  Pull master and look at the log.  When your commit is 
merged into master I have to amend the commit with "This closes #" which 
changes the commit hash, so git may tell you when you attempt to delete the 
branch that it hasn't been fully merged, but it has.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.

2017-03-07 Thread Jens-G
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1208
  
The careful reader will notice that it says "asfgit closed this in b79396f 
19 hours ago". The b79396f is a link to the commit you are looking for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---