[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Github user laysakura commented on the issue: https://github.com/apache/thrift/pull/1252 @jeking3 Thank you for feedback. > It would be acceptable to have the server put this information into the GlobalLogger (if Ruby has the same logging concept as the C++ runtime) so that it ends up in a server log file. That would not be a security issue. I got it. Ruby code does not have GlobalLogger-like feature, so I use the same code as https://github.com/apache/thrift/blob/master/lib/rb/lib/thrift/server/nonblocking_server.rb#L29-L34 to get a logger. Please check it ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1252 This looks okay to me, but I don't have any ruby experience; hopefully someone else who does can review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1252 @jeking3 If you're willing to take this...I have some ruby experience, and this looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1252 Great - well once I can commit again, I will. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1252 Tracked in THRIFT-4198. See [our contrib guide](http://thrift.apache.org/docs/HowToContribute) for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
