[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1285 Yes sorry about that, this was an expected breakage as the interface has changed. I suggest using `0.10` instead of `master`, that way you won't get any surprises like this until `0.11` is released. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors
Github user peterbourgon commented on the issue: https://github.com/apache/thrift/pull/1285 For the record, this caused build failures in Go kit; I don't imagine my usage is particularly strange, but maybe it is. ([Link](https://github.com/go-kit/kit/commit/4d3c82de4829f7c3752cf66d00d6ecdf913a18f3).) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1285 Closing PR until all tests are fixed, I don't want to waste Apache's Travis capacity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
