[GitHub] thrift issue #1309: Use build tags to support context.
Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1309 I will try to fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1309: Use build tags to support context.
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1309 Ah, now I see it. The Makefile for the tutorial has the `legacy_context` flag hardcoded, since it's pinned to the Go version included in the Docker container. If you are running it outside the container (and hence with Go 1.7+) you need to remove `legacy_context` and `thirdparty-dep` from the Makefile. @taozle Maybe there is a way to check the go version before adding the flag? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1309: Use build tags to support context.
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1309 go version go1.8.3 windows/amd64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1309: Use build tags to support context.
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1309 Hmm, turns out @taozle already [updated](https://github.com/apache/thrift/blob/c0d384a38c2b43ee47cef86b1cd054e3f84dc909/tutorial/go/Makefile.am#L37) the Makefile for the tutorial, I just missed it somehow. The `check` target already includes `thirdparty-dep`, so it should work with `make -k check` when you are running Go<1.7. What were your exact steps that resulted in this error? What's your Go version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1309: Use build tags to support context.
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1309 > I'll also be sending a PR to update the Go tutorial with the new handler signature. Please do. Right now the tutorial does not build. ``` handler.go:30:2: cannot find package "golang.org/x/net/context" in any of: C:\Go\src\golang.org\x\net\context (from $GOROOT) D:\Workdir\src\golang.org\x\net\context (from $GOPATH) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1309: Use build tags to support context.
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1309 Yep, they are unrelated. Thanks for working on this! @Jens-G what do you think? With this PR, we'll have `context` support for pre-1.7 Go versions as well. I'll also be sending a PR to update the Go tutorial with the new handler signature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1309: Use build tags to support context.
Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1309 Seems that the failed tests has nothing with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---