[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1311 @davinchia we've cleared out the CI build issues, so if you could squash your changes to one commit then rebase on master, then do a force push to refresh this pull request, it'll kick off a new build. Squashing will make it easier to apply the patch when the build completes successfully. ---
[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1311 @davinchia we've cleared out the CI build issues, so if you could squash your changes to one commit then rebase on master, then do a force push to refresh this pull request, it'll kick off a new build. Squashing will make it easier to apply the patch when the build completes successfully. ---
[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1311 @davinchia we've cleared out the CI build issues, so if you could squash your changes to one commit then rebase on master, then do a force push to refresh this pull request, it'll kick off a new build. Squashing will make it easier to apply the patch when the build completes successfully. ---
[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user davinchia commented on the issue: https://github.com/apache/thrift/pull/1311 @Jens-G Github must have hidden my comments. My latest commit combined the functions and removed the toString function as per your suggestions. Not sure why one of the integration tests are failing. Logs show `/usr/include/php5/Zend/zend_hash.h:266:2:` is the cause, which is not something I modified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1311 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user davinchia commented on the issue: https://github.com/apache/thrift/pull/1311 @Jens-G This is the first time I'm writing production C++ code so please feel free to tear this apart. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.
Github user davinchia commented on the issue: https://github.com/apache/thrift/pull/1311 https://stackoverflow.com/questions/30716354/how-do-i-do-a-literal-int64-in-go is a good summary of the different ways to assign constant values in Go. I decided to use an anonymous struct since it seems to be the most self contained and efficient way to do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
