[GitHub] thrift issue #1361: Implement multiplexed processor that matches CPP and Jav...

2017-09-15 Thread gadLinux 
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
We must also investigate the binary protocol in C since I think is leaking 
memory everywhere:

==4534== 2,399,952 bytes in 99,998 blocks are definitely lost in loss 
record 611 of 611
==4534==at 0x4C2FB25: calloc (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==4534==by 0x5300580: g_malloc0 (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5306.0)
==4534==by 0x4E49774: thrift_binary_protocol_read_string 
(thrift_binary_protocol.c:797)
==4534==by 0x4E48E55: thrift_binary_protocol_read_message_begin 
(thrift_binary_protocol.c:431)
==4534==by 0x4E46013: thrift_multiplexed_processor_process_impl 
(thrift_multiplexed_processor.c:60)
==4534==by 0x4E51864: thrift_simple_server_serve 
(thrift_simple_server.c:58)
==4534==by 0x108DAF: test_server_initialize (test_server.c:74)
==4534==by 0x5321459: ??? (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5306.0)
==4534==by 0x532138A: ??? (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5306.0)
==4534==by 0x5321631: g_test_run_suite (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5306.0)



---

[GitHub] thrift issue #1361: Implement multiplexed processor that matches CPP and Jav...

2017-09-15 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Recommend you open a different ticket for memory leaks in c_glib binary 
protocol.


---

[GitHub] thrift issue #1361: Implement multiplexed processor that matches CPP and Jav...

2017-09-17 Thread gadLinux 
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Hi @jeking3 don't worry I will fix the binary protocol memory leak. 

About the build I think this is failing because foreign problem, not by my 
changes. Cause it fails for decorator protocol that was already there since 
long time. Can you check it please? And merge it?


---