[GitHub] thrift issue #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap other fa...

2017-09-27 Thread ykhrustalev 
Github user ykhrustalev commented on the issue:

https://github.com/apache/thrift/pull/1375
  
thanks @jeking3 , duly noted 


---

[GitHub] thrift issue #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap other fa...

2017-09-27 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1375
  
In the future please squash to a single commit - it makes applying much 
easier.  I'll go commit this.


---

[GitHub] thrift issue #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap other fa...

2017-09-26 Thread dcelasun 
Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1375
  
LGTM, CI failures are unrelated.

cc @Jens-G 


---

[GitHub] thrift issue #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap other fa...

2017-09-26 Thread ykhrustalev 
Github user ykhrustalev commented on the issue:

https://github.com/apache/thrift/pull/1375
  
It is not quite obvious what are the reasons for CI failures but they don't 
seem to be related to the patch.


---