[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2018-01-04 Thread sokac 
Github user sokac commented on the issue:

https://github.com/apache/thrift/pull/1401
  
@jeking3 squashed and rebased. Looks like CI has some troubles, though


---

[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2018-01-04 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1401
  
Need to see if pass the CI build - please squash to a single commit, rebase 
on master, and force push.


---

[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2017-11-06 Thread sokac 
Github user sokac commented on the issue:

https://github.com/apache/thrift/pull/1401
  
@RobberPhex how does this look now? I don't have lots of context for other 
zval values so I'd leave that for another review.


---

[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2017-10-26 Thread RobberPhex 
Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1401
  
If we want process REFERENCE everywhere.
I think we should review every line of `zval` used, is it?


---