[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1448 I tried to use this work and did a little bit of cmake work to straighten out options. What I found is that there is a boost dependency in the safe_numeric_cast in TTransportException.hpp and there's another boost dependency in TProtocol.h (for endian detection) that needs to be resolved. What I would suggest is that you try building on Windows without boost, disabling build of tests and tutorials, so that all you build is the compiler and the C++ library. You can see what I did in my referenced pull request in my fork. ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1448 Thanks, that's incredibly helpful when it comes to merging it. ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user Typz commented on the issue: https://github.com/apache/thrift/pull/1448 Squashed everything in one big patch. ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1448 Would it be possible for you to squash this to make the merge easier? ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user Typz commented on the issue: https://github.com/apache/thrift/pull/1448 Indeed, it is complete now: the lib can be built without Boost, both through autoconf or cmake. Tests (based on boost test) and tutorial still require boost, though. ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1448 Is this done (for now) with the exception of that build issue, since you removed the [WIP] tag? ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user Typz commented on the issue: https://github.com/apache/thrift/pull/1448 @jeking3 : This exemple refers to conversions from 'wide' strings to UTF8 or UTF16. I used this exemple: http://en.cppreference.com/w/cpp/locale/codecvt_utf8_utf16 which shows conversion from UTF16 to UTF8. According to the name of the function, that should be what we expect; but maybe i was indeed mislead by the name, and it should be simply 'wide' to UTF8 ? ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1448 @Typz the example for this conversion on cppreference is different than your code. Try that? http://en.cppreference.com/w/cpp/locale/wstring_convert/to_bytes ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user Typz commented on the issue: https://github.com/apache/thrift/pull/1448 @jeking3 : any suggestion? ---
[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost
Github user Typz commented on the issue: https://github.com/apache/thrift/pull/1448 I have an issue with UBSan build: it keeps failing in codecvt, which may be due either to a bug in StdLib or simply to that lib not being compiled with UBSan... Any idea how to overcome this, and let the tests pass? ---
