[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1479 @dcelasun squashed ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1479 @RobberPhex can you squash your commits? ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1479 Added some doc comments. The actual code looks fine to me. ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Any other php folks out there want to comment or review on the breaking change here? It looks like the strategy was to change the generator and provide a flag to allow folks to generate older style code for backwards compatibility. ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Document all breaking changes in the language README. ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 If we are making breaking changes, they need to be documented very clearly in the php/README.md file as part of any commit. See my breaking changes for 0.10.0 and 0.11.0 in the perl/README.md for an example of what I mean. I'm not certain anybody on the mailing list is listening at this point, but if anyone has an interest in php breaking changes, you need to chime in. ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1479 Personally, I think we can mark classmap/old-style PHP compiler deprecated. And can be removed in future. And, ThriftClassLoader can also be removed in future, to migrate composer autoloader. ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
There are some break changes:
1. for generated code, old struct is `Types.php` for all args, results,
`.php` for `ServiceIf`, `ServiceClient`, etc.
new struct is `.php` for ``. Maybe cause some code
analyzer doesn't work.
2. for ThriftClassloader. before, user use
`$loader->registerDefinition('namespace', '')`.
At new struct, **it doesn't work**. user can use
`$composerLoader->addPsr4('namespace', '')` or
`$thriftLoader->registerNamespace('namespace', '')`.
3. for composer loader, generated code loaded via classmap. With new
struct, composer's classmap can also load psr-4 code. (of cause psr-4 is
recommended).
---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Are these changes all backwards compatible? ---
