[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 Thank you for the review! ---
[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1505 Looks like a dlang issue that pops up from time to time. Just to satisfy myself this change is okay I need to look at generated thrift file comparisons from before and after this change. I'll do that locally. ---
[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 Fix is in, the only failure left is this one, I'm not sure if it is instability of tests or real problem: https://travis-ci.org/apache/thrift/jobs/353050154 ---
[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 @jeking3 done, thanks, let's see if it passes. ---
[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1505 Please squash and rebase on master, I just merged 4 commits that stabilize the CI builds. ---
[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 Updated approach: t_const_value now defines ordering. Java generator changed to delegate to native ordering of t_const_value ---
[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...
Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 @jeking3 Yes, thanks, PR had some assumption on Map keys being only primitive for constant maps, which is not true in general. Latest revision should no longer rely on it. ---
