[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 THRIFT-4171 ---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 Please squash your changes to a single commit if possible. Thanks. ---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1515 Please don't change the code style while you are doing unrelated changes, it makes it very hard to review what *actually* changed. Even with the changes, there are lots of style inconsistencies like opening braces for functions are sometimes on the same line, sometimes on a new line. So please revert any style-only changes and follow the existing style. If you want to also change/improve code style, open a separate PR for that. Thank you. ---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 Fortunately these changes are confined to one file so reviewing it isn't too bad - hopefully they pass the new php formatting tests in the sca build. ---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 The new style changes and checks are pretty recent, based on work done by @RobberPhex. ---
