[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
GitHub user aloneguid opened a pull request: https://github.com/apache/thrift/pull/1355 Minimal C# library version for .NET Standard 1.4, 1.6, .NET 4.5.1 This adds another project type to C# library which allows it to be build for .NET Standard 1.4, 1.6 and .NET 4.5.1. The project turns off all dependencies (only the new project, existing ones are untouched) to build the core thrift library. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aloneguid/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1355 commit 6f46cdd2379eaf128108f5caad731ceb30e352d0 Author: Ivan Gavryliuk Date: 2017-09-12T14:52:41Z Create a minimal C# library version for .NET Standard 1.4, 1.6 and .NET 4.5.1 ---
[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1355#discussion_r138436653 --- Diff: lib/csharp/src/Thrift.sln --- @@ -1,6 +1,8 @@  -Microsoft Visual Studio Solution File, Format Version 11.00 -# Visual Studio 2010 +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio 15 --- End diff -- Note that sometime in the future we're going to remove all provided static solution files and rely solely on project creation that comes with cmake, at which point you'll pick what you want at cmake generation time. ---
[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
Github user aloneguid commented on a diff in the pull request: https://github.com/apache/thrift/pull/1355#discussion_r138439390 --- Diff: lib/csharp/src/Thrift.sln --- @@ -1,6 +1,8 @@  -Microsoft Visual Studio Solution File, Format Version 11.00 -# Visual Studio 2010 +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio 15 --- End diff -- is there any strong reason for this? ---
[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
Github user aloneguid closed the pull request at: https://github.com/apache/thrift/pull/1355 ---
