[GitHub] thrift pull request #1456: THRIFT-3983: Fix generated maven packaging

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1456


---

[GitHub] thrift pull request #1456: THRIFT-3983: Fix generated maven packaging

[RobberPhex]

GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1456

THRIFT-3983: Fix generated maven packaging

ref 

---
* The origin PR is , so this 
close #1430
* This PR depends on 
[THRIFT-4439](https://issues.apache.org/jira/browse/THRIFT-4439), to pass CI.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1456


commit 04a82de2e328d026563fa725fa1ffb3a850cf91f
Author: Robert Lu 
Date:   2017-12-28T20:14:38Z

use dartlang repo

commit e40c23539543ba353bc0368e7b3c5c25b1bf9846
Author: Stephane Landelle 
Date:   2017-11-30T23:08:56Z

Fix generated maven packaging

pom packaging is for empty modules. What you're deploying on maven central 
is a jar artifact. Your current invalid pom.xml causes build tools such as sbt 
to not be able to download your library!




---