[jira] [Closed] (THRIFT-1233) Remove unused include in generated C++ code

2011-07-28 Thread Jake Farrell (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1233.



> Remove unused include in generated C++ code
> ---
>
> Key: THRIFT-1233
> URL: https://issues.apache.org/jira/browse/THRIFT-1233
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Compiler
> Environment: Ubuntu 11.04, latest trunk.
>Reporter: Diwaker Gupta
>Assignee: alexandre parenteau
>Priority: Trivial
> Fix For: 0.7
>
> Attachments: THRIFT-1233.patch, thrift-1233.2.tgz
>
>
> When using cob_style with the CPP generator, the compiler adds an include for 
> TTransportUtils. This include doesn't seem to be used anywhere and creates an 
> unnecessary dependency. It also complicates compiling Thrift generated code 
> on other platforms.
> Patch available for review here:
> https://reviews.apache.org/r/1034/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Closed] (THRIFT-1233) Remove unused include in generated C++ code

2011-07-14 Thread Jake Farrell (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1233.


   Resolution: Fixed
Fix Version/s: 0.7
 Assignee: Diwaker Gupta  (was: Jake Farrell)

Committed, thanks for the patch.

> Remove unused include in generated C++ code
> ---
>
> Key: THRIFT-1233
> URL: https://issues.apache.org/jira/browse/THRIFT-1233
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Compiler
> Environment: Ubuntu 11.04, latest trunk.
>Reporter: Diwaker Gupta
>Assignee: Diwaker Gupta
>Priority: Trivial
> Fix For: 0.7
>
> Attachments: THRIFT-1233.patch
>
>
> When using cob_style with the CPP generator, the compiler adds an include for 
> TTransportUtils. This include doesn't seem to be used anywhere and creates an 
> unnecessary dependency. It also complicates compiling Thrift generated code 
> on other platforms.
> Patch available for review here:
> https://reviews.apache.org/r/1034/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira