[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385867#comment-14385867 ] Hudson commented on THRIFT-123: --- SUCCESS: Integrated in Thrift #1485 (See [https://builds.apache.org/job/Thrift/1485/]) THRIFT-123: TZlibTransport for Java (ra: rev 664dd0a0130546d59e7398e72c1af09c692e5a6f) * lib/java/src/org/apache/thrift/transport/TZlibTransport.java > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Assignee: Randy Abernethy >Priority: Minor > Fix For: 0.9.3 > > Attachments: 0001-added-TZlibTransport-for-Java.patch, > thrift_java_tzlibtransport_added.patch, > thrift_java_tzlibtransport_added_jzlib_v1.1.3.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385603#comment-14385603 ] Jake Farrell commented on THRIFT-123: - +1 with native java 1.7 functions, commit and close [~codesf] > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Assignee: Randy Abernethy >Priority: Minor > Attachments: 0001-added-TZlibTransport-for-Java.patch, > thrift_java_tzlibtransport_added.patch, > thrift_java_tzlibtransport_added_jzlib_v1.1.3.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923056#comment-13923056 ] Jake Farrell commented on THRIFT-123: - The goal is still to keep as many dependencies out of the core library as possible. Looking at the java.util.zip package it appears that it provides SYNC_FLUSH [1], not sure what other requirements are needed for this that make using the external lib necessary over the java.util.zip deflate|inflate classes. If using jzlib is still the preferred approach over using java.util.zip then we should make a separate jar named libthrift-transport-zlib and make it optional so the core lib can remain as dependent free as possible. [1]: http://docs.oracle.com/javase/7/docs/api/java/util/zip/Deflater.html#SYNC_FLUSH > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923052#comment-13923052 ] Roger Meier commented on THRIFT-123: Yes, please post your new patch here. > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923020#comment-13923020 ] Keith Chew commented on THRIFT-123: --- Just following up to see if this patch is still being considered to be added to the source? I have tested it with the latest jzlib library and it does not work. I have fixed the errors, and was wondering if this is the best place to post them? > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611021#comment-13611021 ] Roger Meier commented on THRIFT-123: I agree Jake. The other question here is, do the disadvantages with java.util.zip mentioned above still exist? I wouold prefer a solution based on java.util.zip and no additional dependency. > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611009#comment-13611009 ] Jake Farrell commented on THRIFT-123: - Thinking a little bit more on this I would suggest that we make this transport a separate jar (libthrift-transport-zlib) to help keep the base java library with less dependencies and also not require people who are not using the zlib transport to have the additional unnecessary dependency. Would be nice to get some test cases added to this as well. Roger, your thoughts on this? > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610980#comment-13610980 ] Jake Farrell commented on THRIFT-123: - In addition to the pom (currently generated from build.xml) the NOTICE and LICENSE files will have to be updated to reflect the use of this library as jzlib is BSD licensed. > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610413#comment-13610413 ] Roger Meier commented on THRIFT-123: This transport depends on http://www.jcraft.com/jzlib/ do you have a poatch with maven groupId and artifactId for jzlib? or a better alternative? -roger > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575548#comment-13575548 ] Mike Percy commented on THRIFT-123: --- Hi folks, this patch has languished here for a while. Is there anything wrong with it? Is anyone willing to review it? Regards, Mike > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > Attachments: thrift_java_tzlibtransport_added.patch > > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[
https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028446#comment-13028446
]
Dragan Okiljevic commented on THRIFT-123:
-
Short usage example for the submitted TZlibTransport class:
{code:title=Server.java|borderStyle=solid}
//server main
HelloTestHandler handler = new HelloTestHandler();
HelloTest.Processor processor = new HelloTest.Processor(handler);
TServerSocket tServerSocket = new TServerSocket(9090);
TTransportFactory tTransportFactory = new TZlibTransport.Factory();
TProtocolFactory tProtocolFactory = new TBinaryProtocol.Factory();
TServer server = new TThreadPoolServer(new
TThreadPoolServer.Args(tServerSocket).transportFactory(tTransportFactory).processor(processor).protocolFactory(tProtocolFactory));
System.out.println("Starting the server...");
server.serve();
{code}
{code:title=Client.java|borderStyle=solid}
//client main
TTransport wrappedTransport = new TSocket("localhost", 9090);
TTransport transport = new TZlibTransport(wrappedTransport);
TProtocol protocol = new TBinaryProtocol(transport);
HelloTest.Client client = new HelloTest.Client(protocol);
transport.open();
System.out.println("attemp to send hello string");
client.sendHello1Req();
System.out.println("hello string sent succesfully");
transport.close();
{code}
> implement TZlibTransport in Java
>
>
> Key: THRIFT-123
> URL: https://issues.apache.org/jira/browse/THRIFT-123
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
>Reporter: Pete Wyckoff
>Priority: Minor
> Attachments: thrift_java_tzlibtransport_added.patch
>
>
> TZlibTransport compatible with C++ version of TZlibTransport
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028426#comment-13028426 ] Dragan Okiljevic commented on THRIFT-123: - @Abhishek Kona One of the uses cases would be to reduce network traffic between peers (thrift clients and servers). This can be very useful if a network bandwidth is a bottleneck, of course it would increase a CPU usage on the other side, at least a bit. > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028423#comment-13028423 ] Dragan Okiljevic commented on THRIFT-123: - @Bryan Duxbury Java SDK offers support for zlib compression in java.util.zip package classes Deflater & Inflater and DeflaterOutputStream and InflaterInputStream. Unfortunately, these classes offer only limited support to C++ zlib library features (for example some flushing modes, such as ZSYNC_FLUSH are not supported). There are workarounds for some of these issues (for example: http://developer.java.sun.com/developer/bugParade/bugs/4255743.html) but it is generally very hard or maybe even impossible to emulate some of the features for usage such as compressing data stream between client and server. It seems that some additional features will be finally supported in Java 7, but there is also another solution: using JZlib - pure Java, full featuread and free zlib implementation (http://www.jcraft.com/jzlib/). I am currently working on a Java TZlibTransport implementation. I spent considerable time trying to implement it using only java.util.zip but eventualy switched to JZlib. I will publish the patch containing TZlibTransport implementation soon. > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-123) implement TZlibTransport in Java
[ https://issues.apache.org/jira/browse/THRIFT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022637#comment-13022637 ] Abhishek Kona commented on THRIFT-123: -- What are the use cases for using a compressed transport? > implement TZlibTransport in Java > > > Key: THRIFT-123 > URL: https://issues.apache.org/jira/browse/THRIFT-123 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Pete Wyckoff >Priority: Minor > > TZlibTransport compatible with C++ version of TZlibTransport -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
