[jira] [Commented] (THRIFT-1331) Ruby library deserializes an empty map to nil
[ https://issues.apache.org/jira/browse/THRIFT-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113468#comment-13113468 ] Jake Farrell commented on THRIFT-1331: -- THRIFT-1355 caused by the "should deserialize an empty map to an empty hash" test in compact_protocol_spec.rb added in this patch. This test case if failing and breaking the build. > Ruby library deserializes an empty map to nil > - > > Key: THRIFT-1331 > URL: https://issues.apache.org/jira/browse/THRIFT-1331 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Armaan Sarkar >Assignee: Armaan Sarkar > Fix For: 0.8 > > Attachments: THRIFT-1331_v1.patch, THRIFT-1331_v2.patch, > THRIFT-1331_v3.patch > > > The problem occurs when deserializing an empty map. Instead of deserializing > to an empty hash in Ruby, Thrift currently makes it a nil object. This poses > a variety of problems and is not the intended/original behavior. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1331) Ruby library deserializes an empty map to nil
[ https://issues.apache.org/jira/browse/THRIFT-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108940#comment-13108940 ] Hudson commented on THRIFT-1331: Integrated in Thrift #269 (See [https://builds.apache.org/job/Thrift/269/]) THRIFT-1331. rb: Ruby library deserializes an empty map to nil This patch properly detects when the metadata is omitted in Compact Protocol messages. Patch: Armaan Sarkar bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1173300 Files : * /thrift/trunk/lib/rb/ext/struct.c * /thrift/trunk/lib/rb/lib/thrift/struct_union.rb * /thrift/trunk/lib/rb/spec/compact_protocol_spec.rb * /thrift/trunk/test/DebugProtoTest.thrift > Ruby library deserializes an empty map to nil > - > > Key: THRIFT-1331 > URL: https://issues.apache.org/jira/browse/THRIFT-1331 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Armaan Sarkar >Assignee: Armaan Sarkar > Fix For: 0.8 > > Attachments: THRIFT-1331_v1.patch, THRIFT-1331_v2.patch, > THRIFT-1331_v3.patch > > > The problem occurs when deserializing an empty map. Instead of deserializing > to an empty hash in Ruby, Thrift currently makes it a nil object. This poses > a variety of problems and is not the intended/original behavior. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1331) Ruby library deserializes an empty map to nil
[ https://issues.apache.org/jira/browse/THRIFT-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099248#comment-13099248 ] Michael Stockton commented on THRIFT-1331: -- s/struct == struct2/struct.should == struct2/ This affects more than compact protocol so you may want to add tests to struct_spec and union_spec instead. > Ruby library deserializes an empty map to nil > - > > Key: THRIFT-1331 > URL: https://issues.apache.org/jira/browse/THRIFT-1331 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Armaan Sarkar >Assignee: Armaan Sarkar > Attachments: THRIFT-1331_v1.patch > > > The problem occurs when deserializing an empty map. Instead of deserializing > to an empty hash in Ruby, Thrift currently makes it a nil object. This poses > a variety of problems and is not the intended/original behavior. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
