[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113612#comment-13113612 ] Hudson commented on THRIFT-1355: Integrated in Thrift #276 (See [https://builds.apache.org/job/Thrift/276/]) Thrift-1355: Running make in lib/rb doesn't build the native extensions Client: rb Patch: jfarrell Builds extension prior to running spec calls to resolve test deps. > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.8 > > Attachments: thrift-1355.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113582#comment-13113582 ] Takashi Yonebayashi commented on THRIFT-1355: - Sweet, thanks. > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.8 > > Attachments: thrift-1355.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113565#comment-13113565 ] Takashi Yonebayashi commented on THRIFT-1355: - I think that's the issue then. If specs are run before the extension is built, that would cause this problem. The extension should be built before the specs are run. > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113465#comment-13113465 ] Jake Farrell commented on THRIFT-1355: -- The test case added in THRIFT-1331 for CompactProtocolFactory deserializing an empty map to an empty hash is failing. removing this test from compact_protocol_spec.rb allowed realspec call to correctly finish and then the extension and gem to be created. Tracking down issue and will have a patch shortly > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113085#comment-13113085 ] Takashi Yonebayashi commented on THRIFT-1355: - To clarify, this likely won't reproduce the failure unless you have a version of the native extensions installed from another location that fails the tests. You can reproduce the lack of compilation of the files in the ext directory. > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113084#comment-13113084 ] Takashi Yonebayashi commented on THRIFT-1355: - 1) Thrift::ProtocolException in 'Thrift::CompactProtocol should deserialize an empty map to an empty hash' Required field i32_map is unset! ./spec/../test/debug_proto/gen-rb/debug_proto_test_types.rb:385:in `validate' ./spec/../lib/thrift/serializer/deserializer.rb:29:in `read' ./spec/../lib/thrift/serializer/deserializer.rb:29:in `deserialize' ./spec/compact_protocol_spec.rb:125: Finished in 3.057992 seconds This isn't likely to help you since I only get this error because I have thrift installed elsewhere that fails this test. This means that the ext that was installed from that directory is still there after I run make. This makes sense since when I check the ext directory after running rake build_ext (or make, etc) there are no object files. Running make in the ext directory before running make in lib/rb fixes the tests. If you want to reproduce this, run make clean from lib/rb/ext then run make from lib/rb. If you check lib/rb/ext, the extensions will not have been compiled. > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113051#comment-13113051 ] Jake Farrell commented on THRIFT-1355: -- Can you attach the error that you are seeing when you run "rake build_ext" from the lib/rb folder > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113046#comment-13113046 ] Takashi Yonebayashi commented on THRIFT-1355: - This was against 1174393. This is the current head. The problem isn't with building the gem, it's with running 'ruby extconf.rb && make' from lib/rb/ext. > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Assignee: Jake Farrell >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113039#comment-13113039 ] Jake Farrell commented on THRIFT-1355: -- What version is this bug against? I committed a change earlier today which will generate the gem by default when building the rb library > Running make in lib/rb doesn't build the native extensions > -- > > Key: THRIFT-1355 > URL: https://issues.apache.org/jira/browse/THRIFT-1355 > Project: Thrift > Issue Type: Bug > Components: Ruby - Library >Reporter: Takashi Yonebayashi >Priority: Minor > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
