[jira] [Commented] (THRIFT-1544) Create correct Ruby namespace directories
[
https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273010#comment-13273010
]
Jake Farrell commented on THRIFT-1544:
--
tested on os x lion, got the following error with default system ruby 1.8.7.
thrift/trunk/lib/rb/spec/../test/debug_proto/gen-rb/srv.rb:8:in `require': no
such file to load -- /debug_proto_test_types (LoadError)
> Create correct Ruby namespace directories
> -
>
> Key: THRIFT-1544
> URL: https://issues.apache.org/jira/browse/THRIFT-1544
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Compiler
>Affects Versions: 0.8
>Reporter: Adam Stegman
>Assignee: Jake Farrell
>Priority: Minor
> Labels: compiler, namespaces, patch, ruby
> Fix For: 0.9
>
> Attachments: Namespace-generated-Ruby-files-correctly.patch
>
>
> Creating correct Ruby namespace directories, very similar to how Java creates
> package directories. e.g. {noformat}namespace java com.example.my_lib
> namespace rb com.example.my_lib{noformat} should both result in
> gen-{rb,java}/com/example/my_lib/my_lib_service.{rb,java}.
> Patch attached.
> See also [THRIFT-474|https://issues.apache.org/jira/browse/THRIFT-474] where
> a similar patch was included intermingled with a patch for a different issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1544) Create correct Ruby namespace directories
[
https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239558#comment-13239558
]
Adam Stegman commented on THRIFT-1544:
--
I was too hasty on the patch - it breaks require statements in the generated
files, since they expect a flat file structure, all on the load path. The
requires also need to be namespaced correctly.
> Create correct Ruby namespace directories
> -
>
> Key: THRIFT-1544
> URL: https://issues.apache.org/jira/browse/THRIFT-1544
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Compiler
>Affects Versions: 0.8
>Reporter: Adam Stegman
>Assignee: Jake Farrell
>Priority: Minor
> Labels: compiler, namespaces, patch, ruby
> Fix For: 0.9
>
> Attachments: Namespace-generated-Ruby-files-correctly.patch
>
>
> Creating correct Ruby namespace directories, very similar to how Java creates
> package directories. e.g. {noformat}namespace java com.example.my_lib
> namespace rb com.example.my_lib{noformat} should both result in
> gen-{rb,java}/com/example/my_lib/my_lib_service.{rb,java}.
> Patch attached.
> See also [THRIFT-474|https://issues.apache.org/jira/browse/THRIFT-474] where
> a similar patch was included intermingled with a patch for a different issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
