[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721224#comment-13721224 ] Jens Geyer commented on THRIFT-1708: If I don't overlook anything, events are fired when there is something to process. We found occasionally the need for at least one additional event, which would be fired when the server is really ready to process incoming requests, or immediately before. From my feeling this would be a good improvement to this concept. Does that make sense? Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610371#comment-13610371 ] Roger Meier commented on THRIFT-1708: - waiting for an answer and test, turorial modifications. Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609963#comment-13609963 ] George Cao commented on THRIFT-1708: Is this patch accepted or rejected? Any progress? Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[
https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539666#comment-13539666
]
Roger Meier commented on THRIFT-1708:
-
Andrew, this is a nice feature we should merge.
I have one question on the processor api, where you did this change:
{noformat}
- processor.process(inProtocol, outProtocol);
+ TProcessorContext context = new TProcessorContext(inProtocol,
outProtocol);
+ processor.process(context, inProtocol, outProtocol);
{noformat}
Why do we need to add protocol parameters to process function again?
I would prefer something like this:
{noformat}
- processor.process(inProtocol, outProtocol);
+ TProcessorContext context = new TProcessorContext(inProtocol,
outProtocol);
+ processor.process(context);
{noformat}
Or did I miss something here?
roger
;-r
Add event handlers for processor events
---
Key: THRIFT-1708
URL: https://issues.apache.org/jira/browse/THRIFT-1708
Project: Thrift
Issue Type: New Feature
Components: Java - Library
Affects Versions: 0.9
Environment: all
Reporter: Andrew Cox
Assignee: Andrew Cox
Priority: Minor
Fix For: 1.0
Attachments: thrift-1708-processor-event-handlers.patch
Integrates some code we've been using (here at facebook) to add event
handlers that can handle processor events with the server event handlers in
apache thrift.
Processor events include: preRead (before reading arguments), postRead (after
reading arguments), preWrite (before writing results), postWrite (after
writing results), and processorError (when a non-IDL exception is thrown as a
result of an error handling the request). The processor handler is given the
method name and input and output protocol that will be used to process the
request, and can inspect arguments on postRead, and results on pre/postWrite
events.
This change also enables event handlers for non-blocking servers.
Some unit tests are included to exercise the new processor event handlers,
and demonstrate how they can connect with server event handlers.
It also fixes a minor bug I found while testing, where FrameBuffers on
non-blocking servers could have been close()'d more than once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538481#comment-13538481 ] Diwaker Gupta commented on THRIFT-1708: --- [~bterm], can we break this up into 3 separate patches for C++, Java and Python? I'd love to see this for Java asap and we needn't be blocked on support in other languages right? Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538655#comment-13538655 ] Jake Farrell commented on THRIFT-1708: -- I'm good with splitting this into sub tickets for any remaining languages Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483536#comment-13483536 ] Andrew Cox commented on THRIFT-1708: Sorry to have disappeared for a bit, I was on vacation. I will start work on the C++ and python versions of the port as well. Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483772#comment-13483772 ] Jake Farrell commented on THRIFT-1708: -- Thanks Andrew, appreciated Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13476564#comment-13476564 ] Diwaker Gupta commented on THRIFT-1708: --- I'd love to see this in the next 0.9.x release! [~andrewcox79] consider splitting the patch in two: one that adds TServerEventHandler support to the non-blocking servers, and then add ProcessorEventHandler support in a subsequent patch. Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 1.0 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469869#comment-13469869 ] Jake Farrell commented on THRIFT-1708: -- Andrew, this is a really great addition. I am reviewing the patch now and really like what i've seen of it so far. Would love to see the addition of this for C++, Python and any other languages as well, can you please add your other patches to this ticket broken out per language. Thanks Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 0.9 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469100#comment-13469100 ] Andrew Cox commented on THRIFT-1708: We also have these in C++ and Python and I'd like to bring those in next, but will wait to see how this change is received (what people want changed before commit, etc), so I can save time getting to the same approach in C++ and Python. Add event handlers for processor events --- Key: THRIFT-1708 URL: https://issues.apache.org/jira/browse/THRIFT-1708 Project: Thrift Issue Type: New Feature Components: Java - Library Affects Versions: 0.9 Environment: all Reporter: Andrew Cox Assignee: Andrew Cox Priority: Minor Fix For: 0.9 Attachments: thrift-1708-processor-event-handlers.patch Integrates some code we've been using (here at facebook) to add event handlers that can handle processor events with the server event handlers in apache thrift. Processor events include: preRead (before reading arguments), postRead (after reading arguments), preWrite (before writing results), postWrite (after writing results), and processorError (when a non-IDL exception is thrown as a result of an error handling the request). The processor handler is given the method name and input and output protocol that will be used to process the request, and can inspect arguments on postRead, and results on pre/postWrite events. This change also enables event handlers for non-blocking servers. Some unit tests are included to exercise the new processor event handlers, and demonstrate how they can connect with server event handlers. It also fixes a minor bug I found while testing, where FrameBuffers on non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
