[jira] [Commented] (THRIFT-1761) Make generated exceptions have a common unique parent
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176737#comment-16176737 ] James E. King, III commented on THRIFT-1761: Any interest in reviving this, or can it be resolved? > Make generated exceptions have a common unique parent > - > > Key: THRIFT-1761 > URL: https://issues.apache.org/jira/browse/THRIFT-1761 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library, Java - Library, PHP - Library, Python - > Library >Reporter: Nathaniel Cook > Labels: exception-handling, exceptions > Attachments: thrift-1761_php_py_java_cpp_js.patch > > > It would be nice to be able to have exceptions that are thrown by services be > caught independently of other thrift exceptions. Currently generated > exceptions extend TException directly. They should extend a TServiceException > which in turn extends TException. This would allow client code to catch all > exceptions thrown by the service without catching exceptions related to the > actual thrift communication layer -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-1761) Make generated exceptions have a common unique parent
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877991#comment-13877991 ] Roger Meier commented on THRIFT-1761: - Yes, TServiceException is what we need as part of the Multiplexed Services feature. could you please rebase this? thanks ;-r Make generated exceptions have a common unique parent - Key: THRIFT-1761 URL: https://issues.apache.org/jira/browse/THRIFT-1761 Project: Thrift Issue Type: Improvement Components: C++ - Library, Java - Library, JavaME - Library, JavaScript - Library, PHP - Library, Python - Library Reporter: Nathaniel Cook Labels: exception-handling, exceptions Attachments: thrift-1761_php_py_java_cpp_js.patch It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (THRIFT-1761) Make generated exceptions have a common unique parent
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689388#comment-13689388 ] Jake Farrell commented on THRIFT-1761: -- Might be useful in the multiplexed services, but this seem to add an unnecessary abstraction. i would say not needed right now Make generated exceptions have a common unique parent - Key: THRIFT-1761 URL: https://issues.apache.org/jira/browse/THRIFT-1761 Project: Thrift Issue Type: Improvement Reporter: Nathaniel Cook Labels: exception-handling, exceptions Attachments: thrift-1761_php_py_java_cpp_js.patch It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1761) Make generated exceptions have a common unique parent
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506675#comment-13506675 ] Henrique Mendonca commented on THRIFT-1761: --- I see your point, it kind of increases the complexity of the things, specially when there is already some synchronisation problem between the different libs, but I'd be probably OK if it. However, I believe those classes should be in reality abstract classes. Anyway, I looking forward to hear someone else's opinion here too. Cheers, Henrique Make generated exceptions have a common unique parent - Key: THRIFT-1761 URL: https://issues.apache.org/jira/browse/THRIFT-1761 Project: Thrift Issue Type: Improvement Reporter: Nathaniel Cook Labels: exception-handling, exceptions Attachments: thrift-1761_php_py_java_cpp_js.patch It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
