[jira] [Commented] (THRIFT-1791) thrift's namespace directive when generating haskell code
[
https://issues.apache.org/jira/browse/THRIFT-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537683#comment-14537683
]
Tomasz Kupczyk commented on THRIFT-1791:
Hey, sure. Got some more time now, so maybe I'll look into this and reopen
soonish.
thrift's namespace directive when generating haskell code
-
Key: THRIFT-1791
URL: https://issues.apache.org/jira/browse/THRIFT-1791
Project: Thrift
Issue Type: Question
Components: Haskell - Compiler
Affects Versions: 0.9
Environment: linux/fedora17
Reporter: Tomasz Kupczyk
Priority: Minor
Fix For: 0.9.1
Hello, I was wondering what effect has the namespace directive, or what
effect should it have, when generating haskell code, let's assume I have a
product.thrift file:
namespace hs A.B.C
struct Product {
1: i32 cost
}
Should this generate a haskell file that creates a module like this:
module Product where
[...]
or like this:
module A.B.C.Product where
[...]
For me it picks the first version.
Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-1791) thrift's namespace directive when generating haskell code
[
https://issues.apache.org/jira/browse/THRIFT-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581661#comment-13581661
]
Tomasz Kupczyk commented on THRIFT-1791:
Hmmm, seems I late. So has it been already fixed?
thrift's namespace directive when generating haskell code
-
Key: THRIFT-1791
URL: https://issues.apache.org/jira/browse/THRIFT-1791
Project: Thrift
Issue Type: Question
Components: Haskell - Compiler
Affects Versions: 0.9
Environment: linux/fedora17
Reporter: Tomasz Kupczyk
Priority: Minor
Fix For: 1.0
Hello, I was wondering what effect has the namespace directive, or what
effect should it have, when generating haskell code, let's assume I have a
product.thrift file:
namespace hs A.B.C
struct Product {
1: i32 cost
}
Should this generate a haskell file that creates a module like this:
module Product where
[...]
or like this:
module A.B.C.Product where
[...]
For me it picks the first version.
Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1791) thrift's namespace directive when generating haskell code
[
https://issues.apache.org/jira/browse/THRIFT-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581664#comment-13581664
]
Tomasz Kupczyk commented on THRIFT-1791:
That ought to be 'seems I'm late' :) Thanks for the fix.
thrift's namespace directive when generating haskell code
-
Key: THRIFT-1791
URL: https://issues.apache.org/jira/browse/THRIFT-1791
Project: Thrift
Issue Type: Question
Components: Haskell - Compiler
Affects Versions: 0.9
Environment: linux/fedora17
Reporter: Tomasz Kupczyk
Priority: Minor
Fix For: 1.0
Hello, I was wondering what effect has the namespace directive, or what
effect should it have, when generating haskell code, let's assume I have a
product.thrift file:
namespace hs A.B.C
struct Product {
1: i32 cost
}
Should this generate a haskell file that creates a module like this:
module Product where
[...]
or like this:
module A.B.C.Product where
[...]
For me it picks the first version.
Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1791) thrift's namespace directive when generating haskell code
[
https://issues.apache.org/jira/browse/THRIFT-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581764#comment-13581764
]
Jake Farrell commented on THRIFT-1791:
--
I closed the issue due to it being labeled a question. The haskell generator as
of 0.9 and the dev snapshot does not currently use the namespace directive, a
patch for this would be great or please feel free to create a new ticket for
someone to take a look at adding it
thrift's namespace directive when generating haskell code
-
Key: THRIFT-1791
URL: https://issues.apache.org/jira/browse/THRIFT-1791
Project: Thrift
Issue Type: Question
Components: Haskell - Compiler
Affects Versions: 0.9
Environment: linux/fedora17
Reporter: Tomasz Kupczyk
Priority: Minor
Fix For: 1.0
Hello, I was wondering what effect has the namespace directive, or what
effect should it have, when generating haskell code, let's assume I have a
product.thrift file:
namespace hs A.B.C
struct Product {
1: i32 cost
}
Should this generate a haskell file that creates a module like this:
module Product where
[...]
or like this:
module A.B.C.Product where
[...]
For me it picks the first version.
Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1791) thrift's namespace directive when generating haskell code
[
https://issues.apache.org/jira/browse/THRIFT-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551336#comment-13551336
]
Gabriel Prioli commented on THRIFT-1791:
It looks like it's not being used at all. A specified namespace on the thrift
file doesn't appear anywhere on the generated code.
From what I can see the hs generator file just sets the module based on the
program name. On /compiler/cpp/src/generate/t_hs_generator.cc:
192: string pname = capitalize(program_name_);
...
202: f_types_ module pname _Types where endl;
thrift's namespace directive when generating haskell code
-
Key: THRIFT-1791
URL: https://issues.apache.org/jira/browse/THRIFT-1791
Project: Thrift
Issue Type: Question
Components: Haskell - Compiler
Affects Versions: 0.9
Environment: linux/fedora17
Reporter: Tomasz Kupczyk
Priority: Minor
Hello, I was wondering what effect has the namespace directive, or what
effect should it have, when generating haskell code, let's assume I have a
product.thrift file:
namespace hs A.B.C
struct Product {
1: i32 cost
}
Should this generate a haskell file that creates a module like this:
module Product where
[...]
or like this:
module A.B.C.Product where
[...]
For me it picks the first version.
Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
