[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087783#comment-16087783 ] Davin Chia commented on THRIFT-2063: Bumping this. I know this is an old issue, but I am currently running into this problem while introducing go into our code base. I am compiling using thrift 0.10.0. Is there an update on this? Has there been a consensus to write thrift definitions without complex keys to avoid this problem and are there current work arounds? Or Is this still an open issue with solutions open to discussion? > Go compiler cannot create code for maps with complex/binary keys > > > Key: THRIFT-2063 > URL: https://issues.apache.org/jira/browse/THRIFT-2063 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Reporter: Remo Hertig > > trying to generate code for ThriftTest leads to: > {code} > ../../compiler/cpp/thrift --gen go ../ThriftTest.thrift > [WARNING:/tbHD/Home/nairboon/dev/thrift/test/ThriftTest.thrift:41] No > generator named 'noexist' could be found! > [WARNING:/tbHD/Home/nairboon/dev/thrift/test/ThriftTest.thrift:42] cpp > generator does not accept 'noexist' as sub-namespace! > Error: Cannot produce a valid type for a Go map key: map[int32]bool - > aborting.{code} > the affected struct seems to be #3: > {code} > struct CrazyNesting { > 1: string string_field, > 2: optional set set_field, > 3: required list< map,map> > list_field, > 4: binary binary_field > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090566#comment-16090566 ] Jens Geyer commented on THRIFT-2063: You can bump this in 5-Minutes intervals, but that will only fill the mailing list and disappoint people. This is Open Source, which by definition lives by *contributions, not decibels*. > Go compiler cannot create code for maps with complex/binary keys > > > Key: THRIFT-2063 > URL: https://issues.apache.org/jira/browse/THRIFT-2063 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Reporter: Remo Hertig > > trying to generate code for ThriftTest leads to: > {code} > ../../compiler/cpp/thrift --gen go ../ThriftTest.thrift > [WARNING:/tbHD/Home/nairboon/dev/thrift/test/ThriftTest.thrift:41] No > generator named 'noexist' could be found! > [WARNING:/tbHD/Home/nairboon/dev/thrift/test/ThriftTest.thrift:42] cpp > generator does not accept 'noexist' as sub-namespace! > Error: Cannot produce a valid type for a Go map key: map[int32]bool - > aborting.{code} > the affected struct seems to be #3: > {code} > struct CrazyNesting { > 1: string string_field, > 2: optional set set_field, > 3: required list< map,map> > list_field, > 4: binary binary_field > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090880#comment-16090880 ] Davin Chia commented on THRIFT-2063: Ah sorry for the noise. I am definitely going to fix this. My intention on opening discussion was to arrive at a community accepted solution. This is because I am not a Go expert and so am not sure about the best solution. The current monkey patch I am using is to convert all complex keys into strings, which is definitely only temporary. I will get to this after tackling *https://issues.apache.org/jira/browse/THRIFT-4253*. > Go compiler cannot create code for maps with complex/binary keys > > > Key: THRIFT-2063 > URL: https://issues.apache.org/jira/browse/THRIFT-2063 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Reporter: Remo Hertig > > trying to generate code for ThriftTest leads to: > {code} > ../../compiler/cpp/thrift --gen go ../ThriftTest.thrift > [WARNING:/tbHD/Home/nairboon/dev/thrift/test/ThriftTest.thrift:41] No > generator named 'noexist' could be found! > [WARNING:/tbHD/Home/nairboon/dev/thrift/test/ThriftTest.thrift:42] cpp > generator does not accept 'noexist' as sub-namespace! > Error: Cannot produce a valid type for a Go map key: map[int32]bool - > aborting.{code} > the affected struct seems to be #3: > {code} > struct CrazyNesting { > 1: string string_field, > 2: optional set set_field, > 3: required list< map,map> > list_field, > 4: binary binary_field > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)