[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156609#comment-16156609 ] Walter Weinmann commented on THRIFT-2289: - This seems to be resolved and should be closed. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157408#comment-16157408 ] James E. King, III commented on THRIFT-2289: [~weinmann] To resolve this I would recommend adding json protocol support to the cross test. If you look in ``test/tests.json`` you will see that the "erl" test block does not advertise protocols "json". I assume that if json is working properly, that could be added and therefore verified? > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158274#comment-16158274 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann opened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158290#comment-16158290 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 This closes #1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158356#comment-16158356 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Unfortunately the first step in Travis breaks always with: `The job exceeded the maximum time limit for jobs, and has been terminated.` > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160165#comment-16160165 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160167#comment-16160167 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160166#comment-16160166 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160253#comment-16160253 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160255#comment-16160255 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160252#comment-16160252 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160282#comment-16160282 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 The checks are really hopeless: Travis fails with maximum time limit and AppVeyor fails with some Haskell problems. **Sorry I don't know what to do.** > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160648#comment-16160648 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160646#comment-16160646 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160647#comment-16160647 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160678#comment-16160678 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160679#comment-16160679 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160680#comment-16160680 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160765#comment-16160765 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160766#comment-16160766 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160767#comment-16160767 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[
https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161039#comment-16161039
]
Jens Geyer commented on THRIFT-2289:
{quote}
The checks are really hopeless: Travis fails with maximum time limit and
AppVeyor fails with some Haskell problems.
*Sorry I don't know what to do.*
{quote}
This may sound strange, but the first thing that came to my mind is: Why does
it take so long at all? Can we make it faster?
Additionally, a quick search revealed this:
https://docs.travis-ci.com/user/common-build-problems/#My-builds-are-timing-out
Is that helpful?
> Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for
> bools
> ---
>
> Key: THRIFT-2289
> URL: https://issues.apache.org/jira/browse/THRIFT-2289
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Affects Versions: 0.9.1
>Reporter: Jens Geyer
>
> Some implementations of Thrift JSON protocol wrongly write and expect
> true/false for bools, instead of 0/1
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162466#comment-16162466 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162465#comment-16162465 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162467#comment-16162467 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162525#comment-16162525 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162528#comment-16162528 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162526#comment-16162526 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162556#comment-16162556 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162555#comment-16162555 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162557#comment-16162557 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162622#comment-16162622 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162621#comment-16162621 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162620#comment-16162620 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162979#comment-16162979 ] ASF GitHub Bot commented on THRIFT-2289: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 Working on it here: #1351 so you can track it. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162991#comment-16162991 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163143#comment-16163143 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Problem step 1: ==  Problem step 4: ==  Problem step 11: ===  > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163186#comment-16163186 ] ASF GitHub Bot commented on THRIFT-2289: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 As I said, working on it here: #1351 so you can track it. I have item 1 fixed; the others are a haxe issue I didn't see when I did the original docker image refresh and I am looking at it. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165334#comment-16165334 ] ASF GitHub Bot commented on THRIFT-2289: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 If you rebase on master it will help, but I can't guarantee it will make everything clean - will be better. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165705#comment-16165705 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165711#comment-16165711 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann opened a pull request: https://github.com/apache/thrift/pull/1356 THRIFT-2289 Erlang impl of Thrift JSON protocol wrongly writes/expect… …s true/false for bools. You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1356 commit 6e83a3d886d9b98874b592fba42d5203a101291e Author: walter-weinmann Date: 2017-09-14T04:16:30Z THRIFT-2289 Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165713#comment-16165713 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1356 This closes #1356. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165841#comment-16165841 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1356 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166100#comment-16166100 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann opened a pull request: https://github.com/apache/thrift/pull/1357 THRIFT-2289 Erlang impl of Thrift JSON protocol wrongly writes/expect… …s true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1357.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1357 commit a0ba45c528cf72db373ec67a930c9d697b1d7e72 Author: walter-weinmann Date: 2017-09-14T11:21:09Z THRIFT-2289 Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166101#comment-16166101 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1357 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
