[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082997#comment-16082997
 ] 

Jens Geyer commented on THRIFT-4197:


> Reopening to put it in "Resolved" state for release note generation.

???


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
> Fix For: 0.11.0
>
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009347#comment-16009347
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Yes I did, works just fine.


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
> Fix For: 0.11.0
>
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009345#comment-16009345
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user mrwiggles commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Seems very straightforward. Were you able to test it out?


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
> Fix For: 0.11.0
>
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008586#comment-16008586
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1266
  
>  I have a life besides Thrift, you know ;-)

As do we all :)

> Don't panic

No panic here, or in the code! :)


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008577#comment-16008577
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Don't panic, I already planned to look into this. I have a life 
besidesThrift, you know ;-)


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007931#comment-16007931
 ] 

ASF GitHub Bot commented on THRIFT-4197:


GitHub user dcelasun reopened a pull request:

https://github.com/apache/thrift/pull/1266

THRIFT-4197 [Go] Transparent gzip support for HTTP transport

Check if the client supports gzip compressed responses and compress the 
response if it does.

@Jens-G thoughts?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dcelasun/thrift go-gzip-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1266


commit b434d2d59b98f457600d0928e519b400462dee4a
Author: D. Can Celasun 
Date:   2017-05-11T10:04:01Z

[Go] Transparent gzip support for HTTP transport

Check if the client supports gzip compressed responses and compress
the response if it does.




> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007930#comment-16007930
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user dcelasun closed the pull request at:

https://github.com/apache/thrift/pull/1266


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006548#comment-16006548
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Travis failure is unrelated, seems like a Haskell problem:

```
Build log ( /root/.cabal/logs/HUnit-1.6.0.0.log ):
cabal: /root/.cabal/logs/HUnit-1.6.0.0.log: does not exist
lib/hs/CMakeFiles/haskell_library.dir/build.make:88: recipe for target 
'lib/hs/thrift_cabal.stamp' failed
make[2]: *** [lib/hs/thrift_cabal.stamp] Error 1
CMakeFiles/Makefile2:3926: recipe for target 
'lib/hs/CMakeFiles/haskell_library.dir/all' failed
make[1]: *** [lib/hs/CMakeFiles/haskell_library.dir/all] Error 2
```


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)