[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174927#comment-16174927
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1272


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 0.11.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154772#comment-16154772
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1272
  
Please rebase against master and force push to get a new build going.


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050800#comment-16050800
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1272
  
Please rebase against master and force push to get a new build going.


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050384#comment-16050384
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1272
  
It seems that the THRIFT-4202 is resolved can we merge this.


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024714#comment-16024714
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1272
  
Good. Wait for a fix. And I will open a new issue, since we detected that 
thrift crashes when certificate verification not ok.


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024670#comment-16024670
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1272
  
@gadLinux looks like https://issues.apache.org/jira/browse/THRIFT-4202


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023053#comment-16023053
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1272
  
Can someone tell why travis fails?


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021321#comment-16021321
 ] 

ASF GitHub Bot commented on THRIFT-4205:


GitHub user gadLinux opened a pull request:

https://github.com/apache/thrift/pull/1272

THRIFT-4205: Set flags for glib+gobject on compilation

Set flags for glib+gobject on compilation so systems like Android doesn't 
blow up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gadLinux/thrift THRIFT-4205

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1272


commit 94968a7db10d4b95bec62d33bed66868eebfbc38
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-23T15:22:44Z

THRIFT-4205: Make sure gobject+glib are correctly linked

commit fb518bebec7666953fc69a540db9a56973b9bab5
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-23T15:24:54Z

Fix lib for glib




> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)