[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174935#comment-16174935
 ] 

ASF GitHub Bot commented on THRIFT-4211:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1278


> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 0.11.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154770#comment-16154770
 ] 

ASF GitHub Bot commented on THRIFT-4211:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1278
  
Please rebase on master and push to get a new Travis CI build, now that it 
has been cleaned up.


> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122773#comment-16122773
 ] 

ASF GitHub Bot commented on THRIFT-4211:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1278
  
Would you be able to rebase against master and push so there is one commit 
(just like there is now), but more importantly it will kick off a new CI build 
for us.  Thanks.


> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024848#comment-16024848
 ] 

ASF GitHub Bot commented on THRIFT-4211:


GitHub user gadLinux opened a pull request:

https://github.com/apache/thrift/pull/1278

THRIFT-4211: Fix logging in thrift library

It seems we were aborting on error. 

We are now doing properly management. Error is ok and working perfectly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gadLinux/thrift THRIFT-4211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1278


commit a813c237fad8997ef96806259b999c5431759caa
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:11:38Z

Fix logging in thrift library in #THRIFT-4211




> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

[Gonzalo Aguilar (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024847#comment-16024847
 ] 

Gonzalo Aguilar commented on THRIFT-4211:
-

It seems we were aborting due to wrong understanding of how g_error works. 

There's room for improvement but for now it seems correct

> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)