[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067241#comment-16067241
]
Mario Emmenlauer commented on THRIFT-4239:
--
The exact error message is pointing to the @Override of
handleRuntimeExceptions():
{code}
[...]/APIAccess.java:398: error: method does not override or implement a method
from a supertype
@Override
^
{code}
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068976#comment-16068976
]
Jens Geyer commented on THRIFT-4239:
Could this be fixed by THRIFT-1805 in master?
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068997#comment-16068997
]
Mario Emmenlauer commented on THRIFT-4239:
--
I also found THRIFT-1805, but admittedly I don't fully understand how this
affects my problem.
I did some regression testing and could find that thrift 3db41fa (from
2017-04-07) does not
show the problem, whereas 2b1b32c (from 2017-05-30) is affected. I could not
narrow it down
further yet.
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071298#comment-16071298
]
Jens Geyer commented on THRIFT-4239:
The only change relevant to the Java compiler in that range is THRIFT-4177 ...
but that doesn't look like it either. At least to me ...
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071377#comment-16071377
]
Mario Emmenlauer commented on THRIFT-4239:
--
Thanks a lot [~jensg]. Does it help if I share my code? I'm using just a minor
rewrite of the simple java Thrift example. If I'm not completely mistaken, I
get one {noformat}@Override protected boolean handleRuntimeExceptions() { }
{noformat} for every function that can throw an exception, is that reasonable?
Is this issue really specific to me, or can someone reproduce the problem?
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072797#comment-16072797
]
Christopher Tubbs commented on THRIFT-4239:
---
What JDK are you using? And, are you sure the older thrift jar isn't on the
classpath?
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072798#comment-16072798
]
Christopher Tubbs commented on THRIFT-4239:
---
Oh, nm, I see you specified in the ticket (Oracle JDK 1.8 on Ubuntu 16.04). I
could try to reproduce if you share your code, [~emmenlau].
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072815#comment-16072815
]
Mario Emmenlauer commented on THRIFT-4239:
--
Great! Can you send me your mail address to emmenla...@gmx.de ? I have prepared
something like a minimal test case including gradle build script.
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072818#comment-16072818
]
Christopher Tubbs commented on THRIFT-4239:
---
You can send stuff to my apache.org address, ctubbsii
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072833#comment-16072833
]
Mario Emmenlauer commented on THRIFT-4239:
--
Ok, mail is sent. Let me know if you did *not* get the email. Thanks for your
help!
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075562#comment-16075562
]
Christopher Tubbs commented on THRIFT-4239:
---
Sorry, I did not get the email.
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079714#comment-16079714
]
Mario Emmenlauer commented on THRIFT-4239:
--
Then it would be helpful if you also add a better hint to what your apache.org
email address could be :-) :-)
I guessed ctubbsii at apache.org, is that wrong?
Or just use this link: http://data.marssoft.de/THRIFT-4239.tar.gz
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081004#comment-16081004
]
Christopher Tubbs commented on THRIFT-4239:
---
No, that's not wrong. That's definitely my email address. I will look at your
tarball.
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081041#comment-16081041
]
Christopher Tubbs commented on THRIFT-4239:
---
[~emmenlau], a quick look at your build.gradle file looks like you're still
linking to libthrift 0.10.0, which does not have the new method being
overridden with the Override annotation. You have to use the newer version of
libthrift which corresponds to your thrift code generator version.
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions
[
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089776#comment-16089776
]
Mario Emmenlauer commented on THRIFT-4239:
--
Dear [~ctubbsii], thanks a lot!!! You are right, this is the issue! Dammit,
that was not too easy to find for me, thanks a lot for your help.
> Latest thrift breaks java build with handleRuntimeExceptions
>
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an
> error that handleRuntimeExceptions does not Override. It seems related to
> these new additions in the generated Java code:
> {code}
> - @Override
> - protected boolean handleRuntimeExceptions() {
> -return false;
> - }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not
> present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
