[jira] [Commented] (THRIFT-4342) Support ruby rspec 3

2018-03-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410716#comment-16410716
 ] 

ASF GitHub Bot commented on THRIFT-4342:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1518
  
Closing, will re-open once the dist jobs are working.


> Support ruby rspec 3
> 
>
> Key: THRIFT-4342
> URL: https://issues.apache.org/jira/browse/THRIFT-4342
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial (ruby 2.3.1)
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I don't know much about ruby.  Anybody who can assist is welcome to do so!  I 
> tried to update us to rspec 2.99.x to prepare for rspec 3 and got a lot of 
> errors.  We should be running the latest versions of test tools in 
> thrift.gemspec.  Also note the apache license in the gemspec is not quite 
> right...
> {noformat}
> Pending:
>   Client Thrift::Client should increment the sequence id when sending messages
> # it seems sequence ids are completely ignored right now
> # ./spec/client_spec.rb:55
> Failures:
>   1) BinaryProtocolAccelerated it should behave like a binary protocol should 
> write a byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_accelerated_spec.rb:28
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
>   2) BinaryProtocol it should behave like a binary protocol should write a 
> byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_spec.rb:25
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
> Deprecation Warnings:
> 
> The semantics of `RSpec::Core::Pending#pending` are changing in
> RSpec 3.  In RSpec 2.x, it caused the example to be skipped. In
> RSpec 3, the rest of the example will still be run but is expected
> to fail, and will be marked as a failure (rather than as pending)
> if the example passes.
> Any passed block will no longer be executed. This feature is being
> removed since it was semantically inconsistent, and the behaviour it
> offered is being made available with the other ways of marking an
> example pending.
> To keep the same skip semantics, change `pending` to `skip`.
> Otherwise, if you want the new RSpec 3 behavior, you can safely
> ignore this warning and continue to upgrade to RSpec 3 without
> addressing it.
> Called from /thrift/src/lib/rb/spec/client_spec.rb:56:in `block (3 levels) in 
> '.
> 
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/client_spec.rb:79:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:38:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:41:in `block (5 levels) in  (required)>'.
> Too many uses of deprecated '`and_return { value }`'. Pass 
> `--deprecation-out` or set `config.deprecation_stream` to a file for full 
> output.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:279:in `block (3 levels) in 
> '.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:63:in `block (3 levels) in  (required)>'.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:83:in `block (3 levels) in  (required)>'.
> Too many uses of deprecated '`be_false`'. Pass `--deprecation-out` or set 
> `config.deprecation_stream` to a file for full output.
> `be_true` is deprecated. Use `be_truthy` (for Ruby's conditional semantics) 
> or `be true` (for exact `== true` equality) instead. Calle

[jira] [Commented] (THRIFT-4342) Support ruby rspec 3

2018-03-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410717#comment-16410717
 ] 

ASF GitHub Bot commented on THRIFT-4342:


Github user jeking3 closed the pull request at:

https://github.com/apache/thrift/pull/1518


> Support ruby rspec 3
> 
>
> Key: THRIFT-4342
> URL: https://issues.apache.org/jira/browse/THRIFT-4342
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial (ruby 2.3.1)
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I don't know much about ruby.  Anybody who can assist is welcome to do so!  I 
> tried to update us to rspec 2.99.x to prepare for rspec 3 and got a lot of 
> errors.  We should be running the latest versions of test tools in 
> thrift.gemspec.  Also note the apache license in the gemspec is not quite 
> right...
> {noformat}
> Pending:
>   Client Thrift::Client should increment the sequence id when sending messages
> # it seems sequence ids are completely ignored right now
> # ./spec/client_spec.rb:55
> Failures:
>   1) BinaryProtocolAccelerated it should behave like a binary protocol should 
> write a byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_accelerated_spec.rb:28
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
>   2) BinaryProtocol it should behave like a binary protocol should write a 
> byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_spec.rb:25
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
> Deprecation Warnings:
> 
> The semantics of `RSpec::Core::Pending#pending` are changing in
> RSpec 3.  In RSpec 2.x, it caused the example to be skipped. In
> RSpec 3, the rest of the example will still be run but is expected
> to fail, and will be marked as a failure (rather than as pending)
> if the example passes.
> Any passed block will no longer be executed. This feature is being
> removed since it was semantically inconsistent, and the behaviour it
> offered is being made available with the other ways of marking an
> example pending.
> To keep the same skip semantics, change `pending` to `skip`.
> Otherwise, if you want the new RSpec 3 behavior, you can safely
> ignore this warning and continue to upgrade to RSpec 3 without
> addressing it.
> Called from /thrift/src/lib/rb/spec/client_spec.rb:56:in `block (3 levels) in 
> '.
> 
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/client_spec.rb:79:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:38:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:41:in `block (5 levels) in  (required)>'.
> Too many uses of deprecated '`and_return { value }`'. Pass 
> `--deprecation-out` or set `config.deprecation_stream` to a file for full 
> output.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:279:in `block (3 levels) in 
> '.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:63:in `block (3 levels) in  (required)>'.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:83:in `block (3 levels) in  (required)>'.
> Too many uses of deprecated '`be_false`'. Pass `--deprecation-out` or set 
> `config.deprecation_stream` to a file for full output.
> `be_true` is deprecated. Use `be_truthy` (for Ruby's conditional semantics) 
> or `be true` (for exact `== true` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:

[jira] [Commented] (THRIFT-4342) Support ruby rspec 3

2018-03-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410639#comment-16410639
 ] 

ASF GitHub Bot commented on THRIFT-4342:


GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1518

THRIFT-4342: update ruby tests to use rspec 3, updated all dependencies for 
ruby



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4342

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1518


commit 0856cfcd00f611522a2c869b754472795490
Author: James E. King III 
Date:   2018-03-23T00:50:23Z

THRIFT-4342: update ruby tests to use rspec 3, updated all dependencies for 
ruby




> Support ruby rspec 3
> 
>
> Key: THRIFT-4342
> URL: https://issues.apache.org/jira/browse/THRIFT-4342
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial (ruby 2.3.1)
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I don't know much about ruby.  Anybody who can assist is welcome to do so!  I 
> tried to update us to rspec 2.99.x to prepare for rspec 3 and got a lot of 
> errors.  We should be running the latest versions of test tools in 
> thrift.gemspec.  Also note the apache license in the gemspec is not quite 
> right...
> {noformat}
> Pending:
>   Client Thrift::Client should increment the sequence id when sending messages
> # it seems sequence ids are completely ignored right now
> # ./spec/client_spec.rb:55
> Failures:
>   1) BinaryProtocolAccelerated it should behave like a binary protocol should 
> write a byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_accelerated_spec.rb:28
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
>   2) BinaryProtocol it should behave like a binary protocol should write a 
> byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_spec.rb:25
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
> Deprecation Warnings:
> 
> The semantics of `RSpec::Core::Pending#pending` are changing in
> RSpec 3.  In RSpec 2.x, it caused the example to be skipped. In
> RSpec 3, the rest of the example will still be run but is expected
> to fail, and will be marked as a failure (rather than as pending)
> if the example passes.
> Any passed block will no longer be executed. This feature is being
> removed since it was semantically inconsistent, and the behaviour it
> offered is being made available with the other ways of marking an
> example pending.
> To keep the same skip semantics, change `pending` to `skip`.
> Otherwise, if you want the new RSpec 3 behavior, you can safely
> ignore this warning and continue to upgrade to RSpec 3 without
> addressing it.
> Called from /thrift/src/lib/rb/spec/client_spec.rb:56:in `block (3 levels) in 
> '.
> 
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/client_spec.rb:79:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:38:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:41:in `block (5 levels) in  (required)>'.
> Too many uses of deprecated '`and_return { value }`'. Pass 
> `--deprecation-out` or set `config.deprecation_stream` to a file for full 
> output.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:279:in `block (3 levels) in 
> '.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for

[jira] [Commented] (THRIFT-4342) Support ruby rspec 3

2017-10-07 Thread James E. King, III (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195751#comment-16195751
 ] 

James E. King, III commented on THRIFT-4342:


I just tried this and it built with only four errors, so this will make it much 
easier to get up so rspec 3.6:

https://github.com/yujinakayama/transpec


> Support ruby rspec 3
> 
>
> Key: THRIFT-4342
> URL: https://issues.apache.org/jira/browse/THRIFT-4342
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial (ruby 2.3.1)
>Reporter: James E. King, III
>
> I don't know much about ruby.  Anybody who can assist is welcome to do so!  I 
> tried to update us to rspec 2.99.x to prepare for rspec 3 and got a lot of 
> errors.  We should be running the latest versions of test tools in 
> thrift.gemspec.  Also note the apache license in the gemspec is not quite 
> right...
> {noformat}
> Pending:
>   Client Thrift::Client should increment the sequence id when sending messages
> # it seems sequence ids are completely ignored right now
> # ./spec/client_spec.rb:55
> Failures:
>   1) BinaryProtocolAccelerated it should behave like a binary protocol should 
> write a byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_accelerated_spec.rb:28
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
>   2) BinaryProtocol it should behave like a binary protocol should write a 
> byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_spec.rb:25
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
> Deprecation Warnings:
> 
> The semantics of `RSpec::Core::Pending#pending` are changing in
> RSpec 3.  In RSpec 2.x, it caused the example to be skipped. In
> RSpec 3, the rest of the example will still be run but is expected
> to fail, and will be marked as a failure (rather than as pending)
> if the example passes.
> Any passed block will no longer be executed. This feature is being
> removed since it was semantically inconsistent, and the behaviour it
> offered is being made available with the other ways of marking an
> example pending.
> To keep the same skip semantics, change `pending` to `skip`.
> Otherwise, if you want the new RSpec 3 behavior, you can safely
> ignore this warning and continue to upgrade to RSpec 3 without
> addressing it.
> Called from /thrift/src/lib/rb/spec/client_spec.rb:56:in `block (3 levels) in 
> '.
> 
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/client_spec.rb:79:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:38:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:41:in `block (5 levels) in  (required)>'.
> Too many uses of deprecated '`and_return { value }`'. Pass 
> `--deprecation-out` or set `config.deprecation_stream` to a file for full 
> output.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:279:in `block (3 levels) in 
> '.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:63:in `block (3 levels) in  (required)>'.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:83:in `block (3 levels) in  (required)>'.
> Too many uses of deprecated '`be_false`'. Pass `--deprecation-out` or set 
> `config.deprecation_stream` to a file for full output.
> `be_true` is deprecated. Use `be_truthy` (for Ruby's conditional semantics) 
> or `be true` (for exact `== true` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:44:in