[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib
[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411684#comment-16411684 ] ASF GitHub Bot commented on THRIFT-4527: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1516 > Upgrade byteorder version in Rust lib > - > > Key: THRIFT-4527 > URL: https://issues.apache.org/jira/browse/THRIFT-4527 > Project: Thrift > Issue Type: Dependency upgrade > Components: Rust - Library >Affects Versions: 0.11.0 >Reporter: Joshua >Priority: Major > > The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to > prevent dependency conflicts in a project I was working on, works fine and > would be useful for other users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib
[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411277#comment-16411277 ] ASF GitHub Bot commented on THRIFT-4527: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1516 OK. Looks like the build failures are unrelated. I'm going to apply locally and check cross-tests just to make sure, but will get this applied today. Thank you @QuestofIranon! Always happy to see people improving Thrift :) > Upgrade byteorder version in Rust lib > - > > Key: THRIFT-4527 > URL: https://issues.apache.org/jira/browse/THRIFT-4527 > Project: Thrift > Issue Type: Dependency upgrade > Components: Rust - Library >Affects Versions: 0.11.0 >Reporter: Joshua >Priority: Major > > The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to > prevent dependency conflicts in a project I was working on, works fine and > would be useful for other users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib
[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410822#comment-16410822 ] ASF GitHub Bot commented on THRIFT-4527: Github user QuestofIranon commented on the issue: https://github.com/apache/thrift/pull/1516 @allengeorge It creates dependency conflicts with other libraries that rely on the updated version of byteorder. For example, I couldn't build a project using Thrift because my other dependencies all used 1.2.1. `` 2:02 PMCargo project update failed: Cargo execution failed (exit code 101). /Users//.cargo/bin/cargo metadata --verbose --format-version 1 --all-features stdout : Updating git repository `https://github.com/apache/thrift.git` Updating registry `https://github.com/rust-lang/crates.io-index` error: failed to select a version for `byteorder` (required by `thrift`): all possible versions conflict with previously selected versions of `byteorder` version 1.2.1 in use by byteorder v1.2.1 possible versions to select: 1.1.0 > Upgrade byteorder version in Rust lib > - > > Key: THRIFT-4527 > URL: https://issues.apache.org/jira/browse/THRIFT-4527 > Project: Thrift > Issue Type: Dependency upgrade > Components: Rust - Library >Affects Versions: 0.11.0 >Reporter: Joshua >Priority: Major > > The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to > prevent dependency conflicts in a project I was working on, works fine and > would be useful for other users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib
[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408906#comment-16408906 ] ASF GitHub Bot commented on THRIFT-4527: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1516 LGTM. @QuestofIranon just curious - why bump the version? > Upgrade byteorder version in Rust lib > - > > Key: THRIFT-4527 > URL: https://issues.apache.org/jira/browse/THRIFT-4527 > Project: Thrift > Issue Type: Dependency upgrade > Components: Rust - Library >Affects Versions: 0.11.0 >Reporter: Joshua >Priority: Major > > The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to > prevent dependency conflicts in a project I was working on, works fine and > would be useful for other users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib
[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408647#comment-16408647 ] Joshua commented on THRIFT-4527: see: https://github.com/apache/thrift/pull/1516 > Upgrade byteorder version in Rust lib > - > > Key: THRIFT-4527 > URL: https://issues.apache.org/jira/browse/THRIFT-4527 > Project: Thrift > Issue Type: Dependency upgrade > Components: Rust - Library >Affects Versions: 0.11.0 >Reporter: Joshua >Priority: Major > > The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.0 to > prevent dependency conflicts in a project I was working on, works fine now. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib
[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408646#comment-16408646 ] ASF GitHub Bot commented on THRIFT-4527: GitHub user QuestofIranon opened a pull request: https://github.com/apache/thrift/pull/1516 THRIFT-4527 Upgrade byteorder in rust updated byteorder 1.1.0 -> 1.2.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/QuestofIranon/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1516.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1516 commit a0116e5cb37e8e804b2d9758950f58d6c8776054 Author: JoshDate: 2018-03-21T21:34:44Z THRIFT-4527 bump byteorder version > Upgrade byteorder version in Rust lib > - > > Key: THRIFT-4527 > URL: https://issues.apache.org/jira/browse/THRIFT-4527 > Project: Thrift > Issue Type: Dependency upgrade > Components: Rust - Library >Affects Versions: 0.11.0 >Reporter: Joshua >Priority: Major > > The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.0 to > prevent dependency conflicts in a project I was working on, works fine now. -- This message was sent by Atlassian JIRA (v7.6.3#76005)