[jira] [Commented] (THRIFT-4545) Appveyor builds are failing due to a haskell / cabal update in chocolatey

2018-11-11 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/THRIFT-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683026#comment-16683026
 ] 

ASF GitHub Bot commented on THRIFT-4545:


jeking3 closed pull request #1626: THRIFT-4545: fix haskell build on windows, 
fix appveyor stale packages
URL: https://github.com/apache/thrift/pull/1626
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build/appveyor/MSVC-appveyor-build.bat 
b/build/appveyor/MSVC-appveyor-build.bat
index 31aac57c99..a4b92a29cd 100644
--- a/build/appveyor/MSVC-appveyor-build.bat
+++ b/build/appveyor/MSVC-appveyor-build.bat
@@ -21,8 +21,6 @@ CALL cl_setenv.bat  || EXIT /B
 MKDIR "%BUILDDIR%"  || EXIT /B
 CD "%BUILDDIR%" || EXIT /B
 
-:: Haskell is disabled for cmake (Windows), see Jira THRIFT-4545
-
 @ECHO ON
   cmake "%SRCDIR%" ^
 -G"%GENERATOR%" ^
@@ -38,7 +36,6 @@ CD "%BUILDDIR%" || EXIT /B
 -DOPENSSL_USE_STATIC_LIBS=OFF ^
 -DZLIB_LIBRARY="%WIN3P%\zlib-inst\lib\zlib%ZLIB_LIB_SUFFIX%.lib" ^
 -DZLIB_ROOT="%WIN3P%\zlib-inst" ^
--DWITH_HASKELL=OFF ^
 -DWITH_PYTHON=%WITH_PYTHON% ^
 -DWITH_%THREADMODEL%THREADS=ON ^
 -DWITH_SHARED_LIB=OFF ^
diff --git a/build/appveyor/MSVC-appveyor-install.bat 
b/build/appveyor/MSVC-appveyor-install.bat
index f9eb0c67da..f973d29cff 100644
--- a/build/appveyor/MSVC-appveyor-install.bat
+++ b/build/appveyor/MSVC-appveyor-install.bat
@@ -31,14 +31,14 @@ choco feature enable -n allowGlobalConfirmation || EXIT /B
 :: Things to install when NOT running in appveyor:
 IF "%APPVEYOR_BUILD_ID%" == "" (
 cup -y chocolatey || EXIT /B
-cinst -c "%BUILDCACHE%" -y curl   || EXIT /B
-cinst -c "%BUILDCACHE%" -y 7zip   || EXIT /B
-cinst -c "%BUILDCACHE%" -y python3|| EXIT /B
-cinst -c "%BUILDCACHE%" -y openssl.light || EXIT /B
+cinst -y curl || EXIT /B
+cinst -y 7zip || EXIT /B
+cinst -y python3  || EXIT /B
+cinst -y openssl.light|| EXIT /B
 )
 
-cinst -c "%BUILDCACHE%" -y jdk8   || EXIT /B
-cinst -c "%BUILDCACHE%" -y winflexbison3  || EXIT /B
+cinst -y jdk8 || EXIT /B
+cinst -y winflexbison3|| EXIT /B
 
 :: zlib - not available through chocolatey
 CD "%APPVEYOR_SCRIPTS%"   || EXIT /B
@@ -56,5 +56,4 @@ pip.exe ^
 tornado ^
 twisted   || EXIT /B
 
-:: Haskell (GHC) and cabal (disabled: see Jira THRIFT-4545)
-:: cinst -c "%BUILDCACHE%" -y ghc|| EXIT /B
+cinst -y ghc  || EXIT /B
diff --git a/build/appveyor/cl_setenv.bat b/build/appveyor/cl_setenv.bat
index 10af2d3477..62856cba0c 100644
--- a/build/appveyor/cl_setenv.bat
+++ b/build/appveyor/cl_setenv.bat
@@ -37,7 +37,6 @@ CALL cl_setcompiler.bat   || EXIT /B
 CALL cl_setgenerator.bat  || EXIT /B
 
 SET APPVEYOR_SCRIPTS=%APPVEYOR_BUILD_FOLDER%\build\appveyor
-SET BUILDCACHE=%APPVEYOR_BUILD_FOLDER%\..\build\cache
 SET BUILDDIR=%APPVEYOR_BUILD_FOLDER%\..\build\%PROFILE%\%PLATFORM%
 SET INSTDIR=%APPVEYOR_BUILD_FOLDER%\..\build\%PROFILE%\%PLATFORM%
 SET SRCDIR=%APPVEYOR_BUILD_FOLDER%
diff --git a/build/appveyor/cl_showenv.bat b/build/appveyor/cl_showenv.bat
index 3dda546e50..a70a4906aa 100644
--- a/build/appveyor/cl_showenv.bat
+++ b/build/appveyor/cl_showenv.bat
@@ -38,7 +38,6 @@ ECHO BASH  = %BASH%
 ECHO BOOST_ROOT= %BOOST_ROOT%
 ECHO BOOST_INCLUDEDIR  = %BOOST_INCLUDEDIR%
 ECHO BOOST_LIBRARYDIR  = %BOOST_LIBRARYDIR%
-ECHO BUILDCACHE= %BUILDCACHE%
 ECHO BUILDDIR  = %BUILDDIR%
 ECHO COMPILER  = %COMPILER%
 ECHO GENERATOR = %GENERATOR%
diff --git a/lib/hs/thrift.cabal b/lib/hs/thrift.cabal
index 03a9814f38..a907d78e81 100644
--- a/lib/hs/thrift.cabal
+++ b/lib/hs/thrift.cabal
@@ -18,8 +18,8 @@
 --
 
 Name:   thrift
-Version:1.0.0-dev
-Cabal-Version:  >= 1.24
+Version:0.99.0
+Cabal-Version:  1.24
 License:OtherLicense
 Category:   Foreign
 Build-Type: Simple
@@ -63,8 +63,7 @@ Library
 Thrift.Transport.IOBuffer,
 Thrift.Transport.Memory,
 Thrift.Types
-  Default-Language:
-Haskell2010
+  Default-Language: Haskell2010
   Default-Extensions:
 DeriveDataTypeable,
 ExistentialQuantification,
@@ -82,3 +81,4 @@ Test-Suite spec
   Ghc-Options: -Wall
   main-is: Spec.hs
   Build-Depends: base, thrift, hspec, QuickCheck >= 2.8.2, bytestring >= 0.10, 
unordered-containers >= 0.2.6
+  Default-Language: Haskell2010

[jira] [Commented] (THRIFT-4545) Appveyor builds are failing due to a haskell / cabal update in chocolatey

2018-11-11 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/THRIFT-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682994#comment-16682994
 ] 

ASF GitHub Bot commented on THRIFT-4545:


jeking3 commented on a change in pull request #1626: THRIFT-4545: fix haskell 
build on windows, fix appveyor stale packages
URL: https://github.com/apache/thrift/pull/1626#discussion_r232501820
 
 

 ##
 File path: lib/hs/thrift.cabal
 ##
 @@ -18,8 +18,8 @@
 --
 
 Name:   thrift
-Version:1.0.0-dev
-Cabal-Version:  >= 1.24
+Version:0.99.0
 
 Review comment:
   @jfarrell @Jens-G note: cabal will no longer allow "1.0.0-dev" as a 
version... this happens with newer versions of cabal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Appveyor builds are failing due to a haskell / cabal update in chocolatey
> -
>
> Key: THRIFT-4545
> URL: https://issues.apache.org/jira/browse/THRIFT-4545
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Major
>
> Working on it.
> Progress: Downloading cabal 2.2.0.0... 100%
> Progress: Downloading ghc 8.4.1... 100%



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4545) Appveyor builds are failing due to a haskell / cabal update in chocolatey

2018-11-11 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/THRIFT-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682905#comment-16682905
 ] 

ASF GitHub Bot commented on THRIFT-4545:


jeking3 opened a new pull request #1626: THRIFT-4545: fix haskell build on 
windows, fix appveyor stale packages
URL: https://github.com/apache/thrift/pull/1626
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Appveyor builds are failing due to a haskell / cabal update in chocolatey
> -
>
> Key: THRIFT-4545
> URL: https://issues.apache.org/jira/browse/THRIFT-4545
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Priority: Major
>
> Working on it.
> Progress: Downloading cabal 2.2.0.0... 100%
> Progress: Downloading ghc 8.4.1... 100%



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4545) Appveyor builds are failing due to a haskell / cabal update in chocolatey

2018-04-05 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427774#comment-16427774
 ] 

James E. King, III commented on THRIFT-4545:


I'm seeing errors like this:
{noformat}
  cabal: Leaving directory 
'C:\Users\JIM~1.KIN\AppData\Local\Temp\cabal-tmp-7588\network-2.6.3.5'
  Building Win32-2.5.4.1...
  Installed Win32-2.5.4.1
cabal.exe : error : some packages failed to install: 
[C:\workspace\build\thrift\dev\vc141\x64\lib\hs\haskell_library.vcxproj]
  HTTP-4000.3.10-725ymfsh3CwBfHZuIM7INB depends on HTTP-4000.3.10 which failed
  to install.
  network-2.6.3.5-KqudTj9wjt4G2VU5TpfGzl failed during the configure step. The
  exception was:
  ExitFailure 1
{noformat}


> Appveyor builds are failing due to a haskell / cabal update in chocolatey
> -
>
> Key: THRIFT-4545
> URL: https://issues.apache.org/jira/browse/THRIFT-4545
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.11.0
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> Working on it.
> Progress: Downloading cabal 2.2.0.0... 100%
> Progress: Downloading ghc 8.4.1... 100%



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4545) Appveyor builds are failing due to a haskell / cabal update in chocolatey

2018-04-05 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427775#comment-16427775
 ] 

James E. King, III commented on THRIFT-4545:


I am disabling haskell in windows cmake builds until someone can resolve this.

> Appveyor builds are failing due to a haskell / cabal update in chocolatey
> -
>
> Key: THRIFT-4545
> URL: https://issues.apache.org/jira/browse/THRIFT-4545
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.11.0
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> Working on it.
> Progress: Downloading cabal 2.2.0.0... 100%
> Progress: Downloading ghc 8.4.1... 100%



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)