[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715016#comment-16715016 ] ASF GitHub Bot commented on THRIFT-4679: jeking3 commented on issue #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642#issuecomment-445875450 When we complete the 0.12.0 release then we start pushing out to package managers. It's kind of ad-hoc for the project however. It looks like @jfarrell maintains the npmjs updates. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Assignee: James E. King III >Priority: Minor > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715038#comment-16715038 ] ASF GitHub Bot commented on THRIFT-4679: griffinmichl commented on issue #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642#issuecomment-445881713 Sounds good. I think my company also has some fixes to the browser serializer they want to get in (we use our own right now). I'll try to get that moving along so we can get it into that release as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Assignee: James E. King III >Priority: Minor > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715002#comment-16715002 ] ASF GitHub Bot commented on THRIFT-4679: griffinmichl commented on issue #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642#issuecomment-445871911 Any idea how I can get this merged into the thrift npm package? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Assignee: James E. King III >Priority: Minor > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713291#comment-16713291 ] ASF GitHub Bot commented on THRIFT-4679: jeking3 closed pull request #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/lib/nodejs/lib/thrift/json_protocol.js b/lib/nodejs/lib/thrift/json_protocol.js index d960be9d0c..727a3b2ffb 100644 --- a/lib/nodejs/lib/thrift/json_protocol.js +++ b/lib/nodejs/lib/thrift/json_protocol.js @@ -18,7 +18,6 @@ */ var Int64 = require('node-int64'); -var InputBufferUnderrunError = require('./transport').InputBufferUnderrunError; var Thrift = require('./thrift'); var Type = Thrift.Type; var util = require("util"); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Priority: Minor > Labels: easyfix > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713192#comment-16713192 ] ASF GitHub Bot commented on THRIFT-4679: griffinmichl opened a new pull request #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642 Changes are backwards compatible (as this line never did anything) https://issues.apache.org/jira/browse/THRIFT-4679 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Priority: Minor > Labels: easyfix > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)