[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131242#comment-13131242 ] Jake Farrell commented on THRIFT-633: - Rajika, what IDE are you using thats complaining about the @Override? Have you changed the default java version to be 1.6 within the IDE? Are you able to successfully compile run the generated code? > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts >Assignee: Jake Farrell > Attachments: course.thrift > > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124323#comment-13124323 ] Rajika Kumarasiri commented on THRIFT-633: -- [rajika@localhost ~]$ java -version java version "1.6.0_17" Java(TM) SE Runtime Environment (build 1.6.0_17-b04) Java HotSpot(TM) 64-Bit Server VM (build 14.3-b01, mixed mode) Actual issue is, the generated java code contains @Override annotations, which my IDE complains saying "@Override is not allowed when implementing interface method" due to the @Override annotation. I'll attach the idl. Rajika Rajika > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts >Assignee: Jake Farrell > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124276#comment-13124276 ] Jake Farrell commented on THRIFT-633: - Rajika, There is a java5 flag available a generation time which will help you generate java 1.5 compatible code. Can you please attach your idl, error log and java -version output > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123962#comment-13123962 ] Rajika Kumarasiri commented on THRIFT-633: -- I got this when generating java service for a simple IDL on Linux. Environment : Fedora 15, Sun JDK - 1.6.0_17. Rajika > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045982#comment-13045982 ] Jake Farrell commented on THRIFT-633: - Toby, have you tried reproducing this against the trunk? THRIFT-1170 should have take care of this with the new java5 option. > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045749#comment-13045749 ] Toby Thain commented on THRIFT-633: --- The bug is certainly still there with javac 1.5.0_19 and OS X 10.4.11. Another problem under 1.5 is that IOException does not have the constructor used by Thrift code. With the annotations removed, and the IOExceptions constructed using the parameter-less constructor, the code appears to build okay. ( sed -e /@Override/d -e 's/IOException(te)/IOException()/' ) It is unfortunate that 1.5 is not supported. Perhaps it should be a separate language target? > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010507#comment-13010507 ] Mathias Herberts commented on THRIFT-633: - I haven't used JDK 1.5 in a while but I'm guessing the problem is still there. > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010442#comment-13010442 ] Bryan Duxbury commented on THRIFT-633: -- Jake - the latest version of Java is 1.6, and that never shows this problem. > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010419#comment-13010419 ] Jake Farrell commented on THRIFT-633: - Tested on os x using latest version of java provided by apple and had no issues, Mathias are you still having issues with this? > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987273#action_12987273 ] Bryan Duxbury commented on THRIFT-633: -- Is this still a problem? I know a lot of things have changed in the last year. > Generated code has @Override annotations which won't compile using Apple's > JDK 1.5 > -- > > Key: THRIFT-633 > URL: https://issues.apache.org/jira/browse/THRIFT-633 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Environment: Mac OS X Tiger/Leopard JDK 1.5 >Reporter: Mathias Herberts > > Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with > error: > [javac] > /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: > method does not override a method from its superclass > [javac] @Override > [javac]^ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
