[jira] [Updated] (THRIFT-1608) Allow servlet to be supplied TProcessor and TProtocolFactory after the init() method has finished
[ https://issues.apache.org/jira/browse/THRIFT-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiril Raychev updated THRIFT-1608: -- Attachment: thrift-1608-textensibleservlet.path > Allow servlet to be supplied TProcessor and TProtocolFactory after the init() > method has finished > - > > Key: THRIFT-1608 > URL: https://issues.apache.org/jira/browse/THRIFT-1608 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Environment: any >Reporter: Kiril Raychev > Attachments: TExtensibleServlet.java, > thrift-1608-textensibleservlet.path > > > Servlets are generally considered ready to use after the init() method has > finished. That is, they are open for configuration before that. TServlet does > not follow that - it requires TProcessor and TProtocolFactory as constructor > args. > I think it will be better if if you could use the ServletContext to get the > necessary processor and factories. Those objects could be set in the context, > or it may just be more convenient not to supply them at the constructor. > I have attached a modified version of the TServlet, with a new name. It uses > abstract methods to get the required processor and factories. I don't think > it can be added cleanly to the existing TServlet, so it should be a separate > class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1608) Allow servlet to be supplied TProcessor and TProtocolFactory after the init() method has finished
[ https://issues.apache.org/jira/browse/THRIFT-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1608: - Patch Info: (was: Patch Available) Please see http://thrift.apache.org/docs/HowToContribute/ for submitting patches > Allow servlet to be supplied TProcessor and TProtocolFactory after the init() > method has finished > - > > Key: THRIFT-1608 > URL: https://issues.apache.org/jira/browse/THRIFT-1608 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Environment: any >Reporter: Kiril Raychev > Attachments: TExtensibleServlet.java > > > Servlets are generally considered ready to use after the init() method has > finished. That is, they are open for configuration before that. TServlet does > not follow that - it requires TProcessor and TProtocolFactory as constructor > args. > I think it will be better if if you could use the ServletContext to get the > necessary processor and factories. Those objects could be set in the context, > or it may just be more convenient not to supply them at the constructor. > I have attached a modified version of the TServlet, with a new name. It uses > abstract methods to get the required processor and factories. I don't think > it can be added cleanly to the existing TServlet, so it should be a separate > class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1608) Allow servlet to be supplied TProcessor and TProtocolFactory after the init() method has finished
[ https://issues.apache.org/jira/browse/THRIFT-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiril Raychev updated THRIFT-1608: -- Attachment: TExtensibleServlet.java > Allow servlet to be supplied TProcessor and TProtocolFactory after the init() > method has finished > - > > Key: THRIFT-1608 > URL: https://issues.apache.org/jira/browse/THRIFT-1608 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Environment: any >Reporter: Kiril Raychev > Attachments: TExtensibleServlet.java > > > Servlets are generally considered ready to use after the init() method has > finished. That is, they are open for configuration before that. TServlet does > not follow that - it requires TProcessor and TProtocolFactory as constructor > args. > I think it will be better if if you could use the ServletContext to get the > necessary processor and factories. Those objects could be set in the context, > or it may just be more convenient not to supply them at the constructor. > I have attached a modified version of the TServlet, with a new name. It uses > abstract methods to get the required processor and factories. I don't think > it can be added cleanly to the existing TServlet, so it should be a separate > class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
