[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger
[ https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4198: --- Fix Version/s: (was: 0.10.0) > Ruby should log Thrift internal errors to global logger > --- > > Key: THRIFT-4198 > URL: https://issues.apache.org/jira/browse/THRIFT-4198 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Reporter: Jens Geyer >Assignee: James E. King, III >Priority: Minor > > Thrift exceptions are somewhat difficult to trace from debug logs. I'd like > to add __FILE__AND__LINE__ as a second parameter to some exceptions to make > them easier to find. > For example: > Every time a required field is not set, the exception that gets generated is > a very generic > throw TProtocolException(TProtocolException::INVALID_DATA) > see - > https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372 > I think I'll start with patching up TProtocolExcpetion in the compiler and if > people like this I can make a separate issue and patch for other exceptions -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger
[ https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4198: --- Description: Logging server-side exception message on ApplicationException::INTERNAL_ERROR as discussed in https://github.com/apache/thrift/pull/1267 was: Thrift exceptions are somewhat difficult to trace from debug logs. I'd like to add __FILE__AND__LINE__ as a second parameter to some exceptions to make them easier to find. For example: Every time a required field is not set, the exception that gets generated is a very generic throw TProtocolException(TProtocolException::INVALID_DATA) see - https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372 I think I'll start with patching up TProtocolExcpetion in the compiler and if people like this I can make a separate issue and patch for other exceptions > Ruby should log Thrift internal errors to global logger > --- > > Key: THRIFT-4198 > URL: https://issues.apache.org/jira/browse/THRIFT-4198 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Reporter: Jens Geyer >Assignee: James E. King, III >Priority: Minor > > Logging server-side exception message on > ApplicationException::INTERNAL_ERROR as discussed in > https://github.com/apache/thrift/pull/1267 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger
[ https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4198: --- Component/s: (was: C++ - Compiler) (was: C++ - Library) Ruby - Library > Ruby should log Thrift internal errors to global logger > --- > > Key: THRIFT-4198 > URL: https://issues.apache.org/jira/browse/THRIFT-4198 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Reporter: Jens Geyer >Assignee: James E. King, III >Priority: Minor > > Thrift exceptions are somewhat difficult to trace from debug logs. I'd like > to add __FILE__AND__LINE__ as a second parameter to some exceptions to make > them easier to find. > For example: > Every time a required field is not set, the exception that gets generated is > a very generic > throw TProtocolException(TProtocolException::INVALID_DATA) > see - > https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372 > I think I'll start with patching up TProtocolExcpetion in the compiler and if > people like this I can make a separate issue and patch for other exceptions -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger
[ https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4198: --- Labels: (was: newbie) > Ruby should log Thrift internal errors to global logger > --- > > Key: THRIFT-4198 > URL: https://issues.apache.org/jira/browse/THRIFT-4198 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Reporter: Jens Geyer >Assignee: James E. King, III >Priority: Minor > > Thrift exceptions are somewhat difficult to trace from debug logs. I'd like > to add __FILE__AND__LINE__ as a second parameter to some exceptions to make > them easier to find. > For example: > Every time a required field is not set, the exception that gets generated is > a very generic > throw TProtocolException(TProtocolException::INVALID_DATA) > see - > https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372 > I think I'll start with patching up TProtocolExcpetion in the compiler and if > people like this I can make a separate issue and patch for other exceptions -- This message was sent by Atlassian JIRA (v6.3.15#6346)
