[ 
https://issues.apache.org/jira/browse/THRIFT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell updated THRIFT-857:
--------------------------------

    Attachment: thrift-857.patch

Bryan, saw this ticket and wanted to wrap it up. Attached is a patch with 
removes the --disable-gen-${cpp,java,etc.} from configure and forces the 
generator to include all available t_*_generator.cc files. Thoughts?

> tests run by "make install" fail if generators are disabled
> -----------------------------------------------------------
>
>                 Key: THRIFT-857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-857
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.4
>         Environment: mac os
>            Reporter: Bruce Lowekamp
>            Priority: Minor
>         Attachments: check-requested-generator.patch, 
> generator-subnamespace.patch, thrift-857.patch
>
>
> configuring with generators disabled (configure --disable-gen-java, for 
> example) produces a failed build because the tests run by "make install" 
> require the java, cpp, rb, perl, csharp, and js generators.  
> I would personally favor either removing those --disble-gen options 
> altogether, or adding a warning message in the configure --help output that 
> disabling those generators is not recommended/will cause test failure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to