[jira] [Commented] (TIKA-3948) Migrate to jakarta in Tika 3.x

2023-09-16 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TIKA-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766008#comment-17766008
 ] 

ASF GitHub Bot commented on TIKA-3948:
--

desruisseaux commented on PR #1345:
URL: https://github.com/apache/tika/pull/1345#issuecomment-1722292318

   Note that uber JAR files created by Maven Shade Plugin may not work anymore 
in a JPMS world. Currently, the plugin seems to workaround by removing all 
`module-info.class` files. It works if the dependencies duplicate all their 
services declarations into `META-INF/services/` for compatibility with the old 
world. Apache SIS and Derby for instances do that. But any library could decide 
to stop doing this duplication in some future version, because it makes more 
difficult to use some features that are unique to `module-info`. It may be 
safer to progressively move away from uber JAR if possible.




> Migrate to jakarta in Tika 3.x
> --
>
> Key: TIKA-3948
> URL: https://issues.apache.org/jira/browse/TIKA-3948
> Project: Tika
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Major
>  Labels: tika-3x
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [tika] desruisseaux commented on pull request #1345: TIKA-3948 -- migrate from javax -> jakarta

2023-09-16 Thread via GitHub 


desruisseaux commented on PR #1345:
URL: https://github.com/apache/tika/pull/1345#issuecomment-1722292318

   Note that uber JAR files created by Maven Shade Plugin may not work anymore 
in a JPMS world. Currently, the plugin seems to workaround by removing all 
`module-info.class` files. It works if the dependencies duplicate all their 
services declarations into `META-INF/services/` for compatibility with the old 
world. Apache SIS and Derby for instances do that. But any library could decide 
to stop doing this duplication in some future version, because it makes more 
difficult to use some features that are unique to `module-info`. It may be 
safer to progressively move away from uber JAR if possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (TIKA-3948) Migrate to jakarta in Tika 3.x

2023-09-16 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TIKA-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765994#comment-17765994
 ] 

ASF GitHub Bot commented on TIKA-3948:
--

tballison commented on PR #1345:
URL: https://github.com/apache/tika/pull/1345#issuecomment-1722265254

   Best handled by jar exclusions or is there something better we can do w
   restructuring dependencies? We have some flexibility in 3.x to get it
   right.
   
   On Sat, Sep 16, 2023 at 12:53 AM Maxim Solodovnik ***@***.***>
   wrote:
   
   > @tballison  I believe warning from
   > shade:3.5.0:shade have to be addressed before merge:
   >
   > lots of them 
   >
   > [WARNING] log4j-slf4j2-impl-2.20.0.jar, tika-async-cli-3.0.0-SNAPSHOT.jar 
define 13 overlapping classes and resources:
   > [WARNING]   - 
META-INF/maven/org.apache.logging.log4j/log4j-slf4j2-impl/pom.properties
   > [WARNING]   - 
META-INF/maven/org.apache.logging.log4j/log4j-slf4j2-impl/pom.xml
   > [WARNING]   - org.apache.logging.slf4j.Log4jEventBuilder
   > [WARNING]   - org.apache.logging.slf4j.Log4jLogger
   > [WARNING]   - org.apache.logging.slf4j.Log4jLoggerFactory
   > [WARNING]   - org.apache.logging.slf4j.Log4jMDCAdapter
   > [WARNING]   - org.apache.logging.slf4j.Log4jMDCAdapter$1
   > [WARNING]   - 
org.apache.logging.slf4j.Log4jMDCAdapter$ThreadLocalMapOfStacks
   > [WARNING]   - org.apache.logging.slf4j.Log4jMarker
   > [WARNING]   - org.apache.logging.slf4j.Log4jMarkerFactory
   > [WARNING]   - 3 more...
   >
   > [WARNING] jaxb-core-4.0.3.jar, tika-server-core-3.0.0-SNAPSHOT.jar define 
128 overlapping classes and resources:
   > [WARNING]   - META-INF/maven/org.glassfish.jaxb/jaxb-core/pom.properties
   > [WARNING]   - META-INF/maven/org.glassfish.jaxb/jaxb-core/pom.xml
   > [WARNING]   - org.glassfish.jaxb.core.Locatable
   > [WARNING]   - org.glassfish.jaxb.core.StackHelper
   > [WARNING]   - org.glassfish.jaxb.core.Utils
   > [WARNING]   - org.glassfish.jaxb.core.WhiteSpaceProcessor
   > [WARNING]   - org.glassfish.jaxb.core.annotation.OverrideAnnotationOf
   > [WARNING]   - org.glassfish.jaxb.core.annotation.XmlIsSet
   > [WARNING]   - org.glassfish.jaxb.core.annotation.XmlLocation
   > [WARNING]   - org.glassfish.jaxb.core.api.ErrorListener
   > [WARNING]   - 118 more...
   >
   >
   > As well as bundle inclusion list from here:
   > tika-bundles/tika-bundle-standard/pom.xml
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   




> Migrate to jakarta in Tika 3.x
> --
>
> Key: TIKA-3948
> URL: https://issues.apache.org/jira/browse/TIKA-3948
> Project: Tika
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Major
>  Labels: tika-3x
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [tika] tballison commented on pull request #1345: TIKA-3948 -- migrate from javax -> jakarta

2023-09-16 Thread via GitHub 


tballison commented on PR #1345:
URL: https://github.com/apache/tika/pull/1345#issuecomment-1722265254

   Best handled by jar exclusions or is there something better we can do w
   restructuring dependencies? We have some flexibility in 3.x to get it
   right.
   
   On Sat, Sep 16, 2023 at 12:53 AM Maxim Solodovnik ***@***.***>
   wrote:
   
   > @tballison  I believe warning from
   > shade:3.5.0:shade have to be addressed before merge:
   >
   > lots of them 
   >
   > [WARNING] log4j-slf4j2-impl-2.20.0.jar, tika-async-cli-3.0.0-SNAPSHOT.jar 
define 13 overlapping classes and resources:
   > [WARNING]   - 
META-INF/maven/org.apache.logging.log4j/log4j-slf4j2-impl/pom.properties
   > [WARNING]   - 
META-INF/maven/org.apache.logging.log4j/log4j-slf4j2-impl/pom.xml
   > [WARNING]   - org.apache.logging.slf4j.Log4jEventBuilder
   > [WARNING]   - org.apache.logging.slf4j.Log4jLogger
   > [WARNING]   - org.apache.logging.slf4j.Log4jLoggerFactory
   > [WARNING]   - org.apache.logging.slf4j.Log4jMDCAdapter
   > [WARNING]   - org.apache.logging.slf4j.Log4jMDCAdapter$1
   > [WARNING]   - 
org.apache.logging.slf4j.Log4jMDCAdapter$ThreadLocalMapOfStacks
   > [WARNING]   - org.apache.logging.slf4j.Log4jMarker
   > [WARNING]   - org.apache.logging.slf4j.Log4jMarkerFactory
   > [WARNING]   - 3 more...
   >
   > [WARNING] jaxb-core-4.0.3.jar, tika-server-core-3.0.0-SNAPSHOT.jar define 
128 overlapping classes and resources:
   > [WARNING]   - META-INF/maven/org.glassfish.jaxb/jaxb-core/pom.properties
   > [WARNING]   - META-INF/maven/org.glassfish.jaxb/jaxb-core/pom.xml
   > [WARNING]   - org.glassfish.jaxb.core.Locatable
   > [WARNING]   - org.glassfish.jaxb.core.StackHelper
   > [WARNING]   - org.glassfish.jaxb.core.Utils
   > [WARNING]   - org.glassfish.jaxb.core.WhiteSpaceProcessor
   > [WARNING]   - org.glassfish.jaxb.core.annotation.OverrideAnnotationOf
   > [WARNING]   - org.glassfish.jaxb.core.annotation.XmlIsSet
   > [WARNING]   - org.glassfish.jaxb.core.annotation.XmlLocation
   > [WARNING]   - org.glassfish.jaxb.core.api.ErrorListener
   > [WARNING]   - 118 more...
   >
   >
   > As well as bundle inclusion list from here:
   > tika-bundles/tika-bundle-standard/pom.xml
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (TIKA-4129) Upgrade dependencies requiring > Java 8

2023-09-16 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/TIKA-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765913#comment-17765913
 ] 

Hudson commented on TIKA-4129:
--

SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk11 #1251 (See 
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk11/1251/])
TIKA-4129: update aws, plexus (tilman: 
[https://github.com/apache/tika/commit/86ec9ce43fcef28c5355716c2fa2484b861a05bb])
* (edit) tika-parent/pom.xml


> Upgrade dependencies requiring > Java 8
> ---
>
> Key: TIKA-4129
> URL: https://issues.apache.org/jira/browse/TIKA-4129
> Project: Tika
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> On TIKA-3735, we documented several dependencies that required > Java 8.  Now 
> that we're working with Java 11 on main, let's make those upgrades.
> There was already a separate ticket open for Lucene (TIKA-3641), so let's 
> upgrade these:
>  * Apache OpenNLP 2.0.0 requires Java 11.
>  * DL4J 1.0.0-M2.1 - datavec-data-image-1.0.0-M2.1.jar requires Java 11
>  * Fakeload
>  * 
> [checkstyle|https://mail.google.com/mail/u/0/#label/lists%2Ftika/WhctKKXXHvjnJRRdBSwLbKkDkXQtRnWGDhblVMQQZhjsDGrFpRMRQJJrZSdskrNCqcmTtjL]
>  * errorprone requires Java 11 for the build (doesn't mean we can't target 8)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)