[jira] [Comment Edited] (TIKA-4236) tika-parser-nlp-module has an unnecessary Guava dependency
[
https://issues.apache.org/jira/browse/TIKA-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834277#comment-17834277
]
Tilman Hausherr edited comment on TIKA-4236 at 4/5/24 12:21 PM:
Is this what you had in mind?
https://github.com/apache/tika/commit/1586e7281837850cfe36d6201d905edb2d77241f
https://github.com/apache/tika/commit/920976d9f26695892ab503b8c93b213d9622d18e
this is for the trunk, I can also do it for 2.9.3 but 1.* is no longer
supported.
Btw guava might still reappear in other tika components.
was (Author: tilman):
Is this what you had in mind?
https://github.com/apache/tika/commit/1586e7281837850cfe36d6201d905edb2d77241f
https://github.com/apache/tika/commit/920976d9f26695892ab503b8c93b213d9622d18e
this is for the trunk, I can also do it for 2.9.3 but 1.* is no longer
supported.
> tika-parser-nlp-module has an unnecessary Guava dependency
> --
>
> Key: TIKA-4236
> URL: https://issues.apache.org/jira/browse/TIKA-4236
> Project: Tika
> Issue Type: Bug
> Components: parser
>Affects Versions: 1.28.5, 3.0.0-BETA, 2.9.2
>Reporter: Manfred Baedke
>Priority: Major
>
> This should be avoided, because it's prone to maintenance and security
> problems.
> It's easy to get rid of it: the class
> {{o.a.t.parser.geo.topic.gazetteer.GeoGazetteerClient}} uses
> {{{}com.google.common.reflect.TypeToken{}}}. Since the project uses gson
> anyway, it could just be replaced with
> {{{}com.google.gson.reflect.TypeToken{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (TIKA-4236) tika-parser-nlp-module has an unnecessary Guava dependency
[
https://issues.apache.org/jira/browse/TIKA-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834279#comment-17834279
]
Manfred Baedke edited comment on TIKA-4236 at 4/5/24 12:24 PM:
---
Man, you are slow! Yes, that's it, thx :)
??Btw guava might still reappear in other tika components.??
Yes, but at least in parsers that seems to be the only usage.
was (Author: baedke):
Man, you are slow! Yes, that's it, thx :)
??Btw guava might still reappear in other tika components.??
Yes, but at least in parsers that seems to be the only usage.
> tika-parser-nlp-module has an unnecessary Guava dependency
> --
>
> Key: TIKA-4236
> URL: https://issues.apache.org/jira/browse/TIKA-4236
> Project: Tika
> Issue Type: Bug
> Components: parser
>Affects Versions: 1.28.5, 3.0.0-BETA, 2.9.2
>Reporter: Manfred Baedke
>Priority: Major
>
> This should be avoided, because it's prone to maintenance and security
> problems.
> It's easy to get rid of it: the class
> {{o.a.t.parser.geo.topic.gazetteer.GeoGazetteerClient}} uses
> {{{}com.google.common.reflect.TypeToken{}}}. Since the project uses gson
> anyway, it could just be replaced with
> {{{}com.google.gson.reflect.TypeToken{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
