[jira] [Commented] (TIKA-1554) Improve EMF file detection
[ https://issues.apache.org/jira/browse/TIKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505172#comment-14505172 ] Luis Filipe Nassif commented on TIKA-1554: -- Actually r1667661 > Improve EMF file detection > -- > > Key: TIKA-1554 > URL: https://issues.apache.org/jira/browse/TIKA-1554 > Project: Tika > Issue Type: Bug > Components: detector >Affects Versions: 1.7 >Reporter: Luis Filipe Nassif >Assignee: Chris A. Mattmann > Fix For: 1.8 > > Attachments: nonEmf.dat > > > I am getting many files being incorrectly detected as application/x-emf. I > think the current magic is too common. According to MS documentation > (https://msdn.microsoft.com/en-us/library/cc230635.aspx and > https://msdn.microsoft.com/en-us/library/dd240211.aspx), it can be improved > to: > {code} > > EMF > <_comment>Extended Metafile > > > > > > > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1554) Improve EMF file detection
[ https://issues.apache.org/jira/browse/TIKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368568#comment-14368568 ] ASF GitHub Bot commented on TIKA-1554: -- Github user asfgit closed the pull request at: https://github.com/apache/tika/pull/34 > Improve EMF file detection > -- > > Key: TIKA-1554 > URL: https://issues.apache.org/jira/browse/TIKA-1554 > Project: Tika > Issue Type: Bug > Components: detector >Affects Versions: 1.7 >Reporter: Luis Filipe Nassif >Assignee: Chris A. Mattmann > Attachments: nonEmf.dat > > > I am getting many files being incorrectly detected as application/x-emf. I > think the current magic is too common. According to MS documentation > (https://msdn.microsoft.com/en-us/library/cc230635.aspx and > https://msdn.microsoft.com/en-us/library/dd240211.aspx), it can be improved > to: > {code} > > EMF > <_comment>Extended Metafile > > > > > > > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1554) Improve EMF file detection
[ https://issues.apache.org/jira/browse/TIKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366038#comment-14366038 ] ASF GitHub Bot commented on TIKA-1554: -- GitHub user mkr opened a pull request: https://github.com/apache/tika/pull/34 TIKA-1554: Adding EMF magic as per Microsoft's EMF specification, thanks to Luis Filipe Nassif TIKA-1554: Adding EMF magic as per Microsoft's EMF specification, thanks to Luis Filipe Nassif You can merge this pull request into a Git repository by running: $ git pull https://github.com/mkr/tika TIKA-1554 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tika/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 4608ff50c28b9ba8c2d1caf6fe4530eeb2a088be Author: Matthias Krueger Date: 2015-03-17T12:45:06Z TIKA-1554: Adding EMF magic as per Microsoft's EMF specification, thanks to Luis Filipe Nassif > Improve EMF file detection > -- > > Key: TIKA-1554 > URL: https://issues.apache.org/jira/browse/TIKA-1554 > Project: Tika > Issue Type: Bug > Components: detector >Affects Versions: 1.7 >Reporter: Luis Filipe Nassif > Attachments: nonEmf.dat > > > I am getting many files being incorrectly detected as application/x-emf. I > think the current magic is too common. According to MS documentation > (https://msdn.microsoft.com/en-us/library/cc230635.aspx and > https://msdn.microsoft.com/en-us/library/dd240211.aspx), it can be improved > to: > {code} > > EMF > <_comment>Extended Metafile > > > > > > > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1554) Improve EMF file detection
[ https://issues.apache.org/jira/browse/TIKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329138#comment-14329138 ] Nick Burch commented on TIKA-1554: -- Do you have any small files which incorrectly trigger it now? One of those would be good for a unit test for this! > Improve EMF file detection > -- > > Key: TIKA-1554 > URL: https://issues.apache.org/jira/browse/TIKA-1554 > Project: Tika > Issue Type: Bug > Components: detector >Affects Versions: 1.7 >Reporter: Luis Filipe Nassif > > I am getting many files being incorrectly detected as application/x-emf. I > think the current magic is too common. According to MS documentation > (https://msdn.microsoft.com/en-us/library/cc230635.aspx and > https://msdn.microsoft.com/en-us/library/dd240211.aspx), it can be improved > to: > {code} > > EMF > <_comment>Extended Metafile > > > > > > > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)