[jira] [Commented] (TIKA-1659) ZipContainerDetector does not detect all IPA files

2015-06-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/TIKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601715#comment-14601715
 ] 

Hudson commented on TIKA-1659:
--

SUCCESS: Integrated in tika-trunk-jdk1.7 #766 (See 
[https://builds.apache.org/job/tika-trunk-jdk1.7/766/])
Fix for TIKA-1659 ZipContainerDetector does not detect all IPA files 
contributed by Rami Shomali  this closes #51. 
(mattmann: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1687594)
* /tika/trunk/CHANGES.txt
* 
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java


> ZipContainerDetector does not detect all IPA files 
> ---
>
> Key: TIKA-1659
> URL: https://issues.apache.org/jira/browse/TIKA-1659
> Project: Tika
>  Issue Type: Bug
>  Components: mime
>Reporter: Rami Shomali
>Assignee: Chris A. Mattmann
> Fix For: 1.10
>
> Attachments: CamLingual.ipa, hacker_news.ipa
>
>
> ZipContainerDetector expects two files to identify the IPA file as 
> "application/x-itunes-ipa":
> 1) app/CodeResources
> 2) app/ResourceRules.plist
> https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java#L386
> Recent IPA files downloaded from the App Store do not include those files. 
> Need to update ZipContainerDetector and remove the patterns for those two 
> files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TIKA-1659) ZipContainerDetector does not detect all IPA files

2015-06-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TIKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601632#comment-14601632
 ] 

ASF GitHub Bot commented on TIKA-1659:
--

Github user asfgit closed the pull request at:

https://github.com/apache/tika/pull/51


> ZipContainerDetector does not detect all IPA files 
> ---
>
> Key: TIKA-1659
> URL: https://issues.apache.org/jira/browse/TIKA-1659
> Project: Tika
>  Issue Type: Bug
>  Components: mime
>Reporter: Rami Shomali
>Assignee: Chris A. Mattmann
> Fix For: 1.10
>
> Attachments: CamLingual.ipa, hacker_news.ipa
>
>
> ZipContainerDetector expects two files to identify the IPA file as 
> "application/x-itunes-ipa":
> 1) app/CodeResources
> 2) app/ResourceRules.plist
> https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java#L386
> Recent IPA files downloaded from the App Store do not include those files. 
> Need to update ZipContainerDetector and remove the patterns for those two 
> files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TIKA-1659) ZipContainerDetector does not detect all IPA files

2015-06-18 Thread Nick Burch (JIRA)

[ 
https://issues.apache.org/jira/browse/TIKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591756#comment-14591756
 ] 

Nick Burch commented on TIKA-1659:
--

Do you have a small sample IPA file that isn't detected that you could share? 
Ideally an Apache licensed one, but if not one we can just look at

> ZipContainerDetector does not detect all IPA files 
> ---
>
> Key: TIKA-1659
> URL: https://issues.apache.org/jira/browse/TIKA-1659
> Project: Tika
>  Issue Type: Bug
>  Components: mime
>Reporter: Rami Shomali
>
> ZipContainerDetector expects two files to identify the IPA file as 
> "application/x-itunes-ipa":
> 1) app/CodeResources
> 2) app/ResourceRules.plist
> https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java#L386
> Recent IPA files downloaded from the App Store do not include those files. 
> Need to update ZipContainerDetector and remove the patterns for those two 
> files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TIKA-1659) ZipContainerDetector does not detect all IPA files

2015-06-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TIKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591754#comment-14591754
 ] 

ASF GitHub Bot commented on TIKA-1659:
--

GitHub user Rshomali opened a pull request:

https://github.com/apache/tika/pull/51

fix for TIKA-1659 contributed by rami



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Rshomali/tika TIKA-1659

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tika/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit b333284c8d77ecc26431c765d1fba495ea168aef
Author: Rami Shomali 
Date:   2015-06-18T13:02:16Z

fix for TIKA-1659 contributed by rami




> ZipContainerDetector does not detect all IPA files 
> ---
>
> Key: TIKA-1659
> URL: https://issues.apache.org/jira/browse/TIKA-1659
> Project: Tika
>  Issue Type: Bug
>  Components: mime
>Reporter: Rami Shomali
>
> ZipContainerDetector expects two files to identify the IPA file as 
> "application/x-itunes-ipa":
> 1) app/CodeResources
> 2) app/ResourceRules.plist
> https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java#L386
> Recent IPA files downloaded from the App Store do not include those files. 
> Need to update ZipContainerDetector and remove the patterns for those two 
> files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)