[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357807#comment-15357807 ] Hudson commented on TIKA-1978: -- SUCCESS: Integrated in tika-2.x #120 (See [https://builds.apache.org/job/tika-2.x/120/]) TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do (lewis.mcgibbney: rev bd3ecfcddeaf13262e477ba29c5256ebd44e32db) * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/GeoParserConfig.java * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/GeoTag.java * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/GeoParser.java * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/NameEntityExtractor.java > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 2.0, 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1535#comment-1535 ] Hudson commented on TIKA-1978: -- FAILURE: Integrated in tika-2.x-windows #24 (See [https://builds.apache.org/job/tika-2.x-windows/24/]) TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do (lewis.mcgibbney: rev bd3ecfcddeaf13262e477ba29c5256ebd44e32db) * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/NameEntityExtractor.java * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/GeoParser.java * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/GeoParserConfig.java * tika-parser-modules/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/geo/topic/GeoTag.java > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 2.0, 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357710#comment-15357710 ] ASF GitHub Bot commented on TIKA-1978: -- Github user asfgit closed the pull request at: https://github.com/apache/tika/pull/124 > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 2.0, 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302611#comment-15302611 ] Lewis John McGibbney commented on TIKA-1978: [~talli...@mitre.org] please see https://github.com/apache/tika/pull/124 > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 2.0, 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302610#comment-15302610 ] ASF GitHub Bot commented on TIKA-1978: -- GitHub user lewismc opened a pull request: https://github.com/apache/tika/pull/124 TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) 2.x branch This issue addresses https://issues.apache.org/jira/browse/TIKA-1978 for the 2.x branch. It also makes a number of additional improvements such as using the diamond operator where possible, throwing and logging the correct exceptions and using the correct syntax for constants. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/tika TIKA-1978v2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tika/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit bd3ecfcddeaf13262e477ba29c5256ebd44e32db Author: Lewis John McGibbneyDate: 2016-05-26T18:15:02Z TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) 2.x branch > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 2.0, 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302473#comment-15302473 ] Lewis John McGibbney commented on TIKA-1978: No problem I will make it right now [~talli...@mitre.org] > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302240#comment-15302240 ] Tim Allison commented on TIKA-1978: --- [~lewismc], mind making this fix on the 2.x branch if you haven't already? > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300426#comment-15300426 ] Hudson commented on TIKA-1978: -- SUCCESS: Integrated in tika-trunk-jdk1.7 #999 (See [https://builds.apache.org/job/tika-trunk-jdk1.7/999/]) TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do (lewis.mcgibbney: rev fc4f13ddebf2b9519d75a3079adb307313e79259) * tika-parsers/src/main/java/org/apache/tika/parser/geo/topic/GeoParser.java > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300248#comment-15300248 ] ASF GitHub Bot commented on TIKA-1978: -- Github user asfgit closed the pull request at: https://github.com/apache/tika/pull/122 > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299047#comment-15299047 ] ASF GitHub Bot commented on TIKA-1978: -- GitHub user lewismc opened a pull request: https://github.com/apache/tika/pull/122 TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) This issue addresses https://issues.apache.org/jira/browse/TIKA-1978 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/tika TIKA-1978 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tika/pull/122.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #122 commit fc4f13ddebf2b9519d75a3079adb307313e79259 Author: Lewis John McGibbneyDate: 2016-05-24T22:24:23Z TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1978) Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
[ https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292295#comment-15292295 ] Lewis John McGibbney commented on TIKA-1978: https://github.com/apache/tika/blob/master/tika-parsers/src/main/java/org/apache/tika/parser/geo/topic/GeoParser.java#L69 > Invocation of java.net.URL.equals(Object), which blocks to do domain name > resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) > --- > > Key: TIKA-1978 > URL: https://issues.apache.org/jira/browse/TIKA-1978 > Project: Tika > Issue Type: Bug > Components: parser >Affects Versions: 1.13 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 1.14 > > > Performance - The equals and hashCode methods of URL are blocking > The equals and hashCode method of URL perform domain name resolution, this > can result in a big performance hit. See > http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html > for more information. Consider using java.net.URI instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)