[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772450#comment-17772450
]
Maxim Solodovnik commented on TIKA-4139:
I can see no more Tika related errors anymore
Thanks for the quick fix! :)
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771646#comment-17771646
]
Hudson commented on TIKA-4139:
--
SUCCESS: Integrated in Jenkins build Tika ยป tika-main-jdk11 #1320 (See
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk11/1320/])
TIKA-4139 (#1381) (github:
[https://github.com/apache/tika/commit/1a0b35ca373172bbdee411dc1b079ad90ef2abf1])
* (edit)
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-jdbc-commons/pom.xml
* (edit)
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-digest-commons/pom.xml
* (edit)
tika-parsers/tika-parsers-standard/tika-parsers-standard-package/pom.xml
* (edit) tika-pipes/tika-emitters/tika-emitter-jdbc/pom.xml
* (edit) tika-handlers/tika-handler-boilerpipe/pom.xml
* (edit) tika-langdetect/tika-langdetect-opennlp/pom.xml
* (edit) tika-langdetect/tika-langdetect-optimaize/pom.xml
* (edit)
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-mail-commons/pom.xml
* (edit) tika-langdetect/tika-langdetect-lingo24/pom.xml
* (edit) tika-langdetect/tika-langdetect-mitll-text/pom.xml
* (edit) tika-detectors/tika-detector-siegfried/pom.xml
* (edit) tika-java7/pom.xml
* (edit) tika-bundles/tika-bundle-standard/pom.xml
* (edit) tika-fuzzing/pom.xml
* (edit) tika-langdetect/tika-langdetect-tika/pom.xml
* (edit) tika-pipes/tika-httpclient-commons/pom.xml
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771611#comment-17771611
]
ASF GitHub Bot commented on TIKA-4139:
--
tballison merged PR #1381:
URL: https://github.com/apache/tika/pull/1381
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771542#comment-17771542
]
ASF GitHub Bot commented on TIKA-4139:
--
tballison opened a new pull request, #1381:
URL: https://github.com/apache/tika/pull/1381
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771531#comment-17771531
]
Tim Allison commented on TIKA-4139:
---
This is excludes pom
{noformat}
tika-fuzzing/pom.xml
tika-java7/pom.xml
tika-detectors/tika-detector-siegfried/pom.xml
tika-example/pom.xml
tika-dotnet/pom.xml
tika-langdetect/tika-langdetect-opennlp/pom.xml
tika-langdetect/tika-langdetect-mitll-text/pom.xml
tika-langdetect/tika-langdetect-tika/pom.xml
tika-langdetect/tika-langdetect-lingo24/pom.xml
tika-langdetect/tika-langdetect-optimaize/pom.xml
tika-bundles/tika-bundle-standard/pom.xml
tika-parsers/tika-parsers-extended/tika-parsers-extended-integration-tests/pom.xml
tika-parsers/tika-parsers-extended/tika-parser-tagsoup-module/pom.xml
tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/pom.xml
tika-parsers/tika-parsers-ml/tika-parser-nlp-module/pom.xml
tika-parsers/tika-parsers-ml/tika-age-recogniser/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-digest-commons/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-jdbc-commons/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-mail-commons/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-package/pom.xml
tika-pipes/tika-emitters/tika-emitter-jdbc/pom.xml
tika-pipes/tika-httpclient-commons/pom.xml
tika-integration-tests/tika-pipes-solr-integration-tests/pom.xml
tika-integration-tests/tika-pipes-kafka-integration-tests/pom.xml
tika-integration-tests/tika-resource-loading-tests/pom.xml
tika-integration-tests/tika-pipes-s3-integration-tests/pom.xml
tika-integration-tests/tika-pipes-opensearch-integration-tests/pom.xml
tika-handlers/tika-handler-boilerpipe/pom.xml
{noformat}
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771524#comment-17771524
]
Tim Allison commented on TIKA-4139:
---
Do we want automatic module names for _all_ of these?
tika-server/pom.xml
tika-fuzzing/pom.xml
pom.xml
tika-java7/pom.xml
tika-bom/pom.xml
tika-detectors/pom.xml
tika-detectors/tika-detector-siegfried/pom.xml
tika-example/pom.xml
tika-dotnet/pom.xml
tika-parent/pom.xml
tika-langdetect/tika-langdetect-opennlp/pom.xml
tika-langdetect/tika-langdetect-mitll-text/pom.xml
tika-langdetect/pom.xml
tika-langdetect/tika-langdetect-tika/pom.xml
tika-langdetect/tika-langdetect-lingo24/pom.xml
tika-langdetect/tika-langdetect-optimaize/pom.xml
tika-eval/pom.xml
tika-bundles/pom.xml
tika-bundles/tika-bundle-standard/pom.xml
tika-parsers/pom.xml
tika-parsers/tika-parsers-extended/pom.xml
tika-parsers/tika-parsers-extended/tika-parsers-extended-integration-tests/pom.xml
tika-parsers/tika-parsers-extended/tika-parser-tagsoup-module/pom.xml
tika-parsers/tika-parsers-ml/pom.xml
tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/pom.xml
tika-parsers/tika-parsers-ml/tika-parser-nlp-module/pom.xml
tika-parsers/tika-parsers-ml/tika-age-recogniser/pom.xml
tika-parsers/tika-parsers-standard/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-digest-commons/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-jdbc-commons/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-mail-commons/pom.xml
tika-parsers/tika-parsers-standard/tika-parsers-standard-package/pom.xml
tika-pipes/pom.xml
tika-pipes/tika-pipes-reporters/pom.xml
tika-pipes/tika-fetchers/pom.xml
tika-pipes/tika-emitters/pom.xml
tika-pipes/tika-emitters/tika-emitter-jdbc/pom.xml
tika-pipes/tika-httpclient-commons/pom.xml
tika-pipes/tika-pipes-iterators/pom.xml
tika-integration-tests/pom.xml
tika-integration-tests/tika-pipes-solr-integration-tests/pom.xml
tika-integration-tests/tika-pipes-kafka-integration-tests/pom.xml
tika-integration-tests/tika-resource-loading-tests/pom.xml
tika-integration-tests/tika-pipes-s3-integration-tests/pom.xml
tika-integration-tests/tika-pipes-opensearch-integration-tests/pom.xml
tika-handlers/pom.xml
tika-handlers/tika-handler-boilerpipe/pom.xml
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770286#comment-17770286
]
Maxim Solodovnik commented on TIKA-4139:
Done TIKA-4147 :)
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769974#comment-17769974
]
Tim Allison commented on TIKA-4139:
---
>Shall I create new JIRA?
Yes, please!
>Maybe I can write some bash script
Ha, I can do that too. LOL
Relatedly, if you can find any other split packages that we should fix in 3.x,
please let us know.
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769876#comment-17769876
]
Maxim Solodovnik commented on TIKA-4139:
{quote}Any recs for detecting modules missing these and/or failing the build
for missing module names?{quote}
I'm not aware of such :(
Maybe I can write some bash script ... :)
I'm afraid I found one more issue with JPMS:
I'm having {{src/main/resources/org/apache/tika/mime/custom-mimetypes.xml}} (As
recommended here https://tika.apache.org/2.6.0/parser_guide.html)
But this immediately introduces {{org.apache.tika.mime}} package in our jar
(which is conflicting with same package in Tika ... :((( )
Maybe it worth to create some alternative way to implement this?
Like
* Something like MimeTypesFactory.CUSTOM_MIMES_SYS_PROP but pointing to
resource on classpath?
* Extendable static Map at MimeTypesFactory?
* Some sort of Service Locator?
* something better than above? :)))
Shall I create new JIRA?
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769247#comment-17769247
]
Tim Allison commented on TIKA-4139:
---
We do have set on 64 modules, but we're clearly
missing some, including tika-parsers-standard-package. Any recs for detecting
modules missing these and/or failing the build for missing module names?
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4139) Tika modules are not JPMS friendly
[
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768936#comment-17768936
]
Tim Allison commented on TIKA-4139:
---
Y. We should definitely do this. I thought we had at least on some modules.
> Tika modules are not JPMS friendly
> --
>
> Key: TIKA-4139
> URL: https://issues.apache.org/jira/browse/TIKA-4139
> Project: Tika
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Maxim Solodovnik
>Priority: Major
> Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package:
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
