[jira] [Commented] (TIKA-4201) Add hard limit to stream reading in IWorksParser#detectType
[ https://issues.apache.org/jira/browse/TIKA-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818916#comment-17818916 ] Hudson commented on TIKA-4201: -- FAILURE: Integrated in Jenkins build Tika ยป tika-main-jdk11 #1518 (See [https://ci-builds.apache.org/job/Tika/job/tika-main-jdk11/1518/]) TIKA-4201 -- add hard limit to IWorkPackageParser's detect (#1608) (github: [https://github.com/apache/tika/commit/fd44840a113b719872df1c453d46775efe850c60]) * (edit) tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-apple-module/src/main/java/org/apache/tika/parser/iwork/IWorkPackageParser.java > Add hard limit to stream reading in IWorksParser#detectType > --- > > Key: TIKA-4201 > URL: https://issues.apache.org/jira/browse/TIKA-4201 > Project: Tika > Issue Type: Bug >Reporter: Tim Allison >Priority: Minor > > TIKA-4199 showed us that we had been relying on hope that the detector would > only read a limited number of bytes when detecting in > IWorksParser#detectType. We should cache the first 1096 bytes, do the > detection, and then reset the wrapped archive stream. > We should not rely on hope. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4201) Add hard limit to stream reading in IWorksParser#detectType
[ https://issues.apache.org/jira/browse/TIKA-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818907#comment-17818907 ] ASF GitHub Bot commented on TIKA-4201: -- tballison merged PR #1608: URL: https://github.com/apache/tika/pull/1608 > Add hard limit to stream reading in IWorksParser#detectType > --- > > Key: TIKA-4201 > URL: https://issues.apache.org/jira/browse/TIKA-4201 > Project: Tika > Issue Type: Bug >Reporter: Tim Allison >Priority: Minor > > TIKA-4199 showed us that we had been relying on hope that the detector would > only read a limited number of bytes when detecting in > IWorksParser#detectType. We should cache the first 1096 bytes, do the > detection, and then reset the wrapped archive stream. > We should not rely on hope. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4201) Add hard limit to stream reading in IWorksParser#detectType
[ https://issues.apache.org/jira/browse/TIKA-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818880#comment-17818880 ] ASF GitHub Bot commented on TIKA-4201: -- tballison opened a new pull request, #1608: URL: https://github.com/apache/tika/pull/1608 Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated! Before opening the pull request, please verify that * there is an open issue on the [Tika issue tracker](https://issues.apache.org/jira/projects/TIKA) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes. * the issue ID (`TIKA-`) - is referenced in the title of the pull request - and placed in front of your commit messages surrounded by square brackets (`[TIKA-] Issue or pull request title`) * commits are squashed into a single one (or few commits for larger changes) * Tika is successfully built and unit tests pass by running `mvn clean test` * there should be no conflicts when merging the pull request branch into the *recent* `main` branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled `main` branch * if you add new module that downstream users will depend upon add it to relevant group in `tika-bom/pom.xml`. We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the [Tika mailing list](http://tika.apache.org/mail-lists.html). Thanks! > Add hard limit to stream reading in IWorksParser#detectType > --- > > Key: TIKA-4201 > URL: https://issues.apache.org/jira/browse/TIKA-4201 > Project: Tika > Issue Type: Bug >Reporter: Tim Allison >Priority: Minor > > TIKA-4199 showed us that we had been relying on hope that the detector would > only read a limited number of bytes when detecting in > IWorksParser#detectType. We should cache the first 1096 bytes, do the > detection, and then reset the wrapped archive stream. > We should not rely on hope. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4201) Add hard limit to stream reading in IWorksParser#detectType
[ https://issues.apache.org/jira/browse/TIKA-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818873#comment-17818873 ] Tilman Hausherr commented on TIKA-4201: --- Yeah, makes sense. > Add hard limit to stream reading in IWorksParser#detectType > --- > > Key: TIKA-4201 > URL: https://issues.apache.org/jira/browse/TIKA-4201 > Project: Tika > Issue Type: Bug >Reporter: Tim Allison >Priority: Minor > > TIKA-4199 showed us that we had been relying on hope that the detector would > only read a limited number of bytes when detecting in > IWorksParser#detectType. We should cache the first 1096 bytes, do the > detection, and then reset the wrapped archive stream. > We should not rely on hope. -- This message was sent by Atlassian Jira (v8.20.10#820010)