[GitHub] tinkerpop pull request #:
Github user analytically commented on the pull request: https://github.com/apache/tinkerpop/commit/1915fa531a5b3fb20b59d258313224864448ae0a#commitcomment-18135280 In gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Translator.java: In gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Translator.java on line 52: Should it not be spelled bytecode? No capital c? https://en.wikipedia.org/wiki/Bytecode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363185#comment-15363185 ] ASF GitHub Bot commented on TINKERPOP-1338: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/356 Fixed my Spark issue. Wanted to rebuild since giraph, hadoop, and spark have some dependency on groovy. Builds cleanly with mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false > Bump to Groovy 2.4.7 > > > Key: TINKERPOP-1338 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1338 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.0-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Provides a number of bug fixes: > http://groovy-lang.org/changelogs/changelog-2.4.7.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #356: TINKERPOP-1338 Bumped groovy to 2.4.7
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/356 Fixed my Spark issue. Wanted to rebuild since giraph, hadoop, and spark have some dependency on groovy. Builds cleanly with mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (TINKERPOP-1358) spark-gremlin tests require special setup
[ https://issues.apache.org/jira/browse/TINKERPOP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale resolved TINKERPOP-1358. Resolution: Not A Bug This appears to be a known issue with IPv6 on Spark/Hadoop. They don't officially support it. Workaround is to set SPARK_LOCAL_IP to an IPv4 address on the local host. > spark-gremlin tests require special setup > - > > Key: TINKERPOP-1358 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1358 > Project: TinkerPop > Issue Type: Test > Components: hadoop >Affects Versions: 3.2.0-incubating > Environment: Linux > No spark, hadoop installed, configured, or running. > No spark, hadoop env vars set. >Reporter: Robert Dale > Labels: spark > Fix For: 3.2.1 > > Attachments: console.txt > > > cd spark-gremlin; mvn clean install > Most tests fail with: > java.net.BindException: Cannot assign requested address: Service > 'sparkDriver' failed after 16 retries! > Eventually leads to resource starvation: OutOfMemoryError: unable to create > new native thread. Presumably because exceptions are not caught and > SparkContexts closed. > If tests require external server, perhaps they would be best served as > integration tests. Otherwise, there's some undocumented special sauce > missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1358) spark-gremlin tests require special setup
[ https://issues.apache.org/jira/browse/TINKERPOP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363000#comment-15363000 ] Robert Dale commented on TINKERPOP-1358: If I export SPARK_LOCAL_IP="127.0.0.1" then it all works. > spark-gremlin tests require special setup > - > > Key: TINKERPOP-1358 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1358 > Project: TinkerPop > Issue Type: Test > Components: hadoop >Affects Versions: 3.2.0-incubating > Environment: Linux > No spark, hadoop installed, configured, or running. > No spark, hadoop env vars set. >Reporter: Robert Dale > Labels: spark > Fix For: 3.2.1 > > Attachments: console.txt > > > cd spark-gremlin; mvn clean install > Most tests fail with: > java.net.BindException: Cannot assign requested address: Service > 'sparkDriver' failed after 16 retries! > Eventually leads to resource starvation: OutOfMemoryError: unable to create > new native thread. Presumably because exceptions are not caught and > SparkContexts closed. > If tests require external server, perhaps they would be best served as > integration tests. Otherwise, there's some undocumented special sauce > missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TINKERPOP-1358) spark-gremlin tests require special setup
[ https://issues.apache.org/jira/browse/TINKERPOP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale updated TINKERPOP-1358: --- Attachment: console.txt incubator-tinkerpop]$ git pull remote: Counting objects: 48, done. remote: Compressing objects: 100% (27/27), done. remote: Total 48 (delta 1), reused 0 (delta 0), pack-reused 0 Unpacking objects: 100% (48/48), done. >From https://github.com/apache/incubator-tinkerpop 539a4fc..756b280 TINKERPOP-1278 -> origin/TINKERPOP-1278 Already up-to-date. incubator-tinkerpop]$ git checkout -f master Already on 'master' Your branch is up-to-date with 'origin/master'. incubator-tinkerpop]$ mvn clean install >/tmp/console.txt 2>&1 > spark-gremlin tests require special setup > - > > Key: TINKERPOP-1358 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1358 > Project: TinkerPop > Issue Type: Test > Components: hadoop >Affects Versions: 3.2.0-incubating > Environment: Linux > No spark, hadoop installed, configured, or running. > No spark, hadoop env vars set. >Reporter: Robert Dale > Labels: spark > Fix For: 3.2.1 > > Attachments: console.txt > > > cd spark-gremlin; mvn clean install > Most tests fail with: > java.net.BindException: Cannot assign requested address: Service > 'sparkDriver' failed after 16 retries! > Eventually leads to resource starvation: OutOfMemoryError: unable to create > new native thread. Presumably because exceptions are not caught and > SparkContexts closed. > If tests require external server, perhaps they would be best served as > integration tests. Otherwise, there's some undocumented special sauce > missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1358) spark-gremlin tests require special setup
[ https://issues.apache.org/jira/browse/TINKERPOP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362982#comment-15362982 ] Robert Dale commented on TINKERPOP-1358: No, this happens all the time from root. Is it starting an embedded spark server? Do you have an idea what port it might be trying to bind to? Maybe I can see if there's something already listening there. Attached log. > spark-gremlin tests require special setup > - > > Key: TINKERPOP-1358 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1358 > Project: TinkerPop > Issue Type: Test > Components: hadoop >Affects Versions: 3.2.0-incubating > Environment: Linux > No spark, hadoop installed, configured, or running. > No spark, hadoop env vars set. >Reporter: Robert Dale > Labels: spark > Fix For: 3.2.1 > > > cd spark-gremlin; mvn clean install > Most tests fail with: > java.net.BindException: Cannot assign requested address: Service > 'sparkDriver' failed after 16 retries! > Eventually leads to resource starvation: OutOfMemoryError: unable to create > new native thread. Presumably because exceptions are not caught and > SparkContexts closed. > If tests require external server, perhaps they would be best served as > integration tests. Otherwise, there's some undocumented special sauce > missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1358) spark-gremlin tests require special setup
[ https://issues.apache.org/jira/browse/TINKERPOP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362890#comment-15362890 ] Marko A. Rodriguez commented on TINKERPOP-1358: --- Spark tests do not require a standalone SparkServer setup. Simple `mvn clean install` should work. Perhaps you didn't `mvn clean install` from root first as `SparkGraphComputer` relies on `HadoopGraph` and service loaders. ? > spark-gremlin tests require special setup > - > > Key: TINKERPOP-1358 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1358 > Project: TinkerPop > Issue Type: Test > Components: hadoop >Affects Versions: 3.2.0-incubating > Environment: Linux > No spark, hadoop installed, configured, or running. > No spark, hadoop env vars set. >Reporter: Robert Dale > Labels: spark > Fix For: 3.2.1 > > > cd spark-gremlin; mvn clean install > Most tests fail with: > java.net.BindException: Cannot assign requested address: Service > 'sparkDriver' failed after 16 retries! > Eventually leads to resource starvation: OutOfMemoryError: unable to create > new native thread. Presumably because exceptions are not caught and > SparkContexts closed. > If tests require external server, perhaps they would be best served as > integration tests. Otherwise, there's some undocumented special sauce > missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TINKERPOP-1358) spark-gremlin tests require special setup
Robert Dale created TINKERPOP-1358: -- Summary: spark-gremlin tests require special setup Key: TINKERPOP-1358 URL: https://issues.apache.org/jira/browse/TINKERPOP-1358 Project: TinkerPop Issue Type: Test Components: hadoop Affects Versions: 3.2.0-incubating Environment: Linux No spark, hadoop installed, configured, or running. No spark, hadoop env vars set. Reporter: Robert Dale Fix For: 3.2.1 cd spark-gremlin; mvn clean install Most tests fail with: java.net.BindException: Cannot assign requested address: Service 'sparkDriver' failed after 16 retries! Eventually leads to resource starvation: OutOfMemoryError: unable to create new native thread. Presumably because exceptions are not caught and SparkContexts closed. If tests require external server, perhaps they would be best served as integration tests. Otherwise, there's some undocumented special sauce missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362700#comment-15362700 ] ASF GitHub Bot commented on TINKERPOP-1338: --- GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/356 TINKERPOP-1338 Bumped groovy to 2.4.7 No new dependencies introduced. No other dependency versions changed. Successful build and verify with: mvn clean install -pl gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin-console,gremlin-server,gremlin-archetype && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j (excludes giraph-gremlin, hadoop-gremlin,spark-gremlin because I have separate issues building them) You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit fe37df2937a89c9f9d73bfbfc49f63c43a07986c Author: Robert Dale Date: 2016-07-05T16:03:38Z Bumped groovy to 2.4.7 > Bump to Groovy 2.4.7 > > > Key: TINKERPOP-1338 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1338 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.0-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Provides a number of bug fixes: > http://groovy-lang.org/changelogs/changelog-2.4.7.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop pull request #356: TINKERPOP-1338 Bumped groovy to 2.4.7
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/356 TINKERPOP-1338 Bumped groovy to 2.4.7 No new dependencies introduced. No other dependency versions changed. Successful build and verify with: mvn clean install -pl gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin-console,gremlin-server,gremlin-archetype && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j (excludes giraph-gremlin, hadoop-gremlin,spark-gremlin because I have separate issues building them) You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit fe37df2937a89c9f9d73bfbfc49f63c43a07986c Author: Robert Dale Date: 2016-07-05T16:03:38Z Bumped groovy to 2.4.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/351 This change is largely to help the consumption of GraphSON by non-JVM languages. Since I'm largely familiar with the behaviors of java based parsers and such, i'm not a good judge of that so i have to rely on @PommeVerte and others in this area. If the switch to Map is helpful then I think we should go that route. @newkek I would not be hasty in the change though. Perhaps we give it a day or so to think about to be sure that everyone is happy with that approach before you make the change and commit to it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362664#comment-15362664 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/351 This change is largely to help the consumption of GraphSON by non-JVM languages. Since I'm largely familiar with the behaviors of java based parsers and such, i'm not a good judge of that so i have to rely on @PommeVerte and others in this area. If the switch to Map is helpful then I think we should go that route. @newkek I would not be hasty in the change though. Perhaps we give it a day or so to think about to be sure that everyone is happy with that approach before you make the change and commit to it. > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362655#comment-15362655
]
ASF GitHub Bot commented on TINKERPOP-1274:
---
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Well, I agree we cannot prevent some parsers and drivers to read the whole
JSON content and check the created object only afterward. I would not recommend
it though, because it is not great for memory consumption, but it is maybe
something we have the opportunity to avoid only thanks to Jackson and some
libraries may not offer that capability. So I guess I'll switch to the
`{"@type":"...", "value": ...}` format instead of the current one. Does that
sound good @spmallette @PommeVerte ?
> GraphSON Version 2.0
>
>
> Key: TINKERPOP-1274
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
> Fix For: 3.2.1
>
>
> Develop a revised version of GraphSON that provides better support for
> non-JVM languages that consume it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Well, I agree we cannot prevent some parsers and drivers to read the whole
JSON content and check the created object only afterward. I would not recommend
it though, because it is not great for memory consumption, but it is maybe
something we have the opportunity to avoid only thanks to Jackson and some
libraries may not offer that capability. So I guess I'll switch to the
`{"@type":"...", "value": ...}` format instead of the current one. Does that
sound good @spmallette @PommeVerte ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TINKERPOP-786) Patterns for DSL Development
[ https://issues.apache.org/jira/browse/TINKERPOP-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362622#comment-15362622 ] Geoff Reedy commented on TINKERPOP-786: --- Unless I'm missing something, this approach doesn't enable extension of an existing traversal DSL. For my use case, and I imagine many others' as well, this ability is critical. > Patterns for DSL Development > > > Key: TINKERPOP-786 > URL: https://issues.apache.org/jira/browse/TINKERPOP-786 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.0.2-incubating >Reporter: stephen mallette >Assignee: Marko A. Rodriguez > Fix For: 3.2.1 > > > Develop and document the patterns for custom DSLs. The method previously > described and under consideration at 3.0.0 seems a bit cumbersome to deal > with. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362585#comment-15362585 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/351 Ok I thought The main point here was robustness in typing for non-java languages. Hence why I suggested even typing things like Int and using java classes. Honestly depending on how you compiled your PHP your basic JSON int will be converted to `Long`. And that's the case I was highlighting. It makes sense to ignore this if you're trying to reduce de payload but we'll still be lacking on the non-lossiness end. >As I see it for how I implemented the TypeDeserializer, it acts as a meta deserializer that will read the raw text JSON sequentially, so there's no chance there can be a mixup in the order You can't guaranty that the order would be maintained in some languages hence my previous comment. These languages will parse the JSON into `List` then check the list and Map along the lines of what I said in my previous post. It would be much more efficient to simply have JSON cast to `Map` and run a simple check on keys. > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/351 Ok I thought The main point here was robustness in typing for non-java languages. Hence why I suggested even typing things like Int and using java classes. Honestly depending on how you compiled your PHP your basic JSON int will be converted to `Long`. And that's the case I was highlighting. It makes sense to ignore this if you're trying to reduce de payload but we'll still be lacking on the non-lossiness end. >As I see it for how I implemented the TypeDeserializer, it acts as a meta deserializer that will read the raw text JSON sequentially, so there's no chance there can be a mixup in the order You can't guaranty that the order would be maintained in some languages hence my previous comment. These languages will parse the JSON into `List` then check the list and Map along the lines of what I said in my previous post. It would be much more efficient to simply have JSON cast to `Map` and run a simple check on keys. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (TINKERPOP-1357) Centrality Recipes should mention pageRank and OLAP.
Marko A. Rodriguez created TINKERPOP-1357: - Summary: Centrality Recipes should mention pageRank and OLAP. Key: TINKERPOP-1357 URL: https://issues.apache.org/jira/browse/TINKERPOP-1357 Project: TinkerPop Issue Type: Improvement Components: documentation, process Affects Versions: 3.2.0-incubating Reporter: Marko A. Rodriguez While we don't have many OLAP graph algorithm implemented off of `GraphTraversal`, we should really have `pageRank()` discussed in the centrality recipes section in the eigenvector section. http://tinkerpop.apache.org/docs/3.2.1-SNAPSHOT/recipes/#eigenvector-centrality -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1355) Design HasContainer for extension
[
https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362473#comment-15362473
]
ASF GitHub Bot commented on TINKERPOP-1355:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/355
Clean changes. VOTE +1.
> Design HasContainer for extension
> -
>
> Key: TINKERPOP-1355
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1355
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Bryn Cooke
>Priority: Critical
>
> Currently HasContainer is final. This means that Graph implementations cannot
> support their own type systems across the entire traversal.
> Given the traversal:
> g.V.has('foo', nonTinkerpopType).out('bar').has('foo', nonTinkerpopType)
> Say that the initial traversal g.V.has('foo', nonTinkerpopType) is dealt with
> via strategy, the non-Tinkerpop type can be dealt with. However the rest of
> the traversal is processed via the default Tinkerpop pipeline, and as such it
> doesn't know how to deal with type conversions/comparisons etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/355 Clean changes. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362336#comment-15362336 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/351 Just pushed the change for `@class` to `@type`. All tests pass. 'twas a 1 line fix, isn't that wonderful. > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/351 Just pushed the change for `@class` to `@type`. All tests pass. 'twas a 1 line fix, isn't that wonderful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
