Re: [DISCUSS] Code Review TINKERPOP-1278: gremlin-python

[Marko Rodriguez]

Hey GitHub, think you all hip and cool with your ‘social coding’-vibe. Making 
up fun little tag lines so the kids these days think they are part of something 
bigger. Changing the world are ya? How boutz you take this fatty rebase to yo 
face, you punk ass version control.

Marko.


> On Aug 26, 2016, at 6:55 PM, Stephen Mallette  wrote:
> 
> Merged TINKERPOP-1287 back to master and with that commit we bust past
> 1 commits!
> 
> On Fri, Aug 26, 2016 at 10:17 AM, Ted Wilmes  wrote:
> 
>> I was taking a look at the various parts and reading the docs, which as
>> usual were very comprehensive.  Really impressive work guys.  I think your
>> plan is a good one Stephen so +1 from me.
>> 
>> --Ted
>> 
>> On Fri, Aug 26, 2016 at 9:07 AM, Stephen Mallette 
>> wrote:
>> 
>>> There hasn't been much discussion here, so I'm assuming that there are no
>>> major objections to the work on TINKERPOP-1278. We've been generally
>>> discussing its ongoing development here on this list for a while now so I
>>> would think that everyone is up to speed on what's happening. I plan to
>> get
>>> this merged back to master in the next few hours or so and then will
>> focus
>>> on the Robert Dale PRs to get ready for code freeze.
>>> 
>>> Stephen
>>> 
>>> On Thu, Aug 25, 2016 at 7:56 AM, Marko Rodriguez 
>>> wrote:
>>> 
 Hi,
 
 Here is a terminal session showing off some chops.
 
https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934
>> <
 https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934>
 
 If you know Gremlin, you know Gremlin-Python.
 
 Marko.
 
 http://markorodriguez.com
 
 
 
> On Aug 24, 2016, at 8:24 PM, Stephen Mallette 
 wrote:
> 
> We basically have TINKERPOP-1278 ready for review. For those just
>>> tuning
> in, that is the gremlin-python branch which can be viewed here:
> 
> https://github.com/apache/tinkerpop/tree/TINKERPOP-1278
> 
> As I mentioned in a separate email, I don't think we should bother
>>> trying
> to issue a pull request for this as it is a massive body of work and
 GitHub
> tools really won't be useful here. Better to just check-out the
>> branch
 and
> examine what's going on. Let's use this thread to get our standard
> review/vote process done.
> 
> I don't plan on firing up a separate VOTE thread, so feel free to +1
>>> here
> on this one (we'll keep this informal unless someone has some
>>> objection).
> I'll be sure to reference this thread in the JIRA issue itself. I'll
>>> also
> note that while we typically hold votes open for 72 hours, that won't
>>> be
> the case here as this is not a typical vote thread - it is a code
>>> review
> and we have no such restrictions on time when it comes to those.
> 
> Note that we are positioning gremlin-python for 3.2.2 and that it is
 going
> to be considered a bit experimental so that we can get some feedback
>> on
> usage and perhaps root out some bugs in the process.There is still a
>>> fair
> bit of work to do to make this package awesome but as of right now,
>>> it's
> very usable.
> 
> Feel free to bring up problems you notice, but I think that reviewers
> should consider the big picture of this pull request rather than the
 minute
> details. Once we get things back on master we can make some
>> adjustments
 as
> needed, but I think it's basically time to bring that feature branch
>>> back
> home and get it merged.
> 
> One of the nice bits that came in recently from Marko to this branch
>>> were
> native python Vertex, Edge, etc. classes which lets users work
>> directly
> with graph elements (as opposed to Map). In that way, we get:
> 
 g.V()[0].toList()
> [v[1]]
 g.E()[0].toList()
> [e[7][1-knows->2]]
 g.V().properties('name')[0].toList()
> [vp[name->marko]]
 g.E().properties('weight')[0].toList()
> [p[weight->0.5]]
> 
> eh? eh? nice, right? Note that retrieval of sideEffects is working
>> well
 now
> too:
> 
 
> g.V().repeat(groupCount('m').by('name').both()).times(10).
 cap('m').next()
> {u'vadas': 2378L, u'marko': 5740L, u'josh': 5740L, u'lop': 5740L,
> u'ripple': 2378L, u'peter': 2378L}
 t = g.V().repeat(groupCount('m').by('name').both()).times(10).
 iterate()
 t.side_effects
> sideEffects[size:1]
 t.side_effects.keys()
> set([u'm'])
 t.side_effects['m']
> {u'lop': 5740L, u'marko': 5740L, u'vadas': 2378L, u'ripple': 2378L,
> u'peter': 2378L, u'josh': 5740L}
> 
> I think the interfaces and core classes are feeling pretty solid now
>>> for
> both java and python. We have a good body of test around much of
>> this,
 but
> 

Re: [DISCUSS] Code Review TINKERPOP-1278: gremlin-python

[Stephen Mallette]

Merged TINKERPOP-1287 back to master and with that commit we bust past
1 commits!

On Fri, Aug 26, 2016 at 10:17 AM, Ted Wilmes  wrote:

> I was taking a look at the various parts and reading the docs, which as
> usual were very comprehensive.  Really impressive work guys.  I think your
> plan is a good one Stephen so +1 from me.
>
> --Ted
>
> On Fri, Aug 26, 2016 at 9:07 AM, Stephen Mallette 
> wrote:
>
> > There hasn't been much discussion here, so I'm assuming that there are no
> > major objections to the work on TINKERPOP-1278. We've been generally
> > discussing its ongoing development here on this list for a while now so I
> > would think that everyone is up to speed on what's happening. I plan to
> get
> > this merged back to master in the next few hours or so and then will
> focus
> > on the Robert Dale PRs to get ready for code freeze.
> >
> > Stephen
> >
> > On Thu, Aug 25, 2016 at 7:56 AM, Marko Rodriguez 
> > wrote:
> >
> > > Hi,
> > >
> > > Here is a terminal session showing off some chops.
> > >
> > > https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934
> <
> > > https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934>
> > >
> > > If you know Gremlin, you know Gremlin-Python.
> > >
> > > Marko.
> > >
> > > http://markorodriguez.com
> > >
> > >
> > >
> > > > On Aug 24, 2016, at 8:24 PM, Stephen Mallette 
> > > wrote:
> > > >
> > > > We basically have TINKERPOP-1278 ready for review. For those just
> > tuning
> > > > in, that is the gremlin-python branch which can be viewed here:
> > > >
> > > > https://github.com/apache/tinkerpop/tree/TINKERPOP-1278
> > > >
> > > > As I mentioned in a separate email, I don't think we should bother
> > trying
> > > > to issue a pull request for this as it is a massive body of work and
> > > GitHub
> > > > tools really won't be useful here. Better to just check-out the
> branch
> > > and
> > > > examine what's going on. Let's use this thread to get our standard
> > > > review/vote process done.
> > > >
> > > > I don't plan on firing up a separate VOTE thread, so feel free to +1
> > here
> > > > on this one (we'll keep this informal unless someone has some
> > objection).
> > > > I'll be sure to reference this thread in the JIRA issue itself. I'll
> > also
> > > > note that while we typically hold votes open for 72 hours, that won't
> > be
> > > > the case here as this is not a typical vote thread - it is a code
> > review
> > > > and we have no such restrictions on time when it comes to those.
> > > >
> > > > Note that we are positioning gremlin-python for 3.2.2 and that it is
> > > going
> > > > to be considered a bit experimental so that we can get some feedback
> on
> > > > usage and perhaps root out some bugs in the process.There is still a
> > fair
> > > > bit of work to do to make this package awesome but as of right now,
> > it's
> > > > very usable.
> > > >
> > > > Feel free to bring up problems you notice, but I think that reviewers
> > > > should consider the big picture of this pull request rather than the
> > > minute
> > > > details. Once we get things back on master we can make some
> adjustments
> > > as
> > > > needed, but I think it's basically time to bring that feature branch
> > back
> > > > home and get it merged.
> > > >
> > > > One of the nice bits that came in recently from Marko to this branch
> > were
> > > > native python Vertex, Edge, etc. classes which lets users work
> directly
> > > > with graph elements (as opposed to Map). In that way, we get:
> > > >
> > >  g.V()[0].toList()
> > > > [v[1]]
> > >  g.E()[0].toList()
> > > > [e[7][1-knows->2]]
> > >  g.V().properties('name')[0].toList()
> > > > [vp[name->marko]]
> > >  g.E().properties('weight')[0].toList()
> > > > [p[weight->0.5]]
> > > >
> > > > eh? eh? nice, right? Note that retrieval of sideEffects is working
> well
> > > now
> > > > too:
> > > >
> > > 
> > > > g.V().repeat(groupCount('m').by('name').both()).times(10).
> > > cap('m').next()
> > > > {u'vadas': 2378L, u'marko': 5740L, u'josh': 5740L, u'lop': 5740L,
> > > > u'ripple': 2378L, u'peter': 2378L}
> > >  t = g.V().repeat(groupCount('m').by('name').both()).times(10).
> > > iterate()
> > >  t.side_effects
> > > > sideEffects[size:1]
> > >  t.side_effects.keys()
> > > > set([u'm'])
> > >  t.side_effects['m']
> > > > {u'lop': 5740L, u'marko': 5740L, u'vadas': 2378L, u'ripple': 2378L,
> > > > u'peter': 2378L, u'josh': 5740L}
> > > >
> > > > I think the interfaces and core classes are feeling pretty solid now
> > for
> > > > both java and python. We have a good body of test around much of
> this,
> > > but
> > > > have only been able to test native python connectivity to Gremlin
> > Server
> > > > stuff manually. We don't have automated tests for that, but there are
> > > many
> > > > automated tests that hit the key aspects of the core of all this
> > > processing
> > > > so 

[jira] [Commented] (TINKERPOP-1418) CoreTraversalTests depend on missing functionality

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439943#comment-15439943
 ] 

stephen mallette commented on TINKERPOP-1418:
-

i stared at the commit you referenced for a while, but i don't seem to remember 
why it was necessary. i think it's one of those things where there was a good 
reason, but it's just been forgotten.dah

> CoreTraversalTests depend on missing functionality
> --
>
> Key: TINKERPOP-1418
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1418
> Project: TinkerPop
>  Issue Type: Bug
>  Components: structure, test-suite
>Affects Versions: 3.2.1
>Reporter: Benjamin Anderson
>Priority: Minor
>
> The {{shouldLoadVerticesViaVertices}} and {{shouldLoadEdgesViaEdges}} tests 
> in 
> [CoreTraversalTests.java|https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java#L94-L110]
>  appear to depend on unspecified functionality.
> The comment for the {{.vertices}} method in the Graph structure class does 
> not specify that it should accept Vertex objects (except in [one odd 
> place|https://github.com/apache/tinkerpop/blob/d696b38ab774dd46c6723d5c59aa7329f96b41e1/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/Graph.java#L219])
>  - as an implementor it reads as if it's intended to be called only with 
> identifiers.
> [When these two tests were 
> added|https://github.com/apache/tinkerpop/commit/da30a525ef626b8f13ffba0b7abada89b68eff6b]
>  some functionality was included in GraphStep to handle mapping Vertex 
> objects to their IDs; this functionality was [soon 
> removed|https://github.com/apache/tinkerpop/commit/59028c8ad18f23609e31220a59717a2bc05b78af],
>  however, and added to TinkerGraph. Incidentally, Titan [also implements the 
> same 
> functionality|https://github.com/thinkaurelius/titan/blob/titan10/titan-core/src/main/java/com/thinkaurelius/titan/graphdb/tinkerpop/TitanBlueprintsTransaction.java#L113-L141].
> Is {{Graph.vertices(Object...)}} intended to gracefully handle an array of 
> Vertex elements as well as an array of Vertex identifiers? If so, then it 
> appears that the documentation in Graph.java needs some reworking. It'd also 
> perhaps be unfortunate, stylistically, to add a third behavior to that 
> method. If it's not intended to support that call, then it seems that these 
> two methods (and perhaps others?) should be removed from the test suite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/390
  
I think I understand the Tree issue better (not the solution, just the 
context of the PR). Merged the second commit as well. Made note of the 
limitation to deal with later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1285) Gremline console does not differentiate between multi-line and single-line input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439923#comment-15439923
 ] 

ASF GitHub Bot commented on TINKERPOP-1285:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/385
  
feel free to move ahead with the rebase and i can then get this merged. I 
think that the zeros can go now that we have the dots which i like the more 
each time i see it. thanks - this was a really nice contribution.


> Gremline console does not differentiate between multi-line and single-line 
> input
> 
>
> Key: TINKERPOP-1285
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.0-incubating
>Reporter: Rocco Varela
>Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple 
> lines the gremlin console does not provide the user with any indication that 
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are 
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/385
  
feel free to move ahead with the rebase and i can then get this merged. I 
think that the zeros can go now that we have the dots which i like the more 
each time i see it. thanks - this was a really nice contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1285) Gremline console does not differentiate between multi-line and single-line input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439899#comment-15439899
 ] 

ASF GitHub Bot commented on TINKERPOP-1285:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/385
  
@spmallette I can rebase on latest master. Just let me know.  Do you think 
there is any point in keeping the leading zeroes?
```
gremlin> 1+
..1> 2+
..2> 3+
..3> 4
```

Alt prompt:
```
g> 1+
1> 2+
2> 3+
3> 4
==>10

```


> Gremline console does not differentiate between multi-line and single-line 
> input
> 
>
> Key: TINKERPOP-1285
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.0-incubating
>Reporter: Rocco Varela
>Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple 
> lines the gremlin console does not provide the user with any indication that 
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are 
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/385
  
@spmallette I can rebase on latest master. Just let me know.  Do you think 
there is any point in keeping the leading zeroes?
```
gremlin> 1+
..1> 2+
..2> 3+
..3> 4
```

Alt prompt:
```
g> 1+
1> 2+
2> 3+
3> 4
==>10

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/390
  
i merged the first of these two commits via cherry pick. let's sit on the 
other one for a bit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (TINKERPOP-1037) Gremlin shell output coloring

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1037.
---
   Resolution: Done
 Assignee: stephen mallette
Fix Version/s: 3.2.2

> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Assignee: stephen mallette
>Priority: Trivial
> Fix For: 3.2.2
>
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439751#comment-15439751
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/384


> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/384


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Code Review TINKERPOP-1278: gremlin-python

[Ted Wilmes]

I was taking a look at the various parts and reading the docs, which as
usual were very comprehensive.  Really impressive work guys.  I think your
plan is a good one Stephen so +1 from me.

--Ted

On Fri, Aug 26, 2016 at 9:07 AM, Stephen Mallette 
wrote:

> There hasn't been much discussion here, so I'm assuming that there are no
> major objections to the work on TINKERPOP-1278. We've been generally
> discussing its ongoing development here on this list for a while now so I
> would think that everyone is up to speed on what's happening. I plan to get
> this merged back to master in the next few hours or so and then will focus
> on the Robert Dale PRs to get ready for code freeze.
>
> Stephen
>
> On Thu, Aug 25, 2016 at 7:56 AM, Marko Rodriguez 
> wrote:
>
> > Hi,
> >
> > Here is a terminal session showing off some chops.
> >
> > https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934 <
> > https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934>
> >
> > If you know Gremlin, you know Gremlin-Python.
> >
> > Marko.
> >
> > http://markorodriguez.com
> >
> >
> >
> > > On Aug 24, 2016, at 8:24 PM, Stephen Mallette 
> > wrote:
> > >
> > > We basically have TINKERPOP-1278 ready for review. For those just
> tuning
> > > in, that is the gremlin-python branch which can be viewed here:
> > >
> > > https://github.com/apache/tinkerpop/tree/TINKERPOP-1278
> > >
> > > As I mentioned in a separate email, I don't think we should bother
> trying
> > > to issue a pull request for this as it is a massive body of work and
> > GitHub
> > > tools really won't be useful here. Better to just check-out the branch
> > and
> > > examine what's going on. Let's use this thread to get our standard
> > > review/vote process done.
> > >
> > > I don't plan on firing up a separate VOTE thread, so feel free to +1
> here
> > > on this one (we'll keep this informal unless someone has some
> objection).
> > > I'll be sure to reference this thread in the JIRA issue itself. I'll
> also
> > > note that while we typically hold votes open for 72 hours, that won't
> be
> > > the case here as this is not a typical vote thread - it is a code
> review
> > > and we have no such restrictions on time when it comes to those.
> > >
> > > Note that we are positioning gremlin-python for 3.2.2 and that it is
> > going
> > > to be considered a bit experimental so that we can get some feedback on
> > > usage and perhaps root out some bugs in the process.There is still a
> fair
> > > bit of work to do to make this package awesome but as of right now,
> it's
> > > very usable.
> > >
> > > Feel free to bring up problems you notice, but I think that reviewers
> > > should consider the big picture of this pull request rather than the
> > minute
> > > details. Once we get things back on master we can make some adjustments
> > as
> > > needed, but I think it's basically time to bring that feature branch
> back
> > > home and get it merged.
> > >
> > > One of the nice bits that came in recently from Marko to this branch
> were
> > > native python Vertex, Edge, etc. classes which lets users work directly
> > > with graph elements (as opposed to Map). In that way, we get:
> > >
> >  g.V()[0].toList()
> > > [v[1]]
> >  g.E()[0].toList()
> > > [e[7][1-knows->2]]
> >  g.V().properties('name')[0].toList()
> > > [vp[name->marko]]
> >  g.E().properties('weight')[0].toList()
> > > [p[weight->0.5]]
> > >
> > > eh? eh? nice, right? Note that retrieval of sideEffects is working well
> > now
> > > too:
> > >
> > 
> > > g.V().repeat(groupCount('m').by('name').both()).times(10).
> > cap('m').next()
> > > {u'vadas': 2378L, u'marko': 5740L, u'josh': 5740L, u'lop': 5740L,
> > > u'ripple': 2378L, u'peter': 2378L}
> >  t = g.V().repeat(groupCount('m').by('name').both()).times(10).
> > iterate()
> >  t.side_effects
> > > sideEffects[size:1]
> >  t.side_effects.keys()
> > > set([u'm'])
> >  t.side_effects['m']
> > > {u'lop': 5740L, u'marko': 5740L, u'vadas': 2378L, u'ripple': 2378L,
> > > u'peter': 2378L, u'josh': 5740L}
> > >
> > > I think the interfaces and core classes are feeling pretty solid now
> for
> > > both java and python. We have a good body of test around much of this,
> > but
> > > have only been able to test native python connectivity to Gremlin
> Server
> > > stuff manually. We don't have automated tests for that, but there are
> > many
> > > automated tests that hit the key aspects of the core of all this
> > processing
> > > so in that sense there is some solid test coverage in place. As of
> > > yesterday, full integration tests were passing on this branch which
> > > includes GraphSON 2.0. I don't believe that much was done today that
> > could
> > > have affected that outcome.
> > >
> > > The documentation has been updated but will likely need some more work.
> > We
> > > can do a lot of that during code freeze week. Here's some links to the
> > > 

Re: [DISCUSS] Code Review TINKERPOP-1278: gremlin-python

[Stephen Mallette]

There hasn't been much discussion here, so I'm assuming that there are no
major objections to the work on TINKERPOP-1278. We've been generally
discussing its ongoing development here on this list for a while now so I
would think that everyone is up to speed on what's happening. I plan to get
this merged back to master in the next few hours or so and then will focus
on the Robert Dale PRs to get ready for code freeze.

Stephen

On Thu, Aug 25, 2016 at 7:56 AM, Marko Rodriguez 
wrote:

> Hi,
>
> Here is a terminal session showing off some chops.
>
> https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934 <
> https://gist.github.com/okram/0d40c78d7df14c0ca3ad8f3f5c547934>
>
> If you know Gremlin, you know Gremlin-Python.
>
> Marko.
>
> http://markorodriguez.com
>
>
>
> > On Aug 24, 2016, at 8:24 PM, Stephen Mallette 
> wrote:
> >
> > We basically have TINKERPOP-1278 ready for review. For those just tuning
> > in, that is the gremlin-python branch which can be viewed here:
> >
> > https://github.com/apache/tinkerpop/tree/TINKERPOP-1278
> >
> > As I mentioned in a separate email, I don't think we should bother trying
> > to issue a pull request for this as it is a massive body of work and
> GitHub
> > tools really won't be useful here. Better to just check-out the branch
> and
> > examine what's going on. Let's use this thread to get our standard
> > review/vote process done.
> >
> > I don't plan on firing up a separate VOTE thread, so feel free to +1 here
> > on this one (we'll keep this informal unless someone has some objection).
> > I'll be sure to reference this thread in the JIRA issue itself. I'll also
> > note that while we typically hold votes open for 72 hours, that won't be
> > the case here as this is not a typical vote thread - it is a code review
> > and we have no such restrictions on time when it comes to those.
> >
> > Note that we are positioning gremlin-python for 3.2.2 and that it is
> going
> > to be considered a bit experimental so that we can get some feedback on
> > usage and perhaps root out some bugs in the process.There is still a fair
> > bit of work to do to make this package awesome but as of right now, it's
> > very usable.
> >
> > Feel free to bring up problems you notice, but I think that reviewers
> > should consider the big picture of this pull request rather than the
> minute
> > details. Once we get things back on master we can make some adjustments
> as
> > needed, but I think it's basically time to bring that feature branch back
> > home and get it merged.
> >
> > One of the nice bits that came in recently from Marko to this branch were
> > native python Vertex, Edge, etc. classes which lets users work directly
> > with graph elements (as opposed to Map). In that way, we get:
> >
>  g.V()[0].toList()
> > [v[1]]
>  g.E()[0].toList()
> > [e[7][1-knows->2]]
>  g.V().properties('name')[0].toList()
> > [vp[name->marko]]
>  g.E().properties('weight')[0].toList()
> > [p[weight->0.5]]
> >
> > eh? eh? nice, right? Note that retrieval of sideEffects is working well
> now
> > too:
> >
> 
> > g.V().repeat(groupCount('m').by('name').both()).times(10).
> cap('m').next()
> > {u'vadas': 2378L, u'marko': 5740L, u'josh': 5740L, u'lop': 5740L,
> > u'ripple': 2378L, u'peter': 2378L}
>  t = g.V().repeat(groupCount('m').by('name').both()).times(10).
> iterate()
>  t.side_effects
> > sideEffects[size:1]
>  t.side_effects.keys()
> > set([u'm'])
>  t.side_effects['m']
> > {u'lop': 5740L, u'marko': 5740L, u'vadas': 2378L, u'ripple': 2378L,
> > u'peter': 2378L, u'josh': 5740L}
> >
> > I think the interfaces and core classes are feeling pretty solid now for
> > both java and python. We have a good body of test around much of this,
> but
> > have only been able to test native python connectivity to Gremlin Server
> > stuff manually. We don't have automated tests for that, but there are
> many
> > automated tests that hit the key aspects of the core of all this
> processing
> > so in that sense there is some solid test coverage in place. As of
> > yesterday, full integration tests were passing on this branch which
> > includes GraphSON 2.0. I don't believe that much was done today that
> could
> > have affected that outcome.
> >
> > The documentation has been updated but will likely need some more work.
> We
> > can do a lot of that during code freeze week. Here's some links to the
> > newest bits:
> >
> > http://tinkerpop.apache.org/docs/3.2.2-SNAPSHOT/reference/
> #connecting-via-remotegraph
> >
> > http://tinkerpop.apache.org/docs/3.2.2-SNAPSHOT/reference/
> #gremlin-variants
> >
> > Marko, please feel free to follow up with finer points that I've missed -
> > my mind is a bit spent on things at this point but wanted this email out
> > tonight. Anyway, at this point, I'm going to start this off with a +1 and
> > say this is ready to merge back to master.
>
>