Re: SQL-Gremlin logo?

2016-09-15 Thread Ted Wilmes
Glorious, thanks Marko.

--Ted

On Thu, Sep 15, 2016 at 1:41 PM, Marko Rodriguez 
wrote:

> Hey Ted,
>
> Here you go.
>
> Enjoy,
> Marko.
>
>
> http://markorodriguez.com
>
>
>
> On Sep 14, 2016, at 7:14 PM, Ted Wilmes  wrote:
>
> The logo looks great and the bio is spot-on.  I love the "SELECT V FROM
> G".  My only request would be to remove the wavy-grid part on the right
> side of the logo since it is part of the Microsoft SQL Server logo, just to
> remove any confusion over whether there is some sort of relationship
> between it and sql-gremlin.
>
> I'll get this added to the sql-gremlin repo and get things switched over
> to use Gremlin bytecode.
>
> Thanks Marko,
> Ted
>
> On Wed, Sep 14, 2016 at 11:24 AM, Marko Rodriguez 
> wrote:
>
>> Hi Ted,
>>
>> Please see the attached logo. Note that I also added it to the
>> providers.html page. Any tweaks on the logo or “bio”, please advise.
>>
>> http://tinkerpop.apache.org/providers.html
>>
>> Thanks,
>> Marko.
>>
>> http://markorodriguez.com
>>
>>
>> On Sep 13, 2016, at 8:14 PM, Ted Wilmes  wrote:
>>
>> I do not have one so that'd be awesome if you made one.  Thanks for the
>> offer.
>>
>> --Ted
>>
>> On Tue, Sep 13, 2016, 7:07 PM Marko Rodriguez 
>> wrote:
>>
>> Hi,
>>
>> I’ve been tweaking up our providers.html page:
>> http://tinkerpop.apache.org/providers.html <
>> http://tinkerpop.apache.org/providers.html>
>>
>> @Ted: Do you have an SQL-Gremlin logo? If not, would you like me to make
>> you one? From there, we can add it to the listing at the bottom of this
>> page.
>>
>> Thoughts?,
>> Marko.
>>
>> http://markorodriguez.com
>>
>>
>>
>>
>>
>>
>
>


[jira] [Closed] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1409.
---
   Resolution: Done
 Assignee: stephen mallette
Fix Version/s: 3.2.3

Most of this work went in on 3.2.2 - finished up tiny little bit for 3.2.3, but 
for purpose of fix version i'll just leave it at that.

> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>Assignee: stephen mallette
> Fix For: 3.2.3
>
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494788#comment-15494788
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/422


> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #422: TINKERPOP-1409 Print no result line if empty.re...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494766#comment-15494766
 ] 

ASF GitHub Bot commented on TINKERPOP-1444:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/411
  
All good, here's the missing

VOTE: +1


> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.3
>
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #411: TINKERPOP-1444: Benchmark bytecode->Traversal creation...

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/411
  
All good, here's the missing

VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Ruminations on SparkGraphComputer Part 666

2016-09-15 Thread Marko Rodriguez
Hello,

Its about that time again. Spark 2.0 was released recently and, with the help 
of Chen Xin Yu, TINKERPOP-1389 has been updated to support Spark 2.0. How does 
it perform? A little faster here and a little slower there. Note that this work 
will go into TinkerPop 3.3.0. Currently, we don’t have a branch for TinkerPop 
3.3.0 development work and until then, this will remain in TINKERPOP-1389. 
Finally, note that there have been no changes to SparkGraphComputer besides 
tweaks to get alignment with Spark’s API and serialization updates.

g.V().count() -- answer 12500 (125 million vertices)
- TinkerPop 3.0.0.MX: 2.5 hours
- TinkerPop 3.0.0:  1.5 hours
- TinkerPop 3.1.1:  23 minutes
- TinkerPop 3.2.0:  6.8 minutes (Spark 1.5.2)
- TinkerPop 3.2.0:  5.5 minutes (Spark 1.6.1)
- TinkerPop 3.2.1:  2.2 minutes (Spark 1.6.1)
- TinkerPop 3.3.x:  1.6 minutes (Spark 2.2.0)

g.V().out().count() -- answer 2586147869 (2.5 billion length-1 paths (i.e. 
edges))
- TinkerPop 3.0.0.MX: unknown
- TinkerPop 3.0.0:  2.5 hours
- TinkerPop 3.1.1:  1.1 hours
- TinkerPop 3.2.0:  13 minutes (Spark 1.5.2)
- TinkerPop 3.2.0:  12 minutes (Spark 1.6.1)
- TinkerPop 3.2.1:  2.4 minutes (Spark 1.6.1)
- TinkerPop 3.3.x:  2.1 minutes (Spark 2.0.0)

g.V().out().out().count() -- answer 640528666156 (640 billion length-2 paths)
- TinkerPop 3.2.0:  55 minutes (Spark 1.5.2)
- TinkerPop 3.2.0:  50 minutes (Spark 1.6.1)
- TinkerPop 3.2.1:  37 minutes (Spark 1.6.1)
- TinkerPop 3.3.x:  40 minutes (Spark 2.0.0)

g.V().out().out().out().count() -- answer 215664338057221 (215 trillion length 
3-paths)
- TinkerPop 3.0.0.MX: 12.8 hours
- TinkerPop 3.0.0:  8.6 hours
- TinkerPop 3.1.1:  2.4 hours
- TinkerPop 3.2.0:  1.6 hours (Spark 1.5.2)
- TinkerPop 3.2.0:  1.5 hours (Spark 1.6.1)
- TinkerPop 3.2.1:  1.1 hours (Spark 1.6.1)
- TinkerPop 3.3.x:  1.3 hours (Spark 2.0.0)

g.V().out().out().out().out().count() -- answer 83841426570464575 (83 
quadrillion length 4-paths)
- TinkerPop 3.2.0:  2.1 hours (Spark 1.6.1)
- TinkerPop 3.2.1:  1.7 hours (Spark 1.6.1)
- TinkerPop 3.3.x:  2.0 hours (Spark 2.0.0)

g.V().out().out().out().out().out().count() -- answer -2280190503167902456 !! I 
blew the long space -- 64-bit overflow.
- TinkerPop 3.2.0:  2.8 hours (Spark 1.6.1)
- TinkerPop 3.2.1:  2.2 hours (Spark 1.6.1)
- TinkerPop 3.3.x:  2.6 hours (Spark 2.0.0)

g.V().group().by(outE().count()).by(count()). 
- TinkerPop 3.2.0:  12 minutes (Spark 1.6.1)
- TinkerPop 3.2.1:  2.4 minutes (Spark 1.6.1)
- TinkerPop 3.3.x:  3.1 minutes (Spark 2.0.0)

g.V().groupCount().by(outE().count())
- TinkerPop 3.2.0:  12 minutes (Spark 1.6.1)
- TinkerPop 3.2.1:  2.7 minutes (Spark 1.6.1)
- TinkerPop 3.3.x:  2.2 minutes (Spark 2.0.0)

Take care,
Marko.

http://markorodriguez.com





[jira] [Commented] (TINKERPOP-1442) Killing session should make better attempt to cleanup

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494443#comment-15494443
 ] 

ASF GitHub Bot commented on TINKERPOP-1442:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/413
  
I'm just going to throw my $0.02 out there. Maybe I don't understand the 
use case, but this seems strange and unexpected to me.  I don't understand why 
or how a completely separate client would affect another.  Isn't one of the 
reasons for using sessions is that a client can come in and out while retaining 
state?  How would a client safely disconnect and reconnect later without 
killing the session and other clients?



> Killing session should make better attempt to cleanup
> -
>
> Key: TINKERPOP-1442
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1442
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.1.4
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.1.5
>
>
> When a session is killed it tries to rollback transactions prior to ending 
> the session. If there is a long-run script (or perhaps a queue of jobs) then 
> this close job just gets added to the queue. If that rollback job never 
> executes then the transaction gets orphaned. 
> Graph implementations tend to have their own methods for cleaning up these 
> lingering transactions, but it would be better if the shutdown could occur in 
> an orderly fashion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #413: TINKERPOP-1442 Improved session cleanup on client clos...

2016-09-15 Thread robertdale
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/413
  
I'm just going to throw my $0.02 out there. Maybe I don't understand the 
use case, but this seems strange and unexpected to me.  I don't understand why 
or how a completely separate client would affect another.  Isn't one of the 
reasons for using sessions is that a client can come in and out while retaining 
state?  How would a client safely disconnect and reconnect later without 
killing the session and other clients?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1442) Killing session should make better attempt to cleanup

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494421#comment-15494421
 ] 

ASF GitHub Bot commented on TINKERPOP-1442:
---

Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/412
  
This branch builds successfully using mvn clean install. VOTE +1


> Killing session should make better attempt to cleanup
> -
>
> Key: TINKERPOP-1442
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1442
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.1.4
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.1.5
>
>
> When a session is killed it tries to rollback transactions prior to ending 
> the session. If there is a long-run script (or perhaps a queue of jobs) then 
> this close job just gets added to the queue. If that rollback job never 
> executes then the transaction gets orphaned. 
> Graph implementations tend to have their own methods for cleaning up these 
> lingering transactions, but it would be better if the shutdown could occur in 
> an orderly fashion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #413: TINKERPOP-1442 Improved session cleanup on client clos...

2016-09-15 Thread davebshow
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/413
  
Stop accepting transactions after a close makes sense to me. This branch 
builds successfully using mvn clean install. VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1442) Killing session should make better attempt to cleanup

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494420#comment-15494420
 ] 

ASF GitHub Bot commented on TINKERPOP-1442:
---

Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/413
  
Stop accepting transactions after a close makes sense to me. This branch 
builds successfully using mvn clean install. VOTE +1


> Killing session should make better attempt to cleanup
> -
>
> Key: TINKERPOP-1442
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1442
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.1.4
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.1.5
>
>
> When a session is killed it tries to rollback transactions prior to ending 
> the session. If there is a long-run script (or perhaps a queue of jobs) then 
> this close job just gets added to the queue. If that rollback job never 
> executes then the transaction gets orphaned. 
> Graph implementations tend to have their own methods for cleaning up these 
> lingering transactions, but it would be better if the shutdown could occur in 
> an orderly fashion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #412: TINKERPOP-1442 Improved session cleanup on client clos...

2016-09-15 Thread davebshow
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/412
  
This branch builds successfully using mvn clean install. VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494383#comment-15494383
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
I ended up naming it `result.indicator.null` as "result." was the prefix 
for other similar preferences:

```text
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
==>null
gremlin> :set result.indicator.null nil
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
==>nil
gremlin> :set result.indicator.null ""
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
gremlin> 
```


> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

2016-09-15 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
I ended up naming it `result.indicator.null` as "result." was the prefix 
for other similar preferences:

```text
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
==>null
gremlin> :set result.indicator.null nil
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
==>nil
gremlin> :set result.indicator.null ""
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
gremlin> 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494348#comment-15494348
 ] 

Marko A. Rodriguez commented on TINKERPOP-1444:
---

Dah. I thought @dkuppitz already VOTE'd +1. Thus, we only have 2 +1s. If 
someone thinks that we should revert the merge, please say so, else, assuming 
all is good.

> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.3
>
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494347#comment-15494347
 ] 

ASF GitHub Bot commented on TINKERPOP-1444:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/411
  
VOTE +1


> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.3
>
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #411: TINKERPOP-1444: Benchmark bytecode->Traversal creation...

2016-09-15 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/411
  
VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread Marko A. Rodriguez (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez reassigned TINKERPOP-1444:
-

Assignee: Marko A. Rodriguez

> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.3
>
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread Marko A. Rodriguez (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez closed TINKERPOP-1444.
-
   Resolution: Fixed
Fix Version/s: 3.2.3

> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.3
>
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [GitHub] tinkerpop issue #414: Release name generator

2016-09-15 Thread Marko Rodriguez
You should add some of the output so people can see what it generates without 
having to run the code.

Marko.



> On Sep 15, 2016, at 1:29 PM, robertdale  wrote:
> 
> Github user robertdale commented on the issue:
> 
>https://github.com/apache/tinkerpop/pull/414
> 
>Inaugurated my blog and forever immortalized at 
> https://robertdale.github.io/2016/09/15/gremlin-create-gremlin-release-name.html
> 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



[jira] [Commented] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494339#comment-15494339
 ] 

ASF GitHub Bot commented on TINKERPOP-1444:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/411


> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #411: TINKERPOP-1444: Benchmark bytecode->Traversal c...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/411


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #414: Release name generator

2016-09-15 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/414
  
You should post a link to that on gremlin-users :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #414: Release name generator

2016-09-15 Thread robertdale
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/414
  
Inaugurated my blog and forever immortalized at 
https://robertdale.github.io/2016/09/15/gremlin-create-gremlin-release-name.html



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #414: Release name generator

2016-09-15 Thread robertdale
Github user robertdale closed the pull request at:

https://github.com/apache/tinkerpop/pull/414


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494199#comment-15494199
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/424

TINKERPOP-1451 TinkerGraph persistence cannot handle a single file name as 
the graph location

https://issues.apache.org/jira/browse/TINKERPOP-1451

This is all good now:

```text
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test4.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
```

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #424


commit 371bb39c5c23bb766f391974ea024219a5941fe8
Author: Stephen Mallette 
Date:   2016-09-15T17:51:33Z

TinkerGraph's would not save on close()

if the path was just a file name. Tested "just a file name" manually and 
added a test for relative paths - didn't want to generate test data outside of 
our test directories. TINKERPOP-1451

commit 356b7c81a9517c89204efb1f0e0e30037bd04ae0
Author: Stephen Mallette 
Date:   2016-09-15T18:08:31Z

Added a test for persisting multi-properties in TinkerGraph

Changed the test back to using a relative path in the data directory - 
didn't like it polluting the source control directories.




> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.

[GitHub] tinkerpop pull request #424: TINKERPOP-1451 TinkerGraph persistence cannot h...

2016-09-15 Thread spmallette
GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/424

TINKERPOP-1451 TinkerGraph persistence cannot handle a single file name as 
the graph location

https://issues.apache.org/jira/browse/TINKERPOP-1451

This is all good now:

```text
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test4.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
```

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #424


commit 371bb39c5c23bb766f391974ea024219a5941fe8
Author: Stephen Mallette 
Date:   2016-09-15T17:51:33Z

TinkerGraph's would not save on close()

if the path was just a file name. Tested "just a file name" manually and 
added a test for relative paths - didn't want to generate test data outside of 
our test directories. TINKERPOP-1451

commit 356b7c81a9517c89204efb1f0e0e30037bd04ae0
Author: Stephen Mallette 
Date:   2016-09-15T18:08:31Z

Added a test for persisting multi-properties in TinkerGraph

Changed the test back to using a relative path in the data directory - 
didn't like it polluting the source control directories.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494194#comment-15494194
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

GitHub user spmallette reopened a pull request:

https://github.com/apache/tinkerpop/pull/423

TINKERPOP-1451 TinkerGraph persistence cannot handle a single file name as 
the graph location

https://issues.apache.org/jira/browse/TINKERPOP-1451

works nicely now:

```text
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test4.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
```

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit e7e748151da513850567395d376e02e4cda864a2
Author: Daniel Kuppitz 
Date:   2016-09-15T18:08:39Z

Merge branch 'TINKERPOP-1391' into tp31

commit 371bb39c5c23bb766f391974ea024219a5941fe8
Author: Stephen Mallette 
Date:   2016-09-15T17:51:33Z

TinkerGraph's would not save on close()

if the path was just a file name. Tested "just a file name" manually and 
added a test for relative paths - didn't want to generate test data outside of 
our test directories. TINKERPOP-1451

commit 356b7c81a9517c89204efb1f0e0e30037bd04ae0
Author: Stephen Mallette 
Date:   2016-09-15T18:08:31Z

Added a test for persisting multi-properties in TinkerGraph

Changed the test back to using a relative path in the data directory - 
didn't like it polluting the source control directories.




> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_eval

[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494193#comment-15494193
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

Github user spmallette closed the pull request at:

https://github.com/apache/tinkerpop/pull/423


> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java

[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494196#comment-15494196
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

Github user spmallette closed the pull request at:

https://github.com/apache/tinkerpop/pull/423


> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java

[GitHub] tinkerpop pull request #423: TINKERPOP-1451 TinkerGraph persistence cannot h...

2016-09-15 Thread spmallette
Github user spmallette closed the pull request at:

https://github.com/apache/tinkerpop/pull/423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #423: TINKERPOP-1451 TinkerGraph persistence cannot h...

2016-09-15 Thread spmallette
Github user spmallette closed the pull request at:

https://github.com/apache/tinkerpop/pull/423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #423: TINKERPOP-1451 TinkerGraph persistence cannot h...

2016-09-15 Thread spmallette
GitHub user spmallette reopened a pull request:

https://github.com/apache/tinkerpop/pull/423

TINKERPOP-1451 TinkerGraph persistence cannot handle a single file name as 
the graph location

https://issues.apache.org/jira/browse/TINKERPOP-1451

works nicely now:

```text
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test4.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
```

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit e7e748151da513850567395d376e02e4cda864a2
Author: Daniel Kuppitz 
Date:   2016-09-15T18:08:39Z

Merge branch 'TINKERPOP-1391' into tp31

commit 371bb39c5c23bb766f391974ea024219a5941fe8
Author: Stephen Mallette 
Date:   2016-09-15T17:51:33Z

TinkerGraph's would not save on close()

if the path was just a file name. Tested "just a file name" manually and 
added a test for relative paths - didn't want to generate test data outside of 
our test directories. TINKERPOP-1451

commit 356b7c81a9517c89204efb1f0e0e30037bd04ae0
Author: Stephen Mallette 
Date:   2016-09-15T18:08:31Z

Added a test for persisting multi-properties in TinkerGraph

Changed the test back to using a relative path in the data directory - 
didn't like it polluting the source control directories.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494171#comment-15494171
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/423#discussion_r79032415
  
--- Diff: CHANGELOG.asciidoc ---
@@ -26,7 +26,9 @@ 
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 TinkerPop 3.1.5 (Release Date: NOT OFFICIALLY RELEASED YET)
 ~~~
 
-+ Removed the `appveyor.yml` file as the AppVeyor build is no longer 
enabled by Apache Infrastructure.
+* Removed the `appveyor.yml` file as the AppVeyor build is no longer 
enabled by Apache Infrastructure.
+* Fixed TinkerGraph which was not saving on `close()` if the path only 
consisted of the file name.
+* Fixed a bug in `RangeByIsCountStrategy` which didn't use the `NotStep` 
properly.
--- End diff --

Looks like something else got dragged in.


> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>

[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494173#comment-15494173
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/423
  
yeah - i flubbed it - trying to fix



> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.

[GitHub] tinkerpop issue #423: TINKERPOP-1451 TinkerGraph persistence cannot handle a...

2016-09-15 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/423
  
yeah - i flubbed it - trying to fix



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #423: TINKERPOP-1451 TinkerGraph persistence cannot h...

2016-09-15 Thread robertdale
Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/423#discussion_r79032415
  
--- Diff: CHANGELOG.asciidoc ---
@@ -26,7 +26,9 @@ 
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 TinkerPop 3.1.5 (Release Date: NOT OFFICIALLY RELEASED YET)
 ~~~
 
-+ Removed the `appveyor.yml` file as the AppVeyor build is no longer 
enabled by Apache Infrastructure.
+* Removed the `appveyor.yml` file as the AppVeyor build is no longer 
enabled by Apache Infrastructure.
+* Fixed TinkerGraph which was not saving on `close()` if the path only 
consisted of the file name.
+* Fixed a bug in `RangeByIsCountStrategy` which didn't use the `NotStep` 
properly.
--- End diff --

Looks like something else got dragged in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #423: TINKERPOP-1451 TinkerGraph persistence cannot h...

2016-09-15 Thread spmallette
GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/423

TINKERPOP-1451 TinkerGraph persistence cannot handle a single file name as 
the graph location

https://issues.apache.org/jira/browse/TINKERPOP-1451

works nicely now:

```text
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test4.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
```

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit 6a6b44d85a4e3e7f6e83778aab9fc21436ef6004
Author: Stephen Mallette 
Date:   2016-09-15T17:51:33Z

TinkerGraph's would not save on close()

if the path was just a file name. Tested "just a file name" manually and 
added a test for relative paths - didn't want to generate test data outside of 
our test directories. TINKERPOP-1451

commit b1579f38038e85842bb8699e4397b390e24a57c8
Author: Stephen Mallette 
Date:   2016-09-15T17:57:21Z

Modified TinkerGraph IO test to use just the filename for the path

Change my mind from the previous commit. Probably better to have the test 
for exactly what was failing.
Changed my mind about

commit 2d57a32af554271c766ad4cfa0856b57b5806da7
Author: Stephen Mallette 
Date:   2016-09-15T18:08:31Z

Added a test for persisting multi-properties in TinkerGraph

Changed the test back to using a relative path in the data directory - 
didn't like it polluting the source control directories.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494163#comment-15494163
 ] 

ASF GitHub Bot commented on TINKERPOP-1451:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/423

TINKERPOP-1451 TinkerGraph persistence cannot handle a single file name as 
the graph location

https://issues.apache.org/jira/browse/TINKERPOP-1451

works nicely now:

```text
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test4.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
```

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit 6a6b44d85a4e3e7f6e83778aab9fc21436ef6004
Author: Stephen Mallette 
Date:   2016-09-15T17:51:33Z

TinkerGraph's would not save on close()

if the path was just a file name. Tested "just a file name" manually and 
added a test for relative paths - didn't want to generate test data outside of 
our test directories. TINKERPOP-1451

commit b1579f38038e85842bb8699e4397b390e24a57c8
Author: Stephen Mallette 
Date:   2016-09-15T17:57:21Z

Modified TinkerGraph IO test to use just the filename for the path

Change my mind from the previous commit. Probably better to have the test 
for exactly what was failing.
Changed my mind about

commit 2d57a32af554271c766ad4cfa0856b57b5806da7
Author: Stephen Mallette 
Date:   2016-09-15T18:08:31Z

Added a test for persisting multi-properties in TinkerGraph

Changed the test back to using a relative path in the data directory - 
didn't like it polluting the source control directories.




> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.Abstra

[jira] [Updated] (TINKERPOP-1451) TinkerGraph persistence cannot handle a single file name as the graph location

2016-09-15 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1451:

Summary: TinkerGraph persistence cannot handle a single file name as the 
graph location  (was: TinkerGraph Gryo cannot handle relative file paths)

> TinkerGraph persistence cannot handle a single file name as the graph location
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

[jira] [Closed] (TINKERPOP-1452) TinkerGraph Gryo Export looses multi-properties

2016-09-15 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1452.
---
Resolution: Not A Problem

You're seeing this problem because TinkerGraph's default configuration on 
reading a graph is to use {{Cardinality.single}}. You have to change that:

{code}
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@18a3962d
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'data/test6.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_DEFAULT_VERTEX_PROPERTY_CARDINALITY,
 VertexProperty.Cardinality.list.toString());
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->1]
==>vp[age->2]
{code}

> TinkerGraph Gryo Export looses multi-properties
> ---
>
> Key: TINKERPOP-1452
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1452
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>Assignee: stephen mallette
>Priority: Critical
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> '/Users/matthias/Documents/Development/tp/test2.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:1 edges:0]
> gremlin> graph.traversal().V().properties()
> ==>vp[age->2]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1391) issue with where filter

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494116#comment-15494116
 ] 

ASF GitHub Bot commented on TINKERPOP-1391:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/406


> issue with where filter
> ---
>
> Key: TINKERPOP-1391
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1391
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Arik Cohen
>Assignee: Daniel Kuppitz
> Fix For: 3.1.5, 3.2.3
>
>
> Graph g = TinkerGraph.open();
> g.addVertex(T.label,"GROUP","name","Acme");
> 
> List list = g.traversal()
>.V()
>.hasLabel("GROUP")
>
> .where(__.outE().hasLabel("PART_OF").count().is(0))
>.toList();
> 
> Assert.assertEquals(1, list.size()); // actual size is 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TINKERPOP-1391) issue with where filter

2016-09-15 Thread Daniel Kuppitz (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz closed TINKERPOP-1391.
-
   Resolution: Fixed
Fix Version/s: 3.2.3
   3.1.5

> issue with where filter
> ---
>
> Key: TINKERPOP-1391
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1391
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Arik Cohen
>Assignee: Daniel Kuppitz
> Fix For: 3.1.5, 3.2.3
>
>
> Graph g = TinkerGraph.open();
> g.addVertex(T.label,"GROUP","name","Acme");
> 
> List list = g.traversal()
>.V()
>.hasLabel("GROUP")
>
> .where(__.outE().hasLabel("PART_OF").count().is(0))
>.toList();
> 
> Assert.assertEquals(1, list.size()); // actual size is 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1391) issue with where filter

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494117#comment-15494117
 ] 

ASF GitHub Bot commented on TINKERPOP-1391:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/405


> issue with where filter
> ---
>
> Key: TINKERPOP-1391
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1391
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Arik Cohen
>Assignee: Daniel Kuppitz
> Fix For: 3.1.5, 3.2.3
>
>
> Graph g = TinkerGraph.open();
> g.addVertex(T.label,"GROUP","name","Acme");
> 
> List list = g.traversal()
>.V()
>.hasLabel("GROUP")
>
> .where(__.outE().hasLabel("PART_OF").count().is(0))
>.toList();
> 
> Assert.assertEquals(1, list.size()); // actual size is 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #406: TINKERPOP-1391 issue with where filter

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/406


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #405: TINKERPOP-1391 issue with where filter

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1451) TinkerGraph Gryo cannot handle relative file paths

2016-09-15 Thread stephen mallette (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494070#comment-15494070
 ] 

stephen mallette commented on TINKERPOP-1451:
-

Seems like this issue isn't with "relative file paths" but file paths that only 
have a file name. In other words, it works with:

{code}
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'data/test.gryo')
{code}

anyway - bug nonetheless



> TinkerGraph Gryo cannot handle relative file paths
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcces

[GitHub] tinkerpop issue #406: TINKERPOP-1391 issue with where filter

2016-09-15 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/406
  
VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1391) issue with where filter

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493986#comment-15493986
 ] 

ASF GitHub Bot commented on TINKERPOP-1391:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/406
  
VOTE +1.


> issue with where filter
> ---
>
> Key: TINKERPOP-1391
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1391
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Arik Cohen
>Assignee: Daniel Kuppitz
>
> Graph g = TinkerGraph.open();
> g.addVertex(T.label,"GROUP","name","Acme");
> 
> List list = g.traversal()
>.V()
>.hasLabel("GROUP")
>
> .where(__.outE().hasLabel("PART_OF").count().is(0))
>.toList();
> 
> Assert.assertEquals(1, list.size()); // actual size is 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494010#comment-15494010
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
Acctually, I think the parameterization should be `null.result.indicator` 
as you check `object == null` and thus, its not "empty," but `null`.


> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

2016-09-15 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
Acctually, I think the parameterization should be `null.result.indicator` 
as you check `object == null` and thus, its not "empty," but `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1391) issue with where filter

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493984#comment-15493984
 ] 

ASF GitHub Bot commented on TINKERPOP-1391:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/405
  
VOTE +1.


> issue with where filter
> ---
>
> Key: TINKERPOP-1391
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1391
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Arik Cohen
>Assignee: Daniel Kuppitz
>
> Graph g = TinkerGraph.open();
> g.addVertex(T.label,"GROUP","name","Acme");
> 
> List list = g.traversal()
>.V()
>.hasLabel("GROUP")
>
> .where(__.outE().hasLabel("PART_OF").count().is(0))
>.toList();
> 
> Assert.assertEquals(1, list.size()); // actual size is 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494000#comment-15494000
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
Cool. VOTE +1.


> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

2016-09-15 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
Cool. VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (TINKERPOP-1330) by()-modulation for where()

2016-09-15 Thread Marko A. Rodriguez (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez resolved TINKERPOP-1330.
---
   Resolution: Implemented
Fix Version/s: 3.2.3

> by()-modulation for where()
> ---
>
> Key: TINKERPOP-1330
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1330
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.3
>
>
> As discussed in https://issues.apache.org/jira/browse/TINKERPOP-1329, it 
> would be nice to have {{by()}}-modulators for {{where()}}. For example:
> {code}
> g.V().as("a").out().where(gt("a")).by("age") // both a and current ages are 
> selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age") // both a and b ages 
> are selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age").by("weight") // 
> where b.age > a.weight
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1330) by()-modulation for where()

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493988#comment-15493988
 ] 

ASF GitHub Bot commented on TINKERPOP-1330:
---

Github user okram closed the pull request at:

https://github.com/apache/tinkerpop/pull/417


> by()-modulation for where()
> ---
>
> Key: TINKERPOP-1330
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1330
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> As discussed in https://issues.apache.org/jira/browse/TINKERPOP-1329, it 
> would be nice to have {{by()}}-modulators for {{where()}}. For example:
> {code}
> g.V().as("a").out().where(gt("a")).by("age") // both a and current ages are 
> selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age") // both a and b ages 
> are selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age").by("weight") // 
> where b.age > a.weight
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread okram
Github user okram closed the pull request at:

https://github.com/apache/tinkerpop/pull/417


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #405: TINKERPOP-1391 issue with where filter

2016-09-15 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/405
  
VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Closed] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread David M. Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Brown closed TINKERPOP-1448.
-
Resolution: Fixed

> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>Assignee: David M. Brown
> Fix For: 3.2.3
>
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread David M. Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Brown reopened TINKERPOP-1448:
---

Need to set fix version

> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>Assignee: David M. Brown
> Fix For: 3.2.3
>
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread David M. Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Brown updated TINKERPOP-1448:
--
Fix Version/s: 3.2.3

> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>Assignee: David M. Brown
> Fix For: 3.2.3
>
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread David M. Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Brown resolved TINKERPOP-1448.
---
Resolution: Fixed

Easy fix

> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread David M. Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Brown closed TINKERPOP-1448.
-
Assignee: David M. Brown

> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>Assignee: David M. Brown
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TINKERPOP-1452) TinkerGraph Gryo Export looses multi-properties

2016-09-15 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1452:

 Assignee: stephen mallette
Affects Version/s: 3.1.4
 Priority: Critical  (was: Major)
  Component/s: tinkergraph

holy hell!!

> TinkerGraph Gryo Export looses multi-properties
> ---
>
> Key: TINKERPOP-1452
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1452
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>Assignee: stephen mallette
>Priority: Critical
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> '/Users/matthias/Documents/Development/tp/test2.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:1 edges:0]
> gremlin> graph.traversal().V().properties()
> ==>vp[age->2]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TINKERPOP-1451) TinkerGraph Gryo cannot handle relative file paths

2016-09-15 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1451:

Affects Version/s: 3.1.4
  Component/s: tinkergraph

> TinkerGraph Gryo cannot handle relative file paths
> --
>
> Key: TINKERPOP-1451
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.1.4
>Reporter: Matthias Broecheler
>
> {code}
> gremlin> configuration = new 
> org.apache.commons.configuration.BaseConfiguration()
> ==>org.apache.commons.configuration.BaseConfiguration@30331109
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
> 'test.gryo')
> ==>null
> gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
> ==>null
> gremlin> 
> configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 
> 'gryo')
> ==>null
> gremlin> graph = TinkerGraph.open(configuration)
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex('Person')
> ==>v[0]
> gremlin> v.property(list, 'age', 1)
> ==>vp[age->1]
> gremlin> v.property(list, 'age', 2)
> ==>vp[age->2]
> gremlin> v.properties()
> ==>vp[age->1]
> ==>vp[age->2]
> gremlin> graph.close()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
>   at 
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
>   at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
> Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
>   at groovysh_evaluate.run(groovysh_evaluate:3)
>   at 
> org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
>   at 
> org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
>   at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
>   at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
>   at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
>   at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
>   at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
>   at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
>   at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
>   at 
> org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
>   at 
> org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:

[jira] [Created] (TINKERPOP-1452) TinkerGraph Gryo Export looses multi-properties

2016-09-15 Thread Matthias Broecheler (JIRA)
Matthias Broecheler created TINKERPOP-1452:
--

 Summary: TinkerGraph Gryo Export looses multi-properties
 Key: TINKERPOP-1452
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1452
 Project: TinkerPop
  Issue Type: Bug
Reporter: Matthias Broecheler


{code}
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@30331109
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'/Users/matthias/Documents/Development/tp/test2.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:1 edges:0]
gremlin> graph.traversal().V().properties()
==>vp[age->2]
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TINKERPOP-1451) TinkerGraph Gryo cannot handle relative file paths

2016-09-15 Thread Matthias Broecheler (JIRA)
Matthias Broecheler created TINKERPOP-1451:
--

 Summary: TinkerGraph Gryo cannot handle relative file paths
 Key: TINKERPOP-1451
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1451
 Project: TinkerPop
  Issue Type: Bug
Reporter: Matthias Broecheler


{code}
gremlin> configuration = new 
org.apache.commons.configuration.BaseConfiguration()
==>org.apache.commons.configuration.BaseConfiguration@30331109
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_LOCATION, 
'test.gryo')
==>null
gremlin> configuration.setProperty(Graph.GRAPH, TinkerGraph.class.getName())
==>null
gremlin> 
configuration.setProperty(TinkerGraph.GREMLIN_TINKERGRAPH_GRAPH_FORMAT, 'gryo')
==>null
gremlin> graph = TinkerGraph.open(configuration)
==>tinkergraph[vertices:0 edges:0]
gremlin> v = graph.addVertex('Person')
==>v[0]
gremlin> v.property(list, 'age', 1)
==>vp[age->1]
gremlin> v.property(list, 'age', 2)
==>vp[age->2]
gremlin> v.properties()
==>vp[age->1]
==>vp[age->2]
gremlin> graph.close()
java.lang.NullPointerException
Type ':help' or ':h' for help.
Display stack trace? [yN]y
java.lang.NullPointerException
at 
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.saveGraph(TinkerGraph.java:302)
at 
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph.close(TinkerGraph.java:254)
at org.apache.tinkerpop.gremlin.structure.Graph$close$1.call(Unknown 
Source)
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
at groovysh_evaluate.run(groovysh_evaluate:3)
at 
org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
at 
org.codehaus.groovy.tools.shell.Interpreter.evaluate(Interpreter.groovy:70)
at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:190)
at 
org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
at 
org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
at 
org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
at 
org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
at 
org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:124)
at 
org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
at 
org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1215)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:132)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:152)
at 
org.codehau

Re: [DISCUSS] PR VOTE and GitHub Code Review

2016-09-15 Thread Daniel Kuppitz
I agree. It is a cool feature / nice idea, but it's too bad that these
reviews don't trigger email notifications.

Maybe we can revisit this option in the near future.

Cheers,
Daniel


On Thu, Sep 15, 2016 at 4:05 PM, Stephen Mallette 
wrote:

> GitHub released a new "code review" feature yesterday. You press a button
> and can "approve of a PR" - kinda nice. You can see Kuppitz gave it a try
> yesterday on this PR:
>
> https://github.com/apache/tinkerpop/pull/416
>
> as opposed to a VOTE +1. He seemed to like that and I do too. of course,
> the "code review" feature isn't integrated with apache automation, so:
>
> 1. it doesn't tie to the JIRA comment system, so we don't get the VOTE
> there.
> 2. as a result of 1, we don't get a email to dev capturing the VOTE. Since
> all decisions must occur on the dev list - that's not so good.
>
> Personally, I feel like the "code review" feature is sorta lacking. You
> can't see the number of approvals summed up on the list screen, so you end
> up going into the PR anyway to see who has approved. So that's not saving
> any time. I also like that when we VOTE we usually comment something to say
> how/what we tested - i think there's a option for that with code review,
> but again, it's not like i see that without going into the issue anyway.
>
> And all that aside, I think that without the apache automation, we
> shouldn't use this. We have a good track record of using the dev list of
> decision making - i think we should just stick to that. If you want a one
> button push to +1 a PR, then, do what i do, and use a "saved comment" -
> that works well for me for standard replies.
>


[jira] [Commented] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493874#comment-15493874
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
VOTE: +1


> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/422
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1409) Make the "null" return in the gremlin console into something more understandable

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493852#comment-15493852
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/422

TINKERPOP-1409 Print no result line if empty.result.indicator is empty 
string.

https://issues.apache.org/jira/browse/TINKERPOP-1409

This seems like a better use of the empty string setting than to actually 
just print an empty string line.

```text
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
==>null
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> :set empty.result.indicator ""
gremlin> graph.close()
gremlin> 
```

Pretty small change, but, I didn't CTR this in case someone didn't really 
like this behavior.  If there are -1s I can just kill this and close the JIRA 
currently hanging out there as I only kept it open because I saw this dangling 
issue I wanted to implement.

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #422






> Make the "null" return in the gremlin console into something more 
> understandable
> 
>
> Key: TINKERPOP-1409
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.2.1
>Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #422: TINKERPOP-1409 Print no result line if empty.re...

2016-09-15 Thread spmallette
GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/422

TINKERPOP-1409 Print no result line if empty.result.indicator is empty 
string.

https://issues.apache.org/jira/browse/TINKERPOP-1409

This seems like a better use of the empty string setting than to actually 
just print an empty string line.

```text
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> graph.close()
==>null
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> :set empty.result.indicator ""
gremlin> graph.close()
gremlin> 
```

Pretty small change, but, I didn't CTR this in case someone didn't really 
like this behavior.  If there are -1s I can just kill this and close the JIRA 
currently hanging out there as I only kept it open because I saw this dangling 
issue I wanted to implement.

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #422






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #415: TINKERPOP-1448 gremlin-python should be Python ...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493801#comment-15493801
 ] 

ASF GitHub Bot commented on TINKERPOP-1448:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/415


> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Daniel Kuppitz (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz closed TINKERPOP-1429.
-
Resolution: Fixed

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
> Fix For: 3.2.0-incubating
>
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Daniel Kuppitz (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493807#comment-15493807
 ] 

Daniel Kuppitz commented on TINKERPOP-1429:
---

I haven't seen your answers to my previous comment earlier. I take them as a 
Yes answer to my last question.

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
> Fix For: 3.2.0-incubating
>
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Daniel Kuppitz (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz updated TINKERPOP-1429:
--
Fix Version/s: 3.2.0-incubating

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
> Fix For: 3.2.0-incubating
>
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Daniel Kuppitz (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493791#comment-15493791
 ] 

Daniel Kuppitz commented on TINKERPOP-1429:
---

It is still an issue in the {{tp31/}} line, but was already resolved in 
{{3.2.0-incubating}}. Thus I think we should simply mark the issue as resolved. 
[~okram], any objections?

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1330) by()-modulation for where()

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493755#comment-15493755
 ] 

ASF GitHub Bot commented on TINKERPOP-1330:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/417
  
The Python-related fixes are necessary or else some of the `WhereTests` 
fail. Python has a bad ordering to the scoping variables with nested 
`and()`/`or()`. Thus, for the test suite to pass I had to fix a bug in Python.


> by()-modulation for where()
> ---
>
> Key: TINKERPOP-1330
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1330
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> As discussed in https://issues.apache.org/jira/browse/TINKERPOP-1329, it 
> would be nice to have {{by()}}-modulators for {{where()}}. For example:
> {code}
> g.V().as("a").out().where(gt("a")).by("age") // both a and current ages are 
> selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age") // both a and b ages 
> are selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age").by("weight") // 
> where b.age > a.weight
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/417
  
The Python-related fixes are necessary or else some of the `WhereTests` 
fail. Python has a bad ordering to the scoping variables with nested 
`and()`/`or()`. Thus, for the test suite to pass I had to fix a bug in Python.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Comment Edited] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493722#comment-15493722
 ] 

Marko A. Rodriguez edited comment on TINKERPOP-1444 at 9/15/16 3:56 PM:


This is the problem. Once a traversal has been built, the binding values are 
"solidified." Meaning, you CAN'T have a "generic traversal" whose arguments are 
supplied later. So, while you can {{clone()}} a traversal and re-use it, you 
can't change its parameterization because its already been compiled and during 
compilation, many of those parameters were used to determine how it would be 
compiled. Thus, the best "prepared statement" we have is {{Bytecode}} which is 
the closest you can get to a traversal instance and still mutate parameters. 
Previous to {{Bytecode}} the closest thing you had was a Groovy {{String}}. 
This is analogous to Java/JIT/etc.


was (Author: okram):
This is the problem. Once a traversal has been built, the binding values are 
"solidified." Meaning, you can have a "generic traversal" whose arguments are 
supplied later. So, while you can {{clone()}} a traversal and re-use it, you 
can't change its parameterization because its already been compiled and during 
compilation, many of those parameters were used to determine how it would be 
compiled. Thus, our "prepared statement" is simply {{Bytecode}} which is the 
closest you can get to a traversal instance and still mutate parameters. 
Previous to {{Bytecode}} the closest thing you had was a Groovy {{String}}.

> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1450) Add support for stack trace filling to FastNoSuchElementException

2016-09-15 Thread Matthias Broecheler (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493744#comment-15493744
 ] 

Matthias Broecheler commented on TINKERPOP-1450:


I think both of these suggestions are great ideas since they address different 
needs:

1) Addresses the novel user who might write a traversal such as 
{{g.V().outE().next()}} and end up with a stack-less exception that doesn't 
make sense to them. 

2) Addresses the "application development" need where TinkerPop code is used 
throughout an app. Changing the behavior with a system property is fine in this 
case. The fact that this doesn't work for production systems where Gremlin code 
is send over the wire or somehow executed remotely isn't a problem imho, since 
those cases typically don't have a ton of complicated (i.e. 1000s lines of) 
code and 1) above should take care of most needs.

> Add support for stack trace filling to FastNoSuchElementException
> -
>
> Key: TINKERPOP-1450
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1450
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.1.3, 3.2.2
>Reporter: Marko A. Rodriguez
>
> Many people (like [~mbroecheler]) complain that if they have some complicated 
> code they don't know where the problem is when a traversal throws a 
> {{FastNoSuchElementException}}. I think we can remedy this in on of two ways:
> 1.) Only the root traversal will "fill in the stack trace" if there is no 
> such element. This way, a stack trace is filled once and only once. However, 
> the problem here is that the user will only know that the traversal failed, 
> not where in the traversal it failed.
> 2.) Provide a "is.testing" System.getProperty() to 
> {{FastNoSuchElementException}}. The problem here, this will only show stack 
> traces for code that is executed in the same JVM as Gremlin's. This is great 
> for actually testing (JUnit style), but not for production settings.
> 3.) ... dunno? Anyone have an idea?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1330) by()-modulation for where()

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493739#comment-15493739
 ] 

ASF GitHub Bot commented on TINKERPOP-1330:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/417
  
Code looks great, although the Python-related fixes are a bit misplaced in 
this PR. Anyhow,

VOTE: +1


> by()-modulation for where()
> ---
>
> Key: TINKERPOP-1330
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1330
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> As discussed in https://issues.apache.org/jira/browse/TINKERPOP-1329, it 
> would be nice to have {{by()}}-modulators for {{where()}}. For example:
> {code}
> g.V().as("a").out().where(gt("a")).by("age") // both a and current ages are 
> selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age") // both a and b ages 
> are selected
> g.V().as("a").out().as("b").where("b",gt("a")).by("age").by("weight") // 
> where b.age > a.weight
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/417
  
Code looks great, although the Python-related fixes are a bit misplaced in 
this PR. Anyhow,

VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1450) Add support for stack trace filling to FastNoSuchElementException

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493732#comment-15493732
 ] 

Marko A. Rodriguez commented on TINKERPOP-1450:
---

The "is.testing" model is trivial to implement.

{code}
private final static boolean isTesting = 
Boolean.valueOf(System.getProperty("is.testing","false"))

@Override
public synchronized Throwable fillInStackTrace() {
return isTesting ? super.fillStackTrace() : this;
}
{code}

> Add support for stack trace filling to FastNoSuchElementException
> -
>
> Key: TINKERPOP-1450
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1450
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.1.3, 3.2.2
>Reporter: Marko A. Rodriguez
>
> Many people (like [~mbroecheler]) complain that if they have some complicated 
> code they don't know where the problem is when a traversal throws a 
> {{FastNoSuchElementException}}. I think we can remedy this in on of two ways:
> 1.) Only the root traversal will "fill in the stack trace" if there is no 
> such element. This way, a stack trace is filled once and only once. However, 
> the problem here is that the user will only know that the traversal failed, 
> not where in the traversal it failed.
> 2.) Provide a "is.testing" System.getProperty() to 
> {{FastNoSuchElementException}}. The problem here, this will only show stack 
> traces for code that is executed in the same JVM as Gremlin's. This is great 
> for actually testing (JUnit style), but not for production settings.
> 3.) ... dunno? Anyone have an idea?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493722#comment-15493722
 ] 

Marko A. Rodriguez commented on TINKERPOP-1444:
---

This is the problem. Once a traversal has been built, the binding values are 
"solidified." Meaning, you can have a "generic traversal" whose arguments are 
supplied later. So, while you can {{clone()}} a traversal and re-use it, you 
can't change its parameterization because its already been compiled and during 
compilation, many of those parameters were used to determine how it would be 
compiled. Thus, our "prepared statement" is simply {{Bytecode}} which is the 
closest you can get to a traversal instance and still mutate parameters. 
Previous to {{Bytecode}} the closest thing you had was a Groovy {{String}}.

> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493710#comment-15493710
 ] 

Marko A. Rodriguez commented on TINKERPOP-1429:
---

http://tinkerpop.apache.org/docs/3.2.0-incubating/upgrade/#_branchstep_bug_fix

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493707#comment-15493707
 ] 

Marko A. Rodriguez commented on TINKERPOP-1429:
---

What version were you having this problem? Note that at the 3.2.0 release we 
fixed a bug in BranchStep.

{code}
* Fixed a semantic bug in BranchStep (and inheriting steps) where barriers 
reacted locally. (breaking)
{code}

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #421: Fix multiple occurrences of 'the'

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #421: Fix multiple occurrences of 'the'

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/421
  
This PR has been merged. Thank you for **the the** contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #420: Fix multiple occurrences of 'the'

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/420
  
This PR has been merged. Thank you for **the the** contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #420: Fix multiple occurrences of 'the'

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/420


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (TINKERPOP-1450) Add support for stack trace filling to FastNoSuchElementException

2016-09-15 Thread Marko A. Rodriguez (JIRA)
Marko A. Rodriguez created TINKERPOP-1450:
-

 Summary: Add support for stack trace filling to 
FastNoSuchElementException
 Key: TINKERPOP-1450
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1450
 Project: TinkerPop
  Issue Type: Improvement
  Components: process
Affects Versions: 3.2.2, 3.1.3
Reporter: Marko A. Rodriguez


Many people (like [~mbroecheler]) complain that if they have some complicated 
code they don't know where the problem is when a traversal throws a 
{{FastNoSuchElementException}}. I think we can remedy this in on of two ways:

1.) Only the root traversal will "fill in the stack trace" if there is no such 
element. This way, a stack trace is filled once and only once. However, the 
problem here is that the user will only know that the traversal failed, not 
where in the traversal it failed.

2.) Provide a "is.testing" System.getProperty() to 
{{FastNoSuchElementException}}. The problem here, this will only show stack 
traces for code that is executed in the same JVM as Gremlin's. This is great 
for actually testing (JUnit style), but not for production settings.

3.) ... dunno? Anyone have an idea?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Daniel Kuppitz (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493682#comment-15493682
 ] 

Daniel Kuppitz commented on TINKERPOP-1429:
---

Not sure when / where exactly it was fixed, but this is no longer an issue in 
{{master/}}.

> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #418: Fixed issue in NumberSerializer that could caus...

2016-09-15 Thread leifurhauks
Github user leifurhauks commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/418#discussion_r78990181
  
--- Diff: 
gremlin-python/src/main/jython/gremlin_python/structure/io/graphson.py ---
@@ -181,7 +181,7 @@ class NumberSerializer(GraphSONSerializer):
 def _dictify(self, number):
 if isinstance(number, bool):  # python thinks that 0/1 integers 
are booleans
 return number
-elif isinstance(number, long):
+elif isinstance(number, long) or (number > 2147483647): # in 
python all numbers are int unless specified otherwise
--- End diff --

is graphson's Int32 unsigned?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #415: TINKERPOP-1448 gremlin-python should be Python 2/3 com...

2016-09-15 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/415
  
Ran tests on Python 2.7 with:

```test
mvn clean install -pl gremlin-python -DglvPython
```

VOTE +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1444) Benchmark bytecode->Traversal creation and implement GremlinServer cache if necessary.

2016-09-15 Thread Jeremy Hanna (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493578#comment-15493578
 ] 

Jeremy Hanna commented on TINKERPOP-1444:
-

It seems like this would be very similar to prepared statement cache - having 
an id or hash of the bytecode to get to the equivalent traversal - presuming 
like you say we parameterize them.  cc [~newkek]

> Benchmark bytecode->Traversal creation and implement GremlinServer cache if 
> necessary.
> --
>
> Key: TINKERPOP-1444
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1444
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: benchmark, language-variant, process, server
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>
> Right now, when you send {{Bytecode}} to GremlinServer, it will convert the 
> bytecode to a traversal either via Java reflection (Gremlin-Java) or script 
> engine evaluation (e.g. Gremlin-Groovy, Gremlin-Python).
> We should see how fast the process is to go from Bytecode to Traversal and if 
> its "slow" we should create a {{Map}}-cache in 
> GremlinServer.
> The reasons it may be "slow" are:
> 1. {{JavaTranslator}} uses Java reflection to translate bytecode to traversal 
> and that code is a little "thick" and either should be optimized (if 
> possible) or, instead, bytecode/traversal translations should be cached.
> 2. {{Groovy/PythonTranslator}} uses string construction to generate a script 
> from the bytecode. While that script may be cached, it would be good if we 
> have a cache prior to that which simply just grabs the traversal from a 
> bytecode cache.
> I think that we will definitely want a cache as it should make things fast, 
> but it will be good to know how much faster prior to diving into such work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1448) gremlin-python should be Python 2/3 compatible

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493597#comment-15493597
 ] 

ASF GitHub Bot commented on TINKERPOP-1448:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/415
  
Ran tests on Python 2.7 with:

```test
mvn clean install -pl gremlin-python -DglvPython
```

VOTE +1



> gremlin-python should be Python 2/3 compatible
> --
>
> Key: TINKERPOP-1448
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1448
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.2
>Reporter: David M. Brown
>
> As discussed here, it is simple to maintain Python 2/3 compatibility for 
> gremlin-python GLV: 
> https://lists.apache.org/thread.html/263739a38133be620dd32640fe997388e76b20379a3dae44b10d4442@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TINKERPOP-1429) Branch step inside where step misbehaves

2016-09-15 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493448#comment-15493448
 ] 

Marko A. Rodriguez edited comment on TINKERPOP-1429 at 9/15/16 2:22 PM:


I don't quite understand the toy graph example from @dkuppitz, but what I do 
notice is that a reducing barrier step is being used inside a local child 
traversal. {{where}} compiles to {{TraversalFilterStep}} which resets its 
internal "local" child traversal after each incoming traverser is processed. 
Thus, for each incoming traverser, the a new {{count()}} is calculated which, 
at most will be 1.

Here is a simple example on the MODERN graph.

{code}
// GOOD
gremlin> 
g.V().branch(label()).option("software",count()).option("person",count())
==>2
==>4
// GOOD
gremlin> 
g.V().branch(label()).option("software",count().is(2)).option("person",count().is(4))
==>2
==>4
// UNEXPECTED
gremlin> 
g.V().where(branch(label()).option("software",count().is(2)).option("person",count().is(4)))
gremlin>
{code}

Now watch this:

{code}
gremlin> 
g.V().where(branch(label()).option("software",count().is(1)).option("person",count().is(4)))
==>v[3]
==>v[5]
{code}

For that local traversal, there is 1 software! Thus, {{v[3]}} and {{v[5]}} go 
through the filter.

I know this is confusing to users. I don't know how to make clear that 
distinction between global and local processing, where *global* means, process 
the entire stream and *local* means process the stream created by a single 
input traverser. Both are important concepts and are needed, but it just 
entails that sometimes a nested traversal is "per traverser" (local) and 
sometimes "per traversers" (global). ..

Does this clear up the ISSUE or is there still something deeper I'm missing?



was (Author: okram):
I don't quite understand the toy graph example from @dkuppitz, but what I do 
notice is that a reducing barrier step is being used inside a local child 
option. {{where}} compiles to {{TraversalFilterStep}} which resets its internal 
"local" child traversal after each incoming traverser is processed. Thus, for 
each incoming traverser, the a new {{count()}} is calculated which, at most 
will be 1.

Here is a simple example on the MODERN graph.

{code}
// GOOD
gremlin> 
g.V().branch(label()).option("software",count()).option("person",count())
==>2
==>4
// GOOD
gremlin> 
g.V().branch(label()).option("software",count().is(2)).option("person",count().is(4))
==>2
==>4
// UNEXPECTED
gremlin> 
g.V().where(branch(label()).option("software",count().is(2)).option("person",count().is(4)))
gremlin>
{code}

Now watch this:

{code}
gremlin> 
g.V().where(branch(label()).option("software",count().is(1)).option("person",count().is(4)))
==>v[3]
==>v[5]
{code}

For that local traversal, there is 1 software! Thus, {{v[3]}} and {{v[5]}} go 
through the filter.

I know this is confusing to users. I don't know how to make clear that 
distinction between global and local processing, where *global* means, process 
the entire stream and *local* means process the stream created by a single 
input traverser. Both are important concepts and are needed, but it just 
entails that sometimes a nested traversal is "per traverser" (local) and 
sometimes "per traversers" (global). ..

Does this clear up the ISSUE or is there still something deeper I'm missing?


> Branch step inside where step misbehaves
> 
>
> Key: TINKERPOP-1429
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1429
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.0.1-incubating
>Reporter: Jordi Chacon
>
> https://groups.google.com/forum/#!topic/gremlin-users/0LSvVRtjERg



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


  1   2   >