[jira] [Created] (TINKERPOP-1643) Something's broke in OLAP
Daniel Kuppitz created TINKERPOP-1643:
-
Summary: Something's broke in OLAP
Key: TINKERPOP-1643
URL: https://issues.apache.org/jira/browse/TINKERPOP-1643
Project: TinkerPop
Issue Type: Bug
Components: process
Affects Versions: 3.3.0, 3.2.5
Reporter: Daniel Kuppitz
Assignee: Marko A. Rodriguez
I don't know what it's related to, hence the open title on this ticket.
*Base Query (all good)*:
{noformat}
gremlin> g.V().as("v").emit().repeat(both().as("v").dedup()).select("v")
==>v[1]
==>v[2]
==>v[3]
==>v[4]
==>v[5]
==>v[6]
==>[v[1],v[4]]
==>[v[4],v[5]]
==>[v[3],v[6]]
==>[v[2],v[1]]
==>[v[1],v[2]]
==>[v[1],v[3]]
{noformat}
*Issues*:
{noformat}
gremlin> g.V().as("v").emit().repeat(both().as("v").dedup()).select("v").count()
==>6
==>6
{noformat}
{noformat}
gremlin>
g.V().as("v").emit().repeat(both().as("v").dedup()).select("v").order().by(count(local))
==>v[1]
==>v[1]
==>v[2]
==>v[2]
==>v[3]
==>v[3]
==>v[4]
==>v[4]
==>v[5]
==>v[5]
==>v[6]
==>v[6]
==>[v[1],v[4]]
==>[v[4],v[5]]
==>[v[3],v[6]]
==>[v[2],v[1]]
==>[v[1],v[2]]
==>[v[1],v[3]]
{noformat}
I'm going to create a dev branch and test cases tomorrow.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1577) Provide support for Python3 or Python2 in the Docker builds.
[
https://issues.apache.org/jira/browse/TINKERPOP-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891339#comment-15891339
]
Marko A. Rodriguez commented on TINKERPOP-1577:
---
I don't have Python3 on my Mac -- only Python2.
{code}
~ python
Python 2.7.10 (default, Oct 23 2015, 19:19:21)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
{code}
> Provide support for Python3 or Python2 in the Docker builds.
>
>
> Key: TINKERPOP-1577
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1577
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.2.3
>Reporter: Marko A. Rodriguez
>Assignee: Daniel Kuppitz
>
> We need to make sure that Python2 and Python3 are both supported by
> Gremlin-Python. Thus, our docker build/test stuff should test both versions
> of Python.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891241#comment-15891241
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
Test suite passes. Still doing a code review. Got stuck with the
`ComputerVerificationStrategy` merge this afternoon...
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/565 Test suite passes. Still doing a code review. Got stuck with the `ComputerVerificationStrategy` merge this afternoon... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891062#comment-15891062
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/565
I just pushed a fix on `tp32` which has merged forward to this branch. That
should allow it to build for you now @okram - can you give it another shot?
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/565 I just pushed a fix on `tp32` which has merged forward to this branch. That should allow it to build for you now @okram - can you give it another shot? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors
[
https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1640.
-
Resolution: Fixed
Fix Version/s: 3.2.5
> ComputerVerificationStrategy gives false errors
> ---
>
> Key: TINKERPOP-1640
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.5
>
>
> I've added a new complex test that fails in OLAP. Unfortunately the test
> runner only marks the test as "ignored" as that's what we usually we want
> when a {{VerificationException}} is thrown. However, in this case the
> exception ("It is not possible to access more than a path element's id on
> GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization
> exceptions in the {{\*Translator\*}} test suites.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors
[
https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890950#comment-15890950
]
ASF GitHub Bot commented on TINKERPOP-1640:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/566
> ComputerVerificationStrategy gives false errors
> ---
>
> Key: TINKERPOP-1640
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> I've added a new complex test that fails in OLAP. Unfortunately the test
> runner only marks the test as "ignored" as that's what we usually we want
> when a {{VerificationException}} is thrown. However, in this case the
> exception ("It is not possible to access more than a path element's id on
> GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization
> exceptions in the {{\*Translator\*}} test suites.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop pull request #566: TINKERPOP-1640: ComputerVerificationStrategy gi...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
Gremlin-Python has failed twice for me locally now. :/ I'll keep reviewing
the code aspects of Groovy.
```
[WARNING] Request for side-effect keys on
b5f1b521-1431-4ee2-892d-191d3c47a500 returned no side-effects in the cache
[WARNING] Could not find side-effects for
b5f1b521-1431-4ee2-892d-191d3c47a500.
[WARNING] Could not find side-effect key for x in
fbeaa674-19f5-4629-9f11-289ff65a2c32.
[exec] tests/driver/test_driver_remote_connection.py ..
[exec] tests/driver/test_driver_remote_connection_threaded.py ..
[exec] tests/process/test_strategies.py ..
[exec] tests/process/test_traversal.py ...
[exec] tests/structure/test_graph.py ..
[exec] tests/structure/io/test_graphson.py ...
[exec]
[exec] generated xml file:
/Users/marko/software/tinkerpop/gremlin-python/target/python-reports/TEST-native-python.xml
[exec] === FAILURES
===
[exec] __ test_client_async
___
[exec]
[exec] client =
[exec]
[exec] def test_client_async(client):
[exec] g = Graph().traversal()
[exec] t = g.V()
[exec] message = RequestMessage('traversal', 'bytecode',
{'gremlin': t.bytecode})
[exec] future = client.submitAsync(message)
[exec] > assert not future.done()
[exec] E assert not True
[exec] E+ where True = >()
[exec] E+where > = .done
[exec]
[exec] tests/driver/test_client.py:75: AssertionError
[exec] = 1 failed, 35 passed in 2.71 seconds
==
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890940#comment-15890940
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
Gremlin-Python has failed twice for me locally now. :/ I'll keep reviewing
the code aspects of Groovy.
```
[WARNING] Request for side-effect keys on
b5f1b521-1431-4ee2-892d-191d3c47a500 returned no side-effects in the cache
[WARNING] Could not find side-effects for
b5f1b521-1431-4ee2-892d-191d3c47a500.
[WARNING] Could not find side-effect key for x in
fbeaa674-19f5-4629-9f11-289ff65a2c32.
[exec] tests/driver/test_driver_remote_connection.py ..
[exec] tests/driver/test_driver_remote_connection_threaded.py ..
[exec] tests/process/test_strategies.py ..
[exec] tests/process/test_traversal.py ...
[exec] tests/structure/test_graph.py ..
[exec] tests/structure/io/test_graphson.py ...
[exec]
[exec] generated xml file:
/Users/marko/software/tinkerpop/gremlin-python/target/python-reports/TEST-native-python.xml
[exec] === FAILURES
===
[exec] __ test_client_async
___
[exec]
[exec] client =
[exec]
[exec] def test_client_async(client):
[exec] g = Graph().traversal()
[exec] t = g.V()
[exec] message = RequestMessage('traversal', 'bytecode',
{'gremlin': t.bytecode})
[exec] future = client.submitAsync(message)
[exec] > assert not future.done()
[exec] E assert not True
[exec] E+ where True = >()
[exec] E+where > = .done
[exec]
[exec] tests/driver/test_client.py:75: AssertionError
[exec] = 1 failed, 35 passed in 2.71 seconds
==
```
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (TINKERPOP-1362) nest steps in reference doc
[ https://issues.apache.org/jira/browse/TINKERPOP-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad closed TINKERPOP-1362. --- Resolution: Won't Fix > nest steps in reference doc > --- > > Key: TINKERPOP-1362 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1362 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Priority: Trivial > Labels: easyfix, newbie > > A colleague recommended that the reference doc should include links on the > left to some of the steps that are hidden underneath other steps. For example: > * Lambda Steps > ** Map > ** FlatMap > ** Filter > ** SideEffect > ** Branch > * Has Step > ** Has > ** HasLabel > ** HasId > ** HasKey > ** HasValue > ** HasNot -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1362) nest steps in reference doc
[ https://issues.apache.org/jira/browse/TINKERPOP-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890913#comment-15890913 ] Jason Plurad commented on TINKERPOP-1362: - I see what you're saying about the headers. I think the idea is good, but in practice it'll end up making the TOC too fine-grained. It is already very long as it is. > nest steps in reference doc > --- > > Key: TINKERPOP-1362 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1362 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Priority: Trivial > Labels: easyfix, newbie > > A colleague recommended that the reference doc should include links on the > left to some of the steps that are hidden underneath other steps. For example: > * Lambda Steps > ** Map > ** FlatMap > ** Filter > ** SideEffect > ** Branch > * Has Step > ** Has > ** HasLabel > ** HasId > ** HasKey > ** HasValue > ** HasNot -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (TINKERPOP-1340) docs do not state at what version an API was introduced (or deprecated)
[ https://issues.apache.org/jira/browse/TINKERPOP-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad reassigned TINKERPOP-1340: --- Assignee: stephen mallette > docs do not state at what version an API was introduced (or deprecated) > --- > > Key: TINKERPOP-1340 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1340 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: stephen mallette >Priority: Trivial > Fix For: 3.2.5 > > > An all-to-common problem for new developers coming to the TinkerPop is > figuring out which APIs work against the graph they are using. Since > TinkerPop is ahead of many graph implementation out there (Titan/TP 3.0.1, > Stardog/TP 3.0.2, Blazegraph/TP 3.1.0 -- kudos to Sqlg and Unipop for TP > 3.2.0!), it's really important that developers know which APIs in the current > docs are valid. Ideally the developers would go directly to that version of > the TP docs, but that doesn't always happen thanks to Google. > I propose doc updates on each Graph Traversal Step in the [reference > docs|http://tinkerpop.apache.org/docs/current/reference/#graph-traversal-steps] > and in the javadocs (on > [__.java|http://tinkerpop.apache.org/javadocs/current/full/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.html] > and on specific step implementations, i.e. > [AddEdgeStep.java|http://tinkerpop.apache.org/javadocs/current/full/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddEdgeStep.html]). > It should state the specific version (3.y.z) the API was introduced or > deprecated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (TINKERPOP-1340) docs do not state at what version an API was introduced (or deprecated)
[ https://issues.apache.org/jira/browse/TINKERPOP-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad closed TINKERPOP-1340. --- Resolution: Fixed > docs do not state at what version an API was introduced (or deprecated) > --- > > Key: TINKERPOP-1340 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1340 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: stephen mallette >Priority: Trivial > Fix For: 3.2.5 > > > An all-to-common problem for new developers coming to the TinkerPop is > figuring out which APIs work against the graph they are using. Since > TinkerPop is ahead of many graph implementation out there (Titan/TP 3.0.1, > Stardog/TP 3.0.2, Blazegraph/TP 3.1.0 -- kudos to Sqlg and Unipop for TP > 3.2.0!), it's really important that developers know which APIs in the current > docs are valid. Ideally the developers would go directly to that version of > the TP docs, but that doesn't always happen thanks to Google. > I propose doc updates on each Graph Traversal Step in the [reference > docs|http://tinkerpop.apache.org/docs/current/reference/#graph-traversal-steps] > and in the javadocs (on > [__.java|http://tinkerpop.apache.org/javadocs/current/full/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.html] > and on specific step implementations, i.e. > [AddEdgeStep.java|http://tinkerpop.apache.org/javadocs/current/full/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddEdgeStep.html]). > It should state the specific version (3.y.z) the API was introduced or > deprecated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1340) docs do not state at what version an API was introduced (or deprecated)
[ https://issues.apache.org/jira/browse/TINKERPOP-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890853#comment-15890853 ] Jason Plurad commented on TINKERPOP-1340: - Yes, this looks good. We'll be able to redirect version questions on the mailing list specifically to the GraphTraversal javadoc. Thanks for handling this. > docs do not state at what version an API was introduced (or deprecated) > --- > > Key: TINKERPOP-1340 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1340 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Priority: Trivial > Fix For: 3.2.5 > > > An all-to-common problem for new developers coming to the TinkerPop is > figuring out which APIs work against the graph they are using. Since > TinkerPop is ahead of many graph implementation out there (Titan/TP 3.0.1, > Stardog/TP 3.0.2, Blazegraph/TP 3.1.0 -- kudos to Sqlg and Unipop for TP > 3.2.0!), it's really important that developers know which APIs in the current > docs are valid. Ideally the developers would go directly to that version of > the TP docs, but that doesn't always happen thanks to Google. > I propose doc updates on each Graph Traversal Step in the [reference > docs|http://tinkerpop.apache.org/docs/current/reference/#graph-traversal-steps] > and in the javadocs (on > [__.java|http://tinkerpop.apache.org/javadocs/current/full/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.html] > and on specific step implementations, i.e. > [AddEdgeStep.java|http://tinkerpop.apache.org/javadocs/current/full/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddEdgeStep.html]). > It should state the specific version (3.y.z) the API was introduced or > deprecated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors
[
https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890804#comment-15890804
]
ASF GitHub Bot commented on TINKERPOP-1640:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/566
VOTE +1
> ComputerVerificationStrategy gives false errors
> ---
>
> Key: TINKERPOP-1640
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> I've added a new complex test that fails in OLAP. Unfortunately the test
> runner only marks the test as "ignored" as that's what we usually we want
> when a {{VerificationException}} is thrown. However, in this case the
> exception ("It is not possible to access more than a path element's id on
> GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization
> exceptions in the {{\*Translator\*}} test suites.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop issue #566: TINKERPOP-1640: ComputerVerificationStrategy gives fal...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/566 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors
[
https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890776#comment-15890776
]
ASF GitHub Bot commented on TINKERPOP-1640:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/566
`docker/build.sh -t -i` succeeded.
VOTE: +1
> ComputerVerificationStrategy gives false errors
> ---
>
> Key: TINKERPOP-1640
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> I've added a new complex test that fails in OLAP. Unfortunately the test
> runner only marks the test as "ignored" as that's what we usually we want
> when a {{VerificationException}} is thrown. However, in this case the
> exception ("It is not possible to access more than a path element's id on
> GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization
> exceptions in the {{\*Translator\*}} test suites.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (TINKERPOP-1642) Improve performance of mutating traversals
stephen mallette created TINKERPOP-1642:
---
Summary: Improve performance of mutating traversals
Key: TINKERPOP-1642
URL: https://issues.apache.org/jira/browse/TINKERPOP-1642
Project: TinkerPop
Issue Type: Improvement
Components: process
Affects Versions: 3.2.4
Reporter: stephen mallette
Assignee: stephen mallette
Priority: Critical
Make an attempt improve performance of mutating traversals. Some general goals
for this ticket should be to:
1. Improve performance parity of structure and process methods for modifying
the graph - structure is pretty far ahead.
2. Improve the speed of large chained mutating traversals - see
http://stackoverflow.com/q/41926409/1831717
3. Determine ways to make these performance improvements in {{gremlin-core}} so
that they may benefit all {{Graph}} implementations
4. Improve the speed of TinkerGraph specifically if possible as it is used for
subgraphing functions in many cases and ends up being useful regardless of the
graph implementation ultimately used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop issue #566: TINKERPOP-1640: ComputerVerificationStrategy gives fal...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/566 `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TINKERPOP-1599) implement real gremlin-python driver
[
https://issues.apache.org/jira/browse/TINKERPOP-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1599.
---
> implement real gremlin-python driver
>
>
> Key: TINKERPOP-1599
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1599
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, language-variant
>Affects Versions: 3.2.3
>Reporter: David M. Brown
>Assignee: David M. Brown
> Fix For: 3.2.5
>
>
> It is high time that gremlin-python comes packaged with a real driver. After
> watching the community discussion, it seems that the way to go will be to use
> the {{concurrent.futures}} module with multithreading to provide asynchronous
> I/O. While the default underlying websocket client library will remain
> Tornado due to Python 2/3 compatibility issues, this should be decoupled from
> the rest of the client and easy to replace.
> With this is mind, I created a baseline client implementation with [this
> commit|https://github.com/apache/tinkerpop/commit/fb7e7f255585956abbb854fcc5dd3138113cf454]
> in a topic branch {{python_driver}}. Some things to note:
> - All I/O is performed using the {{concurrent.futures}} module, which
> provides a standard 2/3 compatible future interface.
> - The implementation currently does not include the concept of a cluster,
> instead it assumes a single host.
> - The {{transport}} interface makes it easy to plug in client libraries by
> defining a simple wrapper.
> - Because this is an example, I didn't fix all the tests to work with the new
> client implementation. Instead I just added a few demo tests. If we decide to
> move forward with this I will update the original tests.
> The resulting API looks like this for a simple client:
> {code}
> client = Client('ws://localhost:8182/gremlin', 'g')
> g = Graph().traversal()
> t = g.V()
> future_result_set = client.submitAsync(t.bytecode)
> result_set = future_result_set.result()
> results = result_set.all().result()
> client.close()
> {code}
> Using the {{DriverRemoteConnection}}:
> {code}
> conn = DriverRemoteConnection('ws://localhost:8182/gremlin', 'g')
> g = Graph().traversal().withRemote(conn)
> t = g.V()
> results = t.toList()
> conn.close()
> {code}
> If you have a minute to check out the new driver code that would be great, I
> welcome feedback and suggestions. If we decide to move forward like this, I
> will proceed to finish the driver implementation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors
[
https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890677#comment-15890677
]
ASF GitHub Bot commented on TINKERPOP-1640:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/566
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 03:28 h
[INFO] Finished at: 2017-03-01T10:27:04-07:00
[INFO] Final Memory: 144M/1664M
[INFO]
```
> ComputerVerificationStrategy gives false errors
> ---
>
> Key: TINKERPOP-1640
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> I've added a new complex test that fails in OLAP. Unfortunately the test
> runner only marks the test as "ignored" as that's what we usually we want
> when a {{VerificationException}} is thrown. However, in this case the
> exception ("It is not possible to access more than a path element's id on
> GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization
> exceptions in the {{\*Translator\*}} test suites.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop issue #566: TINKERPOP-1640: ComputerVerificationStrategy gives fal...
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/566 ``` [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:28 h [INFO] Finished at: 2017-03-01T10:27:04-07:00 [INFO] Final Memory: 144M/1664M [INFO] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors
[ https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890093#comment-15890093 ] ASF GitHub Bot commented on TINKERPOP-1640: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/566 Took a body of failure with the docker build: ```text Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.663 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest shouldHandleSideEffectsCorrectly(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest) Time elapsed: 0.347 sec <<< ERROR! org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException: VertexComputing steps must be executed with a GraphComputer: [TraversalVertexProgramStep([GraphStep(vertex,[]), CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])] at org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114) at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.(TraversalExplanation.java:58) at org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225) at org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest.shouldHandleSideEffectsCorrectly(SparkInterceptorStrategyTest.java:73) shouldSuccessfullyEvaluateInterceptedTraversals(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest) Time elapsed: 0.315 sec <<< ERROR! org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException: VertexComputing steps must be executed with a GraphComputer: [TraversalVertexProgramStep([GraphStep(vertex,[]), CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])] at org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114) at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.(TraversalExplanation.java:58) at org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225) at org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest.shouldSuccessfullyEvaluateInterceptedTraversals(SparkInterceptorStrategyTest.java:101) Running org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.339 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest shouldSuccessfullyEvaluateSingleIterationTraversals(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest) Time elapsed: 0.339 sec <<< ERROR! org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException: VertexComputing steps must be executed with a GraphComputer: [TraversalVertexProgramStep([GraphStep(vertex,[]), CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])] at org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114) at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.(TraversalExplanation.java:58) at org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225) at org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest.shouldSuccessfullyEvaluateSingleIterationTraversals(SparkSingleIterationStrategyT
[GitHub] tinkerpop issue #566: TINKERPOP-1640: ComputerVerificationStrategy gives fal...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/566 Took a body of failure with the docker build: ```text Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.663 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest shouldHandleSideEffectsCorrectly(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest) Time elapsed: 0.347 sec <<< ERROR! org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException: VertexComputing steps must be executed with a GraphComputer: [TraversalVertexProgramStep([GraphStep(vertex,[]), CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])] at org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114) at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.(TraversalExplanation.java:58) at org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225) at org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest.shouldHandleSideEffectsCorrectly(SparkInterceptorStrategyTest.java:73) shouldSuccessfullyEvaluateInterceptedTraversals(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest) Time elapsed: 0.315 sec <<< ERROR! org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException: VertexComputing steps must be executed with a GraphComputer: [TraversalVertexProgramStep([GraphStep(vertex,[]), CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])] at org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114) at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.(TraversalExplanation.java:58) at org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225) at org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest.shouldSuccessfullyEvaluateInterceptedTraversals(SparkInterceptorStrategyTest.java:101) Running org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.339 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest shouldSuccessfullyEvaluateSingleIterationTraversals(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest) Time elapsed: 0.339 sec <<< ERROR! org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException: VertexComputing steps must be executed with a GraphComputer: [TraversalVertexProgramStep([GraphStep(vertex,[]), CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])] at org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114) at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.(TraversalExplanation.java:58) at org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225) at org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest.shouldSuccessfullyEvaluateSingleIterationTraversals(SparkSingleIterationStrategyTest.java:72) Running org.apache.tinkerpop.gremlin.spark.process.computer.CombineIteratorTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.633 sec - in org.apache.tinkerpop.gremlin.spark.process.computer.CombineIteratorTest Runni
